March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Declare typed variables in GetVmsByStorageDomainQuer...
by masayag＠redhat.com 19 Mar '15

19 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Declare typed variables in GetVmsByStorageDomainQueryTest ...................................................................... engine: Declare typed variables in GetVmsByStorageDomainQueryTest Change-Id: Ief2e487e2c9eb2b8ef86bcad6a3897cab402d5bc Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief2e487e2c9eb2b8ef86bcad6a3897cab402d5bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Declare typed variables UpdateVmDiskCommandTest
by masayag＠redhat.com 19 Mar '15

19 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Declare typed variables UpdateVmDiskCommandTest ...................................................................... engine: Declare typed variables UpdateVmDiskCommandTest Change-Id: I3a8127aa84fa15fef7e893c0eb25402efc0f644c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a8127aa84fa15fef7e893c0eb25402efc0f644c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove dead code from DiskImageBase
by masayag＠redhat.com 19 Mar '15

19 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: core: remove dead code from DiskImageBase ...................................................................... core: remove dead code from DiskImageBase Change-Id: Ib3d94cf85b96fa0ccb51d6ccf5817b03a8ab9688 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskImageBase.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d94cf85b96fa0ccb51d6ccf5817b03a8ab9688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: rename CompositeTooltipCell -> CompositeCell
by awels＠redhat.com 19 Mar '15

19 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: rename CompositeTooltipCell -> CompositeCell ...................................................................... webadmin: rename CompositeTooltipCell -> CompositeCell (Patch 4aq of 12) No functional changes -- just a rename. Change-Id: I1aad9901c21f7447ffb83c8843eeef6da2b52c99 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 4 files changed, 16 insertions(+), 13 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aad9901c21f7447ffb83c8843eeef6da2b52c99 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: remove 'keepTitleOnSetEnabled' property
by awels＠redhat.com 19 Mar '15

19 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: remove 'keepTitleOnSetEnabled' property ...................................................................... webadmin: remove 'keepTitleOnSetEnabled' property (Patch 4ap of 12) Removed 'keepTitleOnSetEnabled' property from AbstractValidatedWidgetWithLabel. New tooltips are always enabled on AbstractValidatedWidgetWithLabel. Change-Id: Iea8e449bc720ff32c9936bf78cd0e4e54bce50a6 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 2 files changed, 1 insertion(+), 19 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea8e449bc720ff32c9936bf78cd0e4e54bce50a6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Clear redundant warnings
by oourfali＠redhat.com 19 Mar '15

19 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Clear redundant warnings ...................................................................... engine: Clear redundant warnings Change-Id: I8d5f5470ebf851b734e9a157d5fa57f54cec9acf Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/StandaloneDataSource.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5f5470ebf851b734e9a157d5fa57f54cec9acf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: cleanup StorageDeviceStatusCell
by awels＠redhat.com 19 Mar '15

19 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: cleanup StorageDeviceStatusCell ...................................................................... webadmin: cleanup StorageDeviceStatusCell (Patch 4ao of 12) Cleanup some messy code in StorageDeviceStatusCell. No functional changes -- just a refactor. Change-Id: I759073cdc01d4ba22bccb07d7b2ae54eaf38b3b7 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDeviceStatusCell.java 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759073cdc01d4ba22bccb07d7b2ae54eaf38b3b7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: changed custom Cell classes to set IDs...
by awels＠redhat.com 19 Mar '15

19 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: changed custom Cell classes to set IDs pt 2 ...................................................................... userportal, webadmin: changed custom Cell classes to set IDs pt 2 (Patch 4an of 12) Changed all of our custom Cell classes to use the Element ID framework and set IDs on their renderings. (Missed a few -- fixed in this patch.) No functional changes -- just makes it easier for Selenium testing. Change-Id: Idb15db81e13e3ebb2fd30f891b1130d5009465a7 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeBrickStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeCapacityCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeTaskWaitingCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/AbstractProgressBarColumn.java 8 files changed, 35 insertions(+), 31 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb15db81e13e3ebb2fd30f891b1130d5009465a7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: changed GWT-TODO -> TODO-GWT
by awels＠redhat.com 19 Mar '15

19 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: changed GWT-TODO -> TODO-GWT ...................................................................... userportal, webadmin: changed GWT-TODO -> TODO-GWT (Patch 4al of 12) We had a few stray 'GWT-TODO' instead of the correct 'TODO-GWT'. Fixed. No functional changes -- just comment lines. Change-Id: I5f398672c96387b692b171c934bf8e88436e6796 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/utils/EnumUtils.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f398672c96387b692b171c934bf8e88436e6796 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: added TODO-GWT to BookmarkList
by awels＠redhat.com 19 Mar '15

19 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: added TODO-GWT to BookmarkList ...................................................................... userportal, webadmin: added TODO-GWT to BookmarkList (Patch 4ak of 12) BookmarkList mentioned a GWT bug, but did not have a TODO-GWT marker. Added the comment. No functional changes -- just a comment line. Change-Id: I5bc03964ede462878fd8df89ea67d6282dfb11aa Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/bookmark/BookmarkList.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bc03964ede462878fd8df89ea67d6282dfb11aa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0