March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Standardize CommandEntity
by oourfali＠redhat.com 16 Mar '15

16 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Standardize CommandEntity ...................................................................... engine: Standardize CommandEntity * Maintain camelCase * Remove default values assignment to local variables * Initialize variable in c'tor Change-Id: I5969a09137e2e52d903dd8abf5bfe1234844901d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java 10 files changed, 40 insertions(+), 34 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5969a09137e2e52d903dd8abf5bfe1234844901d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Maintain camelCase for Callback in CommandBase
by oourfali＠redhat.com 16 Mar '15

16 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Maintain camelCase for Callback in CommandBase ...................................................................... engine: Maintain camelCase for Callback in CommandBase Change-Id: Ifda88ff9040361c5fe6f04b9d5577aca9fa8c822 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifda88ff9040361c5fe6f04b9d5577aca9fa8c822 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Rename CommandCallBack to CommandCallback
by oourfali＠redhat.com 16 Mar '15

16 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Rename CommandCallBack to CommandCallback ...................................................................... engine: Rename CommandCallBack to CommandCallback Maintain camelCase naming convention Change-Id: I8199aa4566f1e3f3cbe1809ec4b4de1743544d6b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallback.java 13 files changed, 31 insertions(+), 31 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8199aa4566f1e3f3cbe1809ec4b4de1743544d6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Organize imports of CopyOnAccessMap
by oourfali＠redhat.com 16 Mar '15

16 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Organize imports of CopyOnAccessMap ...................................................................... engine: Organize imports of CopyOnAccessMap Change-Id: Id1087f527db9f67bcce1e29a7516a0266e1c7eac Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/CopyOnAccessMap.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1087f527db9f67bcce1e29a7516a0266e1c7eac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix typos and suppress warnings in Injector
by oourfali＠redhat.com 16 Mar '15

16 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Fix typos and suppress warnings in Injector ...................................................................... engine: Fix typos and suppress warnings in Injector Change-Id: I9893a8f525b458e3da33d2ba2431fffcb32dc3c3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/di/Injector.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9893a8f525b458e3da33d2ba2431fffcb32dc3c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove redundant casting of ReturnValue
by derez＠redhat.com 16 Mar '15

16 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: remove redundant casting of ReturnValue ...................................................................... core: remove redundant casting of ReturnValue AddStoragePoolWithStoragesCommand: removed a redundant casting since 'VdcQueryReturnValue -> getReturnValue()' is already using generics. Change-Id: I60374b234508edfa0f901bcaa13d3781ddb03795 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60374b234508edfa0f901bcaa13d3781ddb03795 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Warning on dependent VMs on delete template
by derez＠redhat.com 16 Mar '15

16 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Warning on dependent VMs on delete template ...................................................................... webadmin: Warning on dependent VMs on delete template When removing a backup template from an export domain, we check if dependent backup VMs exist. If such exists, a confirmation message will be prompt to the user with the name of the VMs. Change-Id: I8cba5df5a41973741a855ae0c9efddd56100d2fd Bug-Url: https://bugzilla.redhat.com/1162532 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 4 files changed, 127 insertions(+), 19 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Fred Rolland: Verified -- To view, visit https://gerrit.ovirt.org/37514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cba5df5a41973741a855ae0c9efddd56100d2fd Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Moved textWithTooltip() to CommonApplicationTemplates
by derez＠redhat.com 15 Mar '15

15 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Moved textWithTooltip() to CommonApplicationTemplates ...................................................................... webadmin: Moved textWithTooltip() to CommonApplicationTemplates The method textWithTooltip() can be useful also in gwt-common. Change-Id: Iaec46c7a14c19cca28aa3cb4d00bce306d3c734f Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/38661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaec46c7a14c19cca28aa3cb4d00bce306d3c734f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: verify storage pool perms on attach domain
by derez＠redhat.com 15 Mar '15

15 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: core: verify storage pool perms on attach domain ...................................................................... core: verify storage pool perms on attach domain AttachStorageDomainToPoolCommand: Verify perms on a non-first storage domain attached to a DC. Change-Id: Ife66dd444cb1809fef328a72faebe091c40e0071 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife66dd444cb1809fef328a72faebe091c40e0071 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Re-indent lines in VmDiskAttachPopupWidget.ui.xml
by derez＠redhat.com 15 Mar '15

15 Mar '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Re-indent lines in VmDiskAttachPopupWidget.ui.xml ...................................................................... webadmin: Re-indent lines in VmDiskAttachPopupWidget.ui.xml Replaced tabs with 4 spaces. Change-Id: Iad4370acbda7fa53b0cd55352f0d0e4b48da81b3 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml 1 file changed, 33 insertions(+), 33 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/38660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad4370acbda7fa53b0cd55352f0d0e4b48da81b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0