Change in ovirt-engine[master]: engine: Reduce need for constant casting
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Reduce need for constant casting
......................................................................
engine: Reduce need for constant casting
By generics we can simplify the usage of the CoCo util
and avoid constant casting by the clients.
Change-Id: Iee9caa732a0a2d84889d9dd6d0e0a4e5e06397c8
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
6 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Moti Asayag: Verified
Arik Hadas: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38667
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee9caa732a0a2d84889d9dd6d0e0a4e5e06397c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix punctuation in threshold warnings
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix punctuation in threshold warnings
......................................................................
webadmin: Fix punctuation in threshold warnings
audit log messages were missing points and a space.
Change-Id: If30f094e52f42b78537e215a2699cf74c248bd83
Bug-Url: https://bugzilla.redhat.com/1201385
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/38677
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If30f094e52f42b78537e215a2699cf74c248bd83
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
9 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Quering FCP unregistered Storage Domains
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Quering FCP unregistered Storage Domains
......................................................................
restapi: Quering FCP unregistered Storage Domains
Adding the possibility to execute a query to get all the
unregistered storage domain of FCP.
If the user does not apply an iscsi address in the request the REST
query for unregistered Storage Domains of FCP type.
Change-Id: Iafe2f2afcd0e6e68adbbbb2054c857388acc30a7
Bug-Url: https://bugzilla.redhat.com/1201158
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
2 files changed, 14 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/38634
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafe2f2afcd0e6e68adbbbb2054c857388acc30a7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin: Host General sub tab
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Host General sub tab
......................................................................
webadmin: Host General sub tab
- The number of fields in the host general sub tab is becoming
unmanageable so we are breaking the general sub tab out into
3 sub sub tabs.
- Info General information that changes relatively often.
- Software The software running on the host.
- Hardware This removes the hardware sub tab and moves it under
the General sub tab.
- Fixed issue with sub sub tabs not loading properly when refreshing
the browser.
Change-Id: Ie70cee7d4c5742a51ba6084968cf8617d0e2680e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1184551
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/datacenter/DataCenterQosSubTabPanelPresenter.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/HostGeneralSubTabPanelPresenter.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralHardwarePresenter.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java
C frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralSoftwarePresenter.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/HostGeneralSubTabPanelView.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralHardwareView.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralHardwareView.ui.xml
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralInfoView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralInfoView.ui.xml
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.ui.xml
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.ui.xml
17 files changed, 453 insertions(+), 146 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie70cee7d4c5742a51ba6084968cf8617d0e2680e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin : CheckBoxGroup and DaysOfMonthSelector Widgets
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin : CheckBoxGroup and DaysOfMonthSelector Widgets
......................................................................
webadmin : CheckBoxGroup and DaysOfMonthSelector Widgets
CheckBoxGroup Widget and DaysOfMonthSelector Widgets
Change-Id: I38daa0d2c151eb0e34603488496a8a1ea4719c87
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/CheckBoxGroup.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/CheckBoxGroupCss.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelector.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelectorCss.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelCheckBoxGroup.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelCheckBoxGroupEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelDaysOfMonthSelector.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelDaysOfMonthSelectorEditor.java
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/CheckBoxGroup.css
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/DaysOfMonthSelector.css
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
11 files changed, 628 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
anmolbabu: Verified
--
To view, visit https://gerrit.ovirt.org/37302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38daa0d2c151eb0e34603488496a8a1ea4719c87
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: userportal, webadmin: sub menu positioning
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: sub menu positioning
......................................................................
userportal,webadmin: sub menu positioning
- When a sub menu (such as the reports) would show up and
there was no enough room to show the menu to the right and
below the menu, it would move the sub menu higher so it can
fit on the screen, but it would not take into account that
the bottom of the sub menu needs to line up with the bottom
of the item of menu that is associated with the sub menu.
This patch does take the height of the menu item into account
when calculating the position of the sub menu.
Change-Id: I8500c8737ec24d3ade438c6924620eedc7b4fc55
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1184983
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/PopupUtils.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java
2 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37297
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8500c8737ec24d3ade438c6924620eedc7b4fc55
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin: changed AbstractImageButtonCell type param to C
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: changed AbstractImageButtonCell type param to C
......................................................................
webadmin: changed AbstractImageButtonCell type param to C
(Patch 4w of 12)
No logic changes. Just a rename.
Change-Id: I55baa789995a34f8f914a323e3ace3034000b09e
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38673
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55baa789995a34f8f914a323e3ace3034000b09e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin: moved ImageButtonCell to gwt-common project
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: moved ImageButtonCell to gwt-common project
......................................................................
webadmin: moved ImageButtonCell to gwt-common project
(Patch 4v of 12)
Moved ImageButtonCell from userportal to gwt-common.
No logic changes. Just a move.
Change-Id: I727061d50b62bfc2eec8d68f868c5b8ff2d20c47
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/ImageButtonCell.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I727061d50b62bfc2eec8d68f868c5b8ff2d20c47
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin: extract static classes
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: extract static classes
......................................................................
webadmin: extract static classes
(Patch 4u of 12)
Exracted EnabledDisabledCheckboxCell and EnabledDisabledRadioCell from being
static classes inside AbstractCheckboxColumn.
No logic changes. Just a move.
Change-Id: I6fe2b1d51655be5e3f07c837ed403d66e381dd78
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCheckboxColumn.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/EnabledDisabledCheckboxCell.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/EnabledDisabledRadioCell.java
3 files changed, 45 insertions(+), 30 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38633
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fe2b1d51655be5e3f07c837ed403d66e381dd78
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months
Change in ovirt-engine[master]: webadmin: rename AbstractColumn -> AbstractTooltipColumn
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: rename AbstractColumn -> AbstractTooltipColumn
......................................................................
webadmin: rename AbstractColumn -> AbstractTooltipColumn
(Patch 4t of 12)
No logic changes. Just a rename.
Change-Id: Ia54a43bc958fb7dffaf0bb6d01c6af3943502873
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTooltipColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CommentColumn2.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38632
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia54a43bc958fb7dffaf0bb6d01c6af3943502873
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 3 months