March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: English grammar fix (isCentralized -> centered)
by awels＠redhat.com 13 Mar '15

13 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: English grammar fix (isCentralized -> centered) ...................................................................... webadmin: English grammar fix (isCentralized -> centered) (Patch 4s of 12) No logic changes. Just a rename. Change-Id: I792aed38769a0d3aea2aecd75884d85b45b1abe2 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCheckboxColumn.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792aed38769a0d3aea2aecd75884d85b45b1abe2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: renamed StyledImageResourceCell -> Ima...
by awels＠redhat.com 13 Mar '15

13 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: renamed StyledImageResourceCell -> ImageResourceCell ...................................................................... userportal, webadmin: renamed StyledImageResourceCell -> ImageResourceCell (Patch 4r of 12) renamed StyledImageResourceCell -> ImageResourceCell renamed column/ImageResourceCell -> ImageResourceCell2 No logic changes. Just a rename. Change-Id: Iad66b635dd68204c79d1dc0e4fd1d81717769990 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/ImageResourceCell.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/ImageResourceCell2.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LunSelectionCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractImageResourceColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CommentColumn2.java 6 files changed, 16 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad66b635dd68204c79d1dc0e4fd1d81717769990 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: return different exit statuses
by sbonazzo＠redhat.com 13 Mar '15

13 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: return different exit statuses ...................................................................... packaging: setup: return different exit statuses Change-Id: If9514e1d9332f0eed856d065ad4ecb28bbabaa62 Bug-Url: https://bugzilla.redhat.com/1079726 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py 3 files changed, 19 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/35503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9514e1d9332f0eed856d065ad4ecb28bbabaa62 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: avoid setting AsyncTaskZombieTaskLifeInMin...
by sbonazzo＠redhat.com 13 Mar '15

13 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid setting AsyncTaskZombieTaskLifeInMinutes to 0 ...................................................................... packaging: setup: avoid setting AsyncTaskZombieTaskLifeInMinutes to 0 Avoid setting AsyncTaskZombieTaskLifeInMinutes to 0 otherwise every task is always considered a zombie. Change-Id: Ia7bdf24831e8974daa5fd6735c1402a8cb12b6ea Bug-Url: https://bugzilla.redhat.com/1161012 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py 1 file changed, 1 insertion(+), 27 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7bdf24831e8974daa5fd6735c1402a8cb12b6ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : GeoRep Config popup view
by kmayilsa＠redhat.com 13 Mar '15

13 Mar '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : GeoRep Config popup view ...................................................................... webadmin : GeoRep Config popup view Change-Id: I150946fe016d85cb378ed3d548eab5581321fbfe Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/GlusterConfigAwareCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/GlusterConfigAwareColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoReplicationSessionConfigModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeoRepView.java 13 files changed, 550 insertions(+), 16 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/34217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I150946fe016d85cb378ed3d548eab5581321fbfe Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix for NPE in GlusterStorageDeviceListModel
by kmayilsa＠redhat.com 13 Mar '15

13 Mar '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix for NPE in GlusterStorageDeviceListModel ...................................................................... gluster: fix for NPE in GlusterStorageDeviceListModel Fix the NPE in HostGlusterStorageDevicesListModel. updateActionAvailability(). setEntity() will called with null when moving form hosts tab to other main tabs with Storage Devices tab being acitve. Handling this case with the patch Change-Id: Ie046c2213d4f551d2e818fc1f5b1e2d3b313a022 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: anmolbabu: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/38703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie046c2213d4f551d2e818fc1f5b1e2d3b313a022 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: renamed DecoratedImageResouceCell -> D...
by awels＠redhat.com 12 Mar '15

12 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: renamed DecoratedImageResouceCell -> DecoratedImageResourceCell ...................................................................... userportal, webadmin: renamed DecoratedImageResouceCell -> DecoratedImageResourceCell (Patch 4q of 12) No logic changes. Just a rename. Change-Id: Ib62dd35b22e8e8ded050ca56fd7688306548fcf4 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DecoratedImageResourceCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractDecoratedImageColumn.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib62dd35b22e8e8ded050ca56fd7688306548fcf4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: renamed CompositeCellWithElementId -> ...
by awels＠redhat.com 12 Mar '15

12 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: renamed CompositeCellWithElementId -> CompositeTooltipCell ...................................................................... userportal, webadmin: renamed CompositeCellWithElementId -> CompositeTooltipCell (Patch 4p of 12) No logic changes. Just a rename. Change-Id: Ifb8f348dc48b0e8a5101b715a1ba8c64fc2447a3 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CompositeTooltipCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8f348dc48b0e8a5101b715a1ba8c64fc2447a3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: CellWithElementId comment cleanup
by awels＠redhat.com 12 Mar '15

12 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: CellWithElementId comment cleanup ...................................................................... userportal, webadmin: CellWithElementId comment cleanup (Patch 4o of 12) Change-Id: I89a67ab19279d00b8f88b3d5ec1152b0cda69101 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/idhandler/CellWithElementId.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89a67ab19279d00b8f88b3d5ec1152b0cda69101 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: AbstractTooltipCell fixup
by awels＠redhat.com 12 Mar '15

12 Mar '15

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: AbstractTooltipCell fixup ...................................................................... userportal, webadmin: AbstractTooltipCell fixup (Patch 4n of 12) Forgot to mark methods as final. Forgot to call super() from onBrowserEvent. Fixed. Change-Id: Id31767ca21fdfc4f4c94d88870068fbda7b834d3 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/38620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31767ca21fdfc4f4c94d88870068fbda7b834d3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0