Change in ovirt-engine[master]: engine: Add type argument to CommandBase
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Add type argument to CommandBase
......................................................................
engine: Add type argument to CommandBase
Change-Id: If307b519d358449ea84c9fadcf1142f760044d2c
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/TaskHelper.java
2 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If307b519d358449ea84c9fadcf1142f760044d2c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: engine: Simplify getChildCommandIds(Guid) * Remove local var...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Simplify getChildCommandIds(Guid) * Remove local variable * Use typed empty list from Collections.
......................................................................
engine: Simplify getChildCommandIds(Guid)
* Remove local variable
* Use typed empty list from Collections.
Change-Id: I59703183876498db2a4cc157176e87817bd2ef92
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38520
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59703183876498db2a4cc157176e87817bd2ef92
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename SafeHtmlCellWithTooltip -> Safe...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename SafeHtmlCellWithTooltip -> SafeHtmlCell
......................................................................
userportal, webadmin: rename SafeHtmlCellWithTooltip -> SafeHtmlCell
(Patch 4i of 12)
No logic changes. Just a rename.
Change-Id: I0b5d0a714ee5cfd91a2b6c718b906a5c46677a1f
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/SafeHtmlCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizableHeader.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
4 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b5d0a714ee5cfd91a2b6c718b906a5c46677a1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename InterfaceLabelWithToolTip -> In...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename InterfaceLabelWithToolTip -> InterfaceLabel
......................................................................
userportal, webadmin: rename InterfaceLabelWithToolTip -> InterfaceLabel
(Patch 4h of 12)
No logic changes. Just a rena
Change-Id: Ib6ab27239b1ba1480202fbca04554f7a4dbe5130
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38613
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6ab27239b1ba1480202fbca04554f7a4dbe5130
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename AbstractLinkColumnWithTooltip -...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename AbstractLinkColumnWithTooltip -> AbstractLinkColumn
......................................................................
userportal, webadmin: rename AbstractLinkColumnWithTooltip -> AbstractLinkColumn
(Patch 4g of 12)
No logic changes. Just a rename.
Change-Id: I8f2322629b86fb4610a49d24741a228f424d3c59
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java
3 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f2322629b86fb4610a49d24741a228f424d3c59
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename AbstractImageWithDecoratorColum...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename AbstractImageWithDecoratorColumn -> AbstractDecoratedImageColumn
......................................................................
userportal, webadmin: rename AbstractImageWithDecoratorColumn -> AbstractDecoratedImageColumn
(Patch 4f of 12)
No logic changes. Just a rename.
Change-Id: I1ad09c4ddbbbf902629568e2984bba76c290e1ee
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractDecoratedImageColumn.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38611
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ad09c4ddbbbf902629568e2984bba76c290e1ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename AbstractEditTextColumnWithToolt...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename AbstractEditTextColumnWithTooltip -> AbstractEditTextColumn
......................................................................
userportal, webadmin: rename AbstractEditTextColumnWithTooltip -> AbstractEditTextColumn
(Patch 4e of 12)
No logic changes. Just a rename.
Change-Id: Iaa068fa126c13e85e4c32686d8b22707f2bc0186
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38610
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa068fa126c13e85e4c32686d8b22707f2bc0186
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename TextCellWithTooltip -> TextCell
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename TextCellWithTooltip -> TextCell
......................................................................
userportal, webadmin: rename TextCellWithTooltip -> TextCell
(Patch 4d of 12)
No logic changes. Just a rename.
Change-Id: Ibf859166a879b9018f861c42b748a6a46cc3c9da
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/DiskContainersCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EditTextCellWithTooltip.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StorageDomainsCell.java
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractEditTextColumnWithTooltip.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumn.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
11 files changed, 30 insertions(+), 30 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf859166a879b9018f861c42b748a6a46cc3c9da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: webadmin: deleted redundant class AbstractTextColumnWithEdit...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: deleted redundant class AbstractTextColumnWithEditableTooltip
......................................................................
webadmin: deleted redundant class AbstractTextColumnWithEditableTooltip
(Patch 4c of 12)
Change-Id: I5ff0399cbd21680ee7707b7f0702352314673122
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/TextCellWithEditableTooltip.java
D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractTextColumnWithEditableTooltip.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
3 files changed, 6 insertions(+), 75 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ff0399cbd21680ee7707b7f0702352314673122
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months
Change in ovirt-engine[master]: userportal, webadmin: rename AbstractLinkColumnWithTooltip -...
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: userportal, webadmin: rename AbstractLinkColumnWithTooltip -> AbstractLinkColumn
......................................................................
userportal, webadmin: rename AbstractLinkColumnWithTooltip -> AbstractLinkColumn
(Patch 4b of 12)
No logic changes. Just a rename.
Change-Id: Ia49e1b78d977751f7551774182e3b78073f09e03
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/LinkCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/38607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia49e1b78d977751f7551774182e3b78073f09e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 9 months