March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: Add metadata cleanup functionality
by msivak＠redhat.com 10 Mar '15

10 Mar '15

Martin Sivák has submitted this change and it was merged. Change subject: Add metadata cleanup functionality ...................................................................... Add metadata cleanup functionality This patch adds a new command line arguments to the agent service. --host-id, --clean and --force-clean The agent connects to vdsm, broker and storage as usual, cleans its metadata block using 0x0 bytes and quits. If the metadata block contains dirty status (crc does not match or stopped is not True) the agent reports an error and quits. The force-clean option overrides this. The host-id option can be used to clean metadata of other agent from another hosted engine enabled host (the operation requires running broker and proper storage configuration). This change also releases sanlock when the agent stops. Change-Id: I4e0979bdfc45e7e07c9970994d98dfa1c9c94be0 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/agent.py M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/lib/metadata.py 3 files changed, 93 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e0979bdfc45e7e07c9970994d98dfa1c9c94be0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: setup: answer file: SAN wipe after delete
by sbonazzo＠redhat.com 10 Mar '15

10 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: answer file: SAN wipe after delete ...................................................................... setup: answer file: SAN wipe after delete Bug-Url: https://bugzilla.redhat.com/1161219 Change-Id: I9f9a31de643aa41ff954f5f6a34cee4ff5b87431 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M centos-6/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f9a31de643aa41ff954f5f6a34cee4ff5b87431 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: in-memory lock for imported vm
by ahadas＠redhat.com 10 Mar '15

10 Mar '15

Arik Hadas has submitted this change and it was merged. Change subject: core: in-memory lock for imported vm ...................................................................... core: in-memory lock for imported vm Lock the VM that is being imported with in-memory lock for the whole import operation. Change-Id: I13970306bfc01e11a1d130f5ae818971e18c9634 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 2 files changed, 29 insertions(+), 14 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13970306bfc01e11a1d130f5ae818971e18c9634 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: show storage devices in host
by kmayilsa＠redhat.com 10 Mar '15

10 Mar '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: show storage devices in host ...................................................................... webadmin: show storage devices in host Show all available storage devices in 'Storage Devies' sub tab under Hosts . Change-Id: I10da2f35012795de32367f295260ce9151c44909 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterHostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGlusterStorageDevicesPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGlusterStorageDevicesView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDeviceStatusCell.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDeviceStatusColumn.java 18 files changed, 476 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/35315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10da2f35012795de32367f295260ce9151c44909 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: handling previously generated answerfile w...
by sbonazzo＠redhat.com 10 Mar '15

10 Mar '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: handling previously generated answerfile with wrong types ...................................................................... packaging: setup: handling previously generated answerfile with wrong types Till 3.5 we were threating some VM parameters as integer is read from the OVF file and as string if manually entered. It was not really an issue cause we were than generating a temporary configuration fail for vdsClient usage with an implicit string conversion. Now we are using vdsclient and so we have to use the correct type and so we need also to handle answerfile generated from previously release where the type could be not correct. Change-Id: I07c296c4ef92430f03a5b23a2a996db9c643a9c5 Bug-Url: https://bugzilla.redhat.com/1198725 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cpu.py M src/plugins/ovirt-hosted-engine-setup/vm/memory.py 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/38417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07c296c4ef92430f03a5b23a2a996db9c643a9c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add 'maintenance_reason_required' property to Cluster
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Add 'maintenance_reason_required' property to Cluster ...................................................................... restapi: Add 'maintenance_reason_required' property to Cluster Change-Id: Ie05d5e25b0a65e387027042a5aff425a4010a305 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie05d5e25b0a65e387027042a5aff425a4010a305 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Setting and getting the host maintenance reason
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Setting and getting the host maintenance reason ...................................................................... restapi: Setting and getting the host maintenance reason Change-Id: Ie1c920672e68e5cb10d99ff3c4988ee4dade04f3 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 4 files changed, 10 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1c920672e68e5cb10d99ff3c4988ee4dade04f3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Showing the tooltip of the reason column
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Showing the tooltip of the reason column ...................................................................... webadmin: Showing the tooltip of the reason column Change-Id: Ie63a98a880b67bdfdb6a57ad840f4f2efed9155c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java 1 file changed, 16 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie63a98a880b67bdfdb6a57ad840f4f2efed9155c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Appending maintenance reason image to vds status c...
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Appending maintenance reason image to vds status column ...................................................................... webadmin: Appending maintenance reason image to vds status column Host main tab- a comment image will be appended to the status column if 'maintenance reason' is set. Change-Id: Ic025eafe06c230c698a569f1ddc66fbd9e029935 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java 3 files changed, 45 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic025eafe06c230c698a569f1ddc66fbd9e029935 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: refactor PermissionsCommandBase.isSystemSuperUser me...
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: refactor PermissionsCommandBase.isSystemSuperUser method out ...................................................................... engine: refactor PermissionsCommandBase.isSystemSuperUser method out Refactor PermissionsCommandBase.isSystemSuperUser method out in order to be able to reuse that in different class hierarchies. Change-Id: I7b87b1709a3fc80fdcd090a0079189cef4a6ab62 Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsSystemSuperUserPredicate.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java 3 files changed, 58 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b87b1709a3fc80fdcd090a0079189cef4a6ab62 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0