March 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: make EngineSession queryable
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: make EngineSession queryable ...................................................................... engine: make EngineSession queryable Make EngineSession queryable through SearchQuery. Change-Id: I9bbdd6e1828b9be5500ec2f998c62511f102deda Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDAODbFacadeImpl.java 5 files changed, 33 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bbdd6e1828b9be5500ec2f998c62511f102deda Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: modify StatusCompositeCellWithElementId to support...
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: modify StatusCompositeCellWithElementId to support any cell ...................................................................... webadmin: modify StatusCompositeCellWithElementId to support any cell Due to generic restriction StatusCompositeCellWithElementId supported only cell with VM data type. Since there is no specific use for VM data type, the generic was modified to support any data type. Change-Id: Ia5c619dc1086c417ef25100fa538f9581a046ad1 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/StatusCompositeCellWithElementId.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5c619dc1086c417ef25100fa538f9581a046ad1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: displaying reason field on host maintenance confir...
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: displaying reason field on host maintenance confirmation dialog ...................................................................... webadmin: displaying reason field on host maintenance confirmation dialog The field is displayed just if it is required by the cluster policy and all the selected hosts belong to the same cluster. Change-Id: I0e5a638121df93333f4087b8d633658e3493013f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java 2 files changed, 37 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e5a638121df93333f4087b8d633658e3493013f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding 'enable host maintenance reason' to cluster...
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding 'enable host maintenance reason' to cluster popup ...................................................................... webadmin: adding 'enable host maintenance reason' to cluster popup It will indicate whether a popup for setting the reason should be displayed when moving the host to maintenance. Change-Id: I47e3ca6299f2f5df33b7eeaf5a2daaa9797a1894 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 6 files changed, 27 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38299 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47e3ca6299f2f5df33b7eeaf5a2daaa9797a1894 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fixed geo-rep auditlog issue
by masayag＠redhat.com 10 Mar '15

10 Mar '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fixed geo-rep auditlog issue ...................................................................... engine: Fixed geo-rep auditlog issue Fixed a startup error logged due to missing AuditLogType and AuditLogMessages Change-Id: I7f6a110fd4d06d83bd16fcae9bff51201ca8140c Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 5 files changed, 12 insertions(+), 6 deletions(-) Approvals: anmolbabu: Looks good to me, but someone else must approve Sahina Bose: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f6a110fd4d06d83bd16fcae9bff51201ca8140c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Updating the maintenance_reason on MaintenanceNumber...
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Updating the maintenance_reason on MaintenanceNumberOfVdssCommand ...................................................................... engine: Updating the maintenance_reason on MaintenanceNumberOfVdssCommand SetVdsStatusVdsCommand gets the maintenanceReason as a parameter and stores it in the db. If the reason is not set, a null will be stored. When the maintenance command is executed the reason (if there is one) is passed to SetVdsStatusVdsCommand. Since all the vds status changes are done via SetVdsStatusVdsCommand, when the status of the vds is changed to another status the maintenance reason will be nullified (since other places that executes SetVdsStatusVdsCommand doesn't pass maintenanceReason via the parameters). Change-Id: If1ab2e0b3e2cc154d14282bc38b158b0b4d195fe Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceNumberOfVdssParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 8 files changed, 39 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified Liran Zelkha: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ab2e0b3e2cc154d14282bc38b158b0b4d195fe Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add 'vds_maintenance_reason_required' column to vds_...
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add 'vds_maintenance_reason_required' column to vds_group ...................................................................... engine: add 'vds_maintenance_reason_required' column to vds_group This column will indicate whether the user will get a 'reason window' when moving the host to maintenance. The 'reason window' is a window with an option to set the reason for moving the host to maintenance. Change-Id: I9f3174acf5341a27e8c9d54a393bc93c75a54f7b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_06_0980_add_maintenance_reason_required_to_vds_groups.sql M packaging/dbscripts/vds_groups_sp.sql 5 files changed, 31 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f3174acf5341a27e8c9d54a393bc93c75a54f7b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: adding maintenanceReason to vdsDynamic
by alkaplan＠redhat.com 10 Mar '15

10 Mar '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: adding maintenanceReason to vdsDynamic ...................................................................... engine: adding maintenanceReason to vdsDynamic This patch includes- 1. Adding the field to the business entity. 2. Adding a column to the table. 3. Modifying table's update method to support the new propery/column (The insert method wasn't updated since this property is not relevant when creating a vds). Change-Id: Iac900c656e8309bf9f32fcc9fa9f5c32ed26298c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0970_add_maintenance_reason_to_vds_dynamic.sql M packaging/dbscripts/vds_sp.sql 8 files changed, 42 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac900c656e8309bf9f32fcc9fa9f5c32ed26298c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Remove add vm storage domain and disks options
by tnisan＠redhat.com 10 Mar '15

10 Mar '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Remove add vm storage domain and disks options ...................................................................... restapi: Remove add vm storage domain and disks options Change-Id: I9462f4c64b98d10f84789fe8360a83f1ba1065a5 Bug-Url: https://bugzilla.redhat.com/1082977 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 3 files changed, 4 insertions(+), 65 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9462f4c64b98d10f84789fe8360a83f1ba1065a5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Merge LogoutBySession and LogoutUser to LogoutSession
by oourfali＠redhat.com 10 Mar '15

10 Mar '15

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Merge LogoutBySession and LogoutUser to LogoutSession ...................................................................... aaa: Merge LogoutBySession and LogoutUser to LogoutSession Merges LogoutBySessionCommand and LogoutUserCommand to LogoutSessionCommand, because LogoutBySessionCommand only calls LogoutUserCommand internally, otherwise commands are the same. Change-Id: I3eefaa64d3881d0a59233f3f39c8dd0ed790d1f4 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutBySessionCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 8 insertions(+), 50 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eefaa64d3881d0a59233f3f39c8dd0ed790d1f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0