April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packacing: setup: move engine connection to common
by sradco＠redhat.com 05 Apr '15

05 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: packacing: setup: move engine connection to common ...................................................................... packacing: setup: move engine connection to common Move the code connecting to the engine db from setup to common. Without this, engine-cleanup on a separate dwh machine fails. This was broken by I64fff2d8fc9677e6138581add9c167501d9c783e. Change-Id: I378b64b28dac5d4b9f4f76895c6bb6b5972e5f8f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py 2 files changed, 25 insertions(+), 25 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/39545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I378b64b28dac5d4b9f4f76895c6bb6b5972e5f8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, engine, userportal, webadmin: Block floppy support on ...
by ofrenkel＠redhat.com 05 Apr '15

05 Apr '15

Omer Frenkel has submitted this change and it was merged. Change subject: core, engine, userportal, webadmin: Block floppy support on PPC64 ...................................................................... core, engine, userportal, webadmin: Block floppy support on PPC64 The ppc64 architecture does not support floppy devices, this change blocks the use of such devices in VMs that do not support them. A additional property in the osinfo (devices.floppy.support) was created to indicate if the guest OS supports floppy devices. The RunVmCommand was changed to validate if the selected VM can use the attached floppy image and the frontend was changed to hide floppy-related options if the VM does not support it. Change-Id: I8fb783bbafa3c6a18e327e4e02aac3d71b6f110b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067605 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/conf/osinfo-defaults.properties 16 files changed, 81 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved Objections: oVirt Jenkins CI Server: Fails -- To view, visit https://gerrit.ovirt.org/25043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb783bbafa3c6a18e327e4e02aac3d71b6f110b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: validation: fix pyflakes and pep8
by sradco＠redhat.com 05 Apr '15

05 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: validation: fix pyflakes and pep8 ...................................................................... validation: fix pyflakes and pep8 Fix issues detected by pyflakes and pep8 1.6.2 Change-Id: I8cbdc366269cbc251dd776d51c2fa8952142b1bc Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.py M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/core/service.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/config.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/pgpass.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/core/service.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/single_etl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/service.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/single_etl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/legacy/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/provisioning/postgres.py 22 files changed, 107 insertions(+), 45 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cbdc366269cbc251dd776d51c2fa8952142b1bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: validation: fix pyflakes and pep8
by sradco＠redhat.com 05 Apr '15

05 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: validation: fix pyflakes and pep8 ...................................................................... validation: fix pyflakes and pep8 Fix issues detected by pyflakes and pep8 1.6.2 Change-Id: I97cf0fbbf761655b4bf95c0e046ce53e4473ebd4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/ovirt_engine_setup/reports/reportsutil.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/protocols.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/service.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/config.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/pgpass.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/core/service.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/clear.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-reports/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/apache/reports.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/admin.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/java.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/protocols.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/core/service.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/provisioning/postgres.py 33 files changed, 252 insertions(+), 137 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97cf0fbbf761655b4bf95c0e046ce53e4473ebd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move AuditLogDaoMocker class to test folder
by masayag＠redhat.com 05 Apr '15

05 Apr '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Move AuditLogDaoMocker class to test folder ...................................................................... core: Move AuditLogDaoMocker class to test folder Move AuditLogDaoMocker class to test folder in order to prevent that being loaded by CDI. Change-Id: I063d71143b23333247ac76343393a331fe3c3632 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/AuditLogDaoMocker.java 1 file changed, 4 insertions(+), 19 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/39533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I063d71143b23333247ac76343393a331fe3c3632 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: webadmin: Revert cad6926bf551c86effcc539a8c45d2de0e4029f1
by tnisan＠redhat.com 05 Apr '15

05 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Revert cad6926bf551c86effcc539a8c45d2de0e4029f1 ...................................................................... webadmin: Revert cad6926bf551c86effcc539a8c45d2de0e4029f1 Pushed to wrong branch, need to revert. Change-Id: I1c6d55f41891b206364841ea4ce1a07238cf0d44 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206332 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java 3 files changed, 2 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c6d55f41891b206364841ea4ce1a07238cf0d44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5.2]: webadmin: revert 65452f9dedea24d0acaa38177a987727a79bb7aa
by tnisan＠redhat.com 05 Apr '15

05 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: revert 65452f9dedea24d0acaa38177a987727a79bb7aa ...................................................................... webadmin: revert 65452f9dedea24d0acaa38177a987727a79bb7aa Commited to wrong branch, reverting. Change-Id: If318ed06e271c36ecd856b1fb01a8414f9ee6cea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206908 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/EngineSessionTimeoutData.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 5 files changed, 16 insertions(+), 53 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If318ed06e271c36ecd856b1fb01a8414f9ee6cea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: gluster: add userspace-rcu from EPEL
by sbonazzo＠redhat.com 03 Apr '15

03 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: gluster: add userspace-rcu from EPEL ...................................................................... gluster: add userspace-rcu from EPEL Change-Id: Ice3d9f832ee6bf1165f7f130cc6a11a2cb4d57d5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master/configure.ac M ovirt-release-master/ovirt-el7-deps.repo.in M ovirt-release-master/ovirt-release-master.spec.in 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice3d9f832ee6bf1165f7f130cc6a11a2cb4d57d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: build: Makefile maintenance
by sbonazzo＠redhat.com 03 Apr '15

03 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Makefile maintenance ...................................................................... build: Makefile maintenance - updated el7 Makefile adding new livecd-tools - synced el6 Makefile with the el7 one Change-Id: Ia107b88d5a5067eac3fab6d97adc5a8bc4743cd2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-6/Makefile M centos-7/Makefile 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia107b88d5a5067eac3fab6d97adc5a8bc4743cd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: mock: expire metadata in 30 minutes
by dcaroest＠redhat.com 02 Apr '15

02 Apr '15

David Caro has submitted this change and it was merged. Change subject: mock: expire metadata in 30 minutes ...................................................................... mock: expire metadata in 30 minutes Expire metadata in 30 minutes, avoiding to have slaves failing on repository refresh. Change-Id: I81a3ebf4e644b7f57d228ff335be41e60d5fc4fb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M mock_configs/mock_genconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a3ebf4e644b7f57d228ff335be41e60d5fc4fb Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0