April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin : Fix Gluster-only cluster dialog
by kmayilsa＠redhat.com 20 Apr '15

20 Apr '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fix Gluster-only cluster dialog ...................................................................... webadmin : Fix Gluster-only cluster dialog In GlusterOnly-Mode, in cluster dialog, the following make are not applicable 1. Enable to set vm maintenance reason 2. /dev/random/ source 3. /dev/hwrng/source Hence this patch sets them invisible in GlusterOnly-Mode Change-Id: Iac8f2e65b16f4dbf00f76da814a87d4131ebab6b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1184384 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved Objections: oVirt Jenkins CI Server: Fails -- To view, visit https://gerrit.ovirt.org/39743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac8f2e65b16f4dbf00f76da814a87d4131ebab6b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster : add gluster prefix to gluster storage device configs
by sabose＠redhat.com 20 Apr '15

20 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster : add gluster prefix to gluster storage device configs ...................................................................... gluster : add gluster prefix to gluster storage device configs Add gluster prefix to all config variables for storage device. Change-Id: I96e261ad48f404add0b700c35139df8020cb7349 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 6 files changed, 15 insertions(+), 11 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96e261ad48f404add0b700c35139df8020cb7349 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: add is_gluster_brick flag to storage device
by sabose＠redhat.com 20 Apr '15

20 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: add is_gluster_brick flag to storage device ...................................................................... gluster: add is_gluster_brick flag to storage device Add is_gluster_brick column to storage device table. This flag helps to identify a mounted device as a gluster brick. This flag will be set to true for the bricks created from ovirt. Change-Id: I375a7340eb76db9cf2bbf142923929bf9ede748a Bug-Url: https://bugzilla.redhat.com/1208089 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedGlusterBricksQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDaoDbFacadeImpl.java M packaging/dbscripts/storage_device_sp.sql A packaging/dbscripts/upgrade/03_06_1250_add_is_brick_flag-to_storage_device_table.sql 6 files changed, 29 insertions(+), 11 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I375a7340eb76db9cf2bbf142923929bf9ede748a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Display unit for stripe size in create brick dialog.
by kmayilsa＠redhat.com 20 Apr '15

20 Apr '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Display unit for stripe size in create brick dialog. ...................................................................... webadmin: Display unit for stripe size in create brick dialog. Add the unit (KB) to the strip size label in create brick dialog. Change-Id: If735d639e574bd81fba984484c4624fd8c8cfd3b Bug-Url: https://bugzilla.redhat.com/1209426 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If735d639e574bd81fba984484c4624fd8c8cfd3b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add directory to brick mount point
by kmayilsa＠redhat.com 20 Apr '15

20 Apr '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add directory to brick mount point ...................................................................... webadmin: add directory to brick mount point Add a directory with name of the brick under brick mount point in Add Brick Pop up. This required becase gluster requires a directory under the mount point not the mount point itself as a brick directory. Change-Id: I44d0fe15988b8193f0866441097b178a98e88b93 Bug-Url: https://bugzilla.redhat.com/1209443 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44d0fe15988b8193f0866441097b178a98e88b93 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix action availability for create brick
by kmayilsa＠redhat.com 20 Apr '15

20 Apr '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix action availability for create brick ...................................................................... webadmin: fix action availability for create brick Enable/Disable create brick action based on the selection of storage devices. CreateBrick will be enabled only when there is a free device(Device with canCreateBrick flag true) selected and there is no used device (Device with canCreateBrick false) selected. Only selected devices will be shown in the create brick dialog instead of all available devices. Change-Id: Iecaff8f5863bd3107ba109e6f1f9d695d8ee67aa Bug-Url: https://bugzilla.redhat.com/1208125 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/HostGlusterStorageDevicesListModel.java 1 file changed, 39 insertions(+), 27 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecaff8f5863bd3107ba109e6f1f9d695d8ee67aa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add host name to job properties in all server conn...
by tnisan＠redhat.com 19 Apr '15

19 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add host name to job properties in all server connections commands ...................................................................... webadmin: Add host name to job properties in all server connections commands Change-Id: I8cc2c4dc73a1a071357f01c7d31fa40f2535433b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1139160 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java 2 files changed, 12 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cc2c4dc73a1a071357f01c7d31fa40f2535433b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add equals to CinderDisk and CinderConnectionInfo
by derez＠redhat.com 19 Apr '15

19 Apr '15

Daniel Erez has submitted this change and it was merged. Change subject: core: add equals to CinderDisk and CinderConnectionInfo ...................................................................... core: add equals to CinderDisk and CinderConnectionInfo Adding an equals method for CinderDisk and CinderConnectionInfo. Change-Id: If38042f849e7ca791cb359f6eb9c974edddb0c71 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderConnectionInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderDisk.java 2 files changed, 37 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If38042f849e7ca791cb359f6eb9c974edddb0c71 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: display Disks sub-tab on Storage tab for Cinder sds
by derez＠redhat.com 19 Apr '15

19 Apr '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: display Disks sub-tab on Storage tab for Cinder sds ...................................................................... webadmin: display Disks sub-tab on Storage tab for Cinder sds Disply Disks sub-tab on Storage main-tab for Cinder storage domains. Change-Id: I1c0fe2ab59a999c3042da8ac87986c559399100d Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageDomainsColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java 3 files changed, 60 insertions(+), 21 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c0fe2ab59a999c3042da8ac87986c559399100d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: filter errors on js-import/export
by sradco＠redhat.com 19 Apr '15

19 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: filter errors on js-import/export ...................................................................... packaging: setup: filter errors on js-import/export Change-Id: I6e1cd0ff49c2e37649263302dce0a1a44ee4bb53 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/reportsutil.py 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/39974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1cd0ff49c2e37649263302dce0a1a44ee4bb53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0