April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: fix Coverity issue in QuotaProgressBar
by gshereme＠redhat.com 01 Apr '15

01 Apr '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal: fix Coverity issue in QuotaProgressBar ...................................................................... userportal: fix Coverity issue in QuotaProgressBar fix Coverity issue in QuotaProgressBar * 1289475 Explicit null dereferenced A null pointer exception will occur. In org.ovirt.engine.ui.userportal.widget.QuotaProgressBar.QuotaProgressBar Change-Id: I05cbb9efd0f4df4e86e73401d7dcdb5d6250cbd3 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/39308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05cbb9efd0f4df4e86e73401d7dcdb5d6250cbd3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: renamed the blank template to default
by tjelinek＠redhat.com 01 Apr '15

01 Apr '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: renamed the blank template to default ...................................................................... core: renamed the blank template to default Renamed the "Blank" to "Default" template and adjusted the description to be "Default template". Changed the user-facing strings (not the variables inside the code) without without breaking the REST compatibility. Feature Page: www.ovirt.org/Features/Blank_to_Defaults Bug-Url: https://bugzilla.redhat.com/1130174 Change-Id: Ia8c91734ccd38f442c5fb8f41ff5f20c608d04e6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_1160_rename_blank_to_default.sql 6 files changed, 20 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8c91734ccd38f442c5fb8f41ff5f20c608d04e6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: changed csh to use per-locale mapping
by gshereme＠redhat.com 01 Apr '15

01 Apr '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: changed csh to use per-locale mapping ...................................................................... userportal, webadmin: changed csh to use per-locale mapping Changed context-sensitive help infrastructure to use per-locale mapping files. Previously there was one mapping shared by all locales, but that no longer fits the documentation release process. Also changed the csh infra to no longer cache the json mapping files on the server. The json will be re-loaded once per login. Change-Id: I1f854a9d7034d436730a4e82c88963a854e2c2b6 Bug-Url: https://bugzilla.redhat.com/1204434 Bug-Url: https://bugzilla.redhat.com/1083195 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ContextSensitiveHelpManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 7 files changed, 333 insertions(+), 160 deletions(-) Approvals: Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f854a9d7034d436730a4e82c88963a854e2c2b6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: rename csh classes
by gshereme＠redhat.com 01 Apr '15

01 Apr '15

Greg Sheremeta has submitted this change and it was merged. Change subject: userportal, webadmin: rename csh classes ...................................................................... userportal, webadmin: rename csh classes rename HelpTagJsonServlet -> ContextSensitiveHelpMappingServlet rename DocumentationPathTranslator -> ContextSensitiveHelpManager Change-Id: I6d946bc9f7199d1d796b7bcd0a46b4d6d7109bfa Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- R backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ContextSensitiveHelpManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 6 files changed, 13 insertions(+), 13 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified Objections: oVirt Jenkins CI Server: Fails -- To view, visit https://gerrit.ovirt.org/39300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d946bc9f7199d1d796b7bcd0a46b4d6d7109bfa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Phase 4: Query for generating console descriptor
by tjelinek＠redhat.com 01 Apr '15

01 Apr '15

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Phase 4: Query for generating console descriptor ...................................................................... engine: Phase 4: Query for generating console descriptor Move generating console descriptor file (aka '.vv' file) from frontend clients to backend generator. Added query for calling this generator from UI and REST API. Change-Id: I4a0f882f8936fe49d7231eb42d67fe374e28ccb5 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1128763 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConsoleDescriptorFileQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetConsoleDescriptorFileQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleDescriptorGenerator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java 6 files changed, 235 insertions(+), 112 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/37975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a0f882f8936fe49d7231eb42d67fe374e28ccb5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Phase 3: Configuring ConsoleOptions on backend
by tjelinek＠redhat.com 01 Apr '15

01 Apr '15

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Phase 3: Configuring ConsoleOptions on backend ...................................................................... engine: Phase 3: Configuring ConsoleOptions on backend Move filling ConsoleOptions from *ConsoleModel(s) to backend. Small cleanups in SpiceConsoleModel spaghetti code (generating menu). todo describe cleanups (configurator, consolemodels etc) Got rid of explicit setting VM ticket. It is done in ConfigureConsoleOptionsQuery instead. Change-Id: Ida16e4de2701d6f6b3f6b3ed52eddca805fa43a7 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1128763 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigureConsoleOptionsParams.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConsoleOptionsParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleClient.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 14 files changed, 549 insertions(+), 387 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/37974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida16e4de2701d6f6b3f6b3ed52eddca805fa43a7 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Replace CacheWrapper with plain Map
by masayag＠redhat.com 01 Apr '15

01 Apr '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Replace CacheWrapper with plain Map ...................................................................... engine: Replace CacheWrapper with plain Map The CacheWrapper provides only a sub-set of the Map interface. Change-Id: I5fc00faa1e71a43b544cadd8f825c06799ec1154 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/MapWrapperImpl.java 5 files changed, 9 insertions(+), 70 deletions(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fc00faa1e71a43b544cadd8f825c06799ec1154 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: sos: hosts: collect hosted-engine data
by sbonazzo＠redhat.com 01 Apr '15

01 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: hosts: collect hosted-engine data ...................................................................... sos: hosts: collect hosted-engine data If sos >= 3.2 is found on the host enable also the ovirt-hosted-engine plugin which is available since sos-3.2_alpha. sos 3.2 is available on Fedora and EL 7.1 and will be available in EL 6.7. Change-Id: I8e456262f2242d6aa73449e57c81246eaf824ab3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127777 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e456262f2242d6aa73449e57c81246eaf824ab3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Requesting to consume quota while extending a disk fix.
by tnisan＠redhat.com 01 Apr '15

01 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Requesting to consume quota while extending a disk fix. ...................................................................... core: Requesting to consume quota while extending a disk fix. Until now when the user wanted to extend a disk, there was no request generated for quota consumption. This fact let the user to extend the disk's size as much as he likes when there are quota limitations. This patch adds a request for quota consumption when disks are extended. Change-Id: Ib31206b0a9172b35217845b01253951d93f380f1 Bug-Url: https://bugzilla.redhat.com/1203262 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 42 insertions(+), 8 deletions(-) Approvals: Amit Aviram: Verified Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved Objections: oVirt Jenkins CI Server: Fails -- To view, visit https://gerrit.ovirt.org/39330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31206b0a9172b35217845b01253951d93f380f1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: fix for python 2.6
by sbonazzo＠redhat.com 01 Apr '15

01 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix for python 2.6 ...................................................................... packaging: setup: fix for python 2.6 Fix Iec4f409203e3a2d6da314208e9a0f422be00ce1b to use python 2.6 compatible code. Change-Id: I92020abef40faec020de2852668bdb5abfe93b78 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92020abef40faec020de2852668bdb5abfe93b78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0