April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: "None" QoS where appropriate
by lvernia＠redhat.com 30 Apr '15

30 Apr '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: "None" QoS where appropriate ...................................................................... webadmin: "None" QoS where appropriate For the link share and real time fields of Host Network QoS, "Unlimited" is not the appropriate term as they do not specify a limit. Change-Id: Ib51f10d37240d06eb3ba11a2f99e2490ad74c717 Bug-Url: https://bugzilla.redhat.com/1182130 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib51f10d37240d06eb3ba11a2f99e2490ad74c717 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Rename Network QoS to VM Network QoS
by lvernia＠redhat.com 30 Apr '15

30 Apr '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Rename Network QoS to VM Network QoS ...................................................................... webadmin: Rename Network QoS to VM Network QoS To reduce confusion with the newly-added Host Network QoS. Also changed the tab width to be determined by the text (with proper margins). Change-Id: I9f2413ed7e75a27bb8c5bffdcb0aa05bfa563a59 Bug-Url: https://bugzilla.redhat.com/1180892 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/HyperlinkTab.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f2413ed7e75a27bb8c5bffdcb0aa05bfa563a59 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: proper error on trying to import non existing vm
by ahadas＠redhat.com 30 Apr '15

30 Apr '15

Arik Hadas has submitted this change and it was merged. Change subject: core: proper error on trying to import non existing vm ...................................................................... core: proper error on trying to import non existing vm If one tried to import a VM that does not exist in the export domain, he didn't get a proper error message. This patch fixes it by raising a proper error in that case. Change-Id: I02bbca136b9c3244fbe7471ac07b6409196aedc0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 83 insertions(+), 68 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/40313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02bbca136b9c3244fbe7471ac07b6409196aedc0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Icons for ppc operating systems added
by ofrenkel＠redhat.com 30 Apr '15

30 Apr '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Icons for ppc operating systems added ...................................................................... core: Icons for ppc operating systems added * Large icons are based on corresponding icons of x86 systems and contain additional 'PPC64' string. * Small icons are just copied from x86 counterparts. Change-Id: If8bb7c3600ba8e2ec798327682a34342ff69b9e5 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A packaging/icons/large/other_linux_ppc64.png A packaging/icons/large/other_ppc64.png A packaging/icons/large/rhel_6_ppc64.png A packaging/icons/large/rhel_7_ppc64.png A packaging/icons/large/sles_11_ppc64.png A packaging/icons/large/ubuntu_14_04_ppc64.png A packaging/icons/small/other_linux_ppc64.jpg A packaging/icons/small/other_ppc64.jpg A packaging/icons/small/rhel_6_ppc64.jpg A packaging/icons/small/rhel_7_ppc64.jpg A packaging/icons/small/sles_11_ppc64.png A packaging/icons/small/ubuntu_14_04_ppc64.jpg 12 files changed, 0 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8bb7c3600ba8e2ec798327682a34342ff69b9e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Don't accept non-digit characters
by lvernia＠redhat.com 30 Apr '15

30 Apr '15

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Don't accept non-digit characters ...................................................................... webadmin: Don't accept non-digit characters Using IntegerEntityModelTextBoxEditor turned out to be the wrong choice, as it "swallows" non-integer input and simply translates it to a null Integer. For the validation to work properly, changed HostNetworkQosWidget to use StringEntityModelTextBoxEditor instead. Change-Id: I4ed3e4dd9aa1d464cab85e776396a5783ac91fcb Bug-Url: https://bugzilla.redhat.com/1181431 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml 4 files changed, 44 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed3e4dd9aa1d464cab85e776396a5783ac91fcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, webadmin: Added to network search by provider name
by lvernia＠redhat.com 30 Apr '15

30 Apr '15

Lior Vernia has submitted this change and it was merged. Change subject: core,webadmin: Added to network search by provider name ...................................................................... core,webadmin: Added to network search by provider name It was missing. Change-Id: If2393b83973012ff598eb3c662ff2051627b32f9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2393b83973012ff598eb3c662ff2051627b32f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Check return value from getUnregisteredDisks
by mlipchuk＠redhat.com 30 Apr '15

30 Apr '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Check return value from getUnregisteredDisks ...................................................................... core: Check return value from getUnregisteredDisks if GetUnregisteredDisks fails to get the imagesList from VDSM, the query returns null. In this patch I've added a check so in case we will get a null value for the unregistered disks we should print an error and return an empty list of unregistered disks Change-Id: I9a2c2b75d7d8cea782e1b91cf5d34666642d1800 Bug-Url: https://bugzilla.redhat.com/1214408 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a2c2b75d7d8cea782e1b91cf5d34666642d1800 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Check if storage domain exists in OVF_STORE
by mlipchuk＠redhat.com 30 Apr '15

30 Apr '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Check if storage domain exists in OVF_STORE ...................................................................... core: Check if storage domain exists in OVF_STORE To prevent NPE when checking Storage Domain for OVF_STORE, I've added a check if the storage domain exists in the description of the OVF_STORE disk. Change-Id: I14e270db122619e2eeb55cb580f4a3e4a310e5be Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e270db122619e2eeb55cb580f4a3e4a310e5be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Check attached VMs snapshot status when moving a disk
by tnisan＠redhat.com 30 Apr '15

30 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Check attached VMs snapshot status when moving a disk ...................................................................... core: Check attached VMs snapshot status when moving a disk Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Bug-Url: https://bugzilla.redhat.com/1211330 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 58 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80feffc9f11aed1bc8fa7a6f80562d05ce815c56 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix typo
by tnisan＠redhat.com 30 Apr '15

30 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix typo ...................................................................... webadmin: fix typo /s/Snapsnot/Snapshot/ Change-Id: I807689717289d393c85e64882625a53a49ebfc3b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1215882 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I807689717289d393c85e64882625a53a49ebfc3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0