April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: pki: pki-create-ca.sh: add renew
by tnisan＠redhat.com 15 Apr '15

15 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: pki: pki-create-ca.sh: add renew ...................................................................... pki: pki-create-ca.sh: add renew Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210486 Change-Id: I2a277fab7aedcdb23aa1c09cde84fc90b8a61536 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-create-ca.sh 1 file changed, 33 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a277fab7aedcdb23aa1c09cde84fc90b8a61536 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: pki: comply with rfc2459 UTCTime restriction
by tnisan＠redhat.com 15 Apr '15

15 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: pki: comply with rfc2459 UTCTime restriction ...................................................................... pki: comply with rfc2459 UTCTime restriction Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210486 Change-Id: Ie7440b5918090fce595a237a4be861b2a7400b74 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/pki-create-ca.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7440b5918090fce595a237a4be861b2a7400b74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: pki: upgrade cert templates
by tnisan＠redhat.com 15 Apr '15

15 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: pki: upgrade cert templates ...................................................................... packaging: setup: pki: upgrade cert templates the certificate template may be modified over time, and has recently. due to legacy pki approach and until we rewrite the pki, we must regenerate configuration taking the AIA from existing template. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1210486 Change-Id: Ia975aad12e97ce0287cd6414e7ab91ea2ca6c0f9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 79 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39815 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia975aad12e97ce0287cd6414e7ab91ea2ca6c0f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: pki: cleanup ca module
by tnisan＠redhat.com 15 Apr '15

15 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: pki: cleanup ca module ...................................................................... packaging: setup: pki: cleanup ca module Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1210486 Change-Id: I032621fb44cd08a6e02d7a806a876c8cc3ab4f0f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 2 files changed, 36 insertions(+), 54 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I032621fb44cd08a6e02d7a806a876c8cc3ab4f0f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Remove empty bodies from RSDL metadata file
by juan.hernandez＠redhat.com 15 Apr '15

15 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove empty bodies from RSDL metadata file ...................................................................... restapi: Remove empty bodies from RSDL metadata file Currently the RSDL metadata file contains the definition of request bodies even if they are completely empty. For example: body: parameterType: null signatures: [] This is currently needed because otherwise the list of signatures would be "null" instead of an empty list, and that would induce some changes in the generated RSDL. To avoid all these empty specifications (that make the already giantic RSDL metadata file even larger) this patch changes the RSDL builder so that it assigns default values to the metadata after loading it (replacing "null" with empty lists, for exampe) and also removes the empty specifications from the RSDL metadata file. The generated RSDL document doesn't change. Change-Id: I1a95ca58b83750886429bce29a0e8e9188c76d48 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 2 files changed, 61 insertions(+), 1,143 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a95ca58b83750886429bce29a0e8e9188c76d48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Move ValidateSessionQueryTest to aaa package
by masayag＠redhat.com 15 Apr '15

15 Apr '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move ValidateSessionQueryTest to aaa package ...................................................................... engine: Move ValidateSessionQueryTest to aaa package Change-Id: Iaf33fd42d24999f29e160c1cc1d61a8c66d9e07c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/aaa/ValidateSessionQueryTest.java 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/39863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf33fd42d24999f29e160c1cc1d61a8c66d9e07c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Refactor FenceProxyLocator
by oourfali＠redhat.com 15 Apr '15

15 Apr '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Refactor FenceProxyLocator ...................................................................... core: Refactor FenceProxyLocator 1. Makes FenceProxyLocator more readable 2. Fixes bug when testing agents compatibility between proxy candidate and fenced host 3. Makes FenceProxyLocatorTest more readable 4. Adds more tests to FenceProxyLocatorTest Change-Id: I59d5b46273dbaeb2d73142f1256000e36a6cbdd8 Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java 2 files changed, 376 insertions(+), 254 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59d5b46273dbaeb2d73142f1256000e36a6cbdd8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: FenceProxyLocator* code clean up
by oourfali＠redhat.com 15 Apr '15

15 Apr '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: FenceProxyLocator* code clean up ...................................................................... core: FenceProxyLocator* code clean up 1. Moves FenceProxyLocator and FenceProxyLocatorTest to bll.pm package 2. Makes both classes more compatible with Java Coding Convetions 3. Reformats code Change-Id: I9424a1afefde58b6e687eb4a0325a59ce9573950 Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceProxyLocator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/FenceValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutorTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/FenceValidatorTest.java 7 files changed, 35 insertions(+), 38 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9424a1afefde58b6e687eb4a0325a59ce9573950 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Refactor fence proxy source handling in FenceProxyLocator
by oourfali＠redhat.com 15 Apr '15

15 Apr '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Refactor fence proxy source handling in FenceProxyLocator ...................................................................... core: Refactor fence proxy source handling in FenceProxyLocator Refactors FenceProxyLocator to use VDS.*FenceProxySources() methods instead of its own internal objects. Change-Id: I2f0fbf86f9903cc15ceae2bd64fa936d300a4b8d Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceProxyLocator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 2 files changed, 29 insertions(+), 55 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f0fbf86f9903cc15ceae2bd64fa936d300a4b8d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Replace usage of *PmProxyPreferences() with *Fence...
by oourfali＠redhat.com 15 Apr '15

15 Apr '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Replace usage of *PmProxyPreferences() with *FenceProxySources() ...................................................................... webadmin: Replace usage of *PmProxyPreferences() with *FenceProxySources() Replaces usage of get/setPmProxyPreferences() with get/setFenceProxySources(). Conversion from comma separated string will be removed as a part of power management tab refactoring. Change-Id: Ia31972d3ac3d1364be92517059cacbed8768bdfb Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFenceAgentStatusQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetFenceAgentStatusParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 5 files changed, 16 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39761 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia31972d3ac3d1364be92517059cacbed8768bdfb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0