Change in ovirt-engine[master]: restapi: Refactor conversion between PmProxies and VDS/VdsSt...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: restapi: Refactor conversion between PmProxies and VDS/VdsStatic
......................................................................
restapi: Refactor conversion between PmProxies and VDS/VdsStatic
Refactors the code to use List<FenceProxySourceType> instead of comma
separated string when converting between PowerManagement and
VDS/VdsStatic entities.
Change-Id: I5e5d0f30cec48e5173680c30988e2bc4969bc365
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
3 files changed, 15 insertions(+), 26 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39760
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e5d0f30cec48e5173680c30988e2bc4969bc365
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Refactor VdsStatic to use FenceProxySourceType
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Refactor VdsStatic to use FenceProxySourceType
......................................................................
core: Refactor VdsStatic to use FenceProxySourceType
1. Makes conversions between comma separated string and
List<FenceProxySourceType> part of DAOs
2. Refactors *PmProxyPreferences() methods to use new
*FenceProxySources() methods in VDS/VdsStatic
3. Fixes HostMapperTest.testRoundtrip() to not fill in invalid fence
proxy sources into Host entity as a part of the test.
Change-Id: I584ea587842cb8c4e31fa387d235d42cabea5648
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
5 files changed, 45 insertions(+), 15 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39759
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I584ea587842cb8c4e31fa387d235d42cabea5648
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core/restapi/webadmin: Support clearing the cluster's emulat...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core/restapi/webadmin: Support clearing the cluster's emulated machine
......................................................................
core/restapi/webadmin: Support clearing the cluster's emulated machine
Added option to clear the cluster's emulated machine when all of its
hosts are down. Support was added to UI & REST.
Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266
Bug-Url: https://bugzilla.redhat.com/1058751
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsGroupOperationParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ClusterResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
16 files changed, 165 insertions(+), 2 deletions(-)
Approvals:
Eldan Shachar: Verified
Martin Betak: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/37115
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Introduce FenceProxySourceType
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Introduce FenceProxySourceType
......................................................................
core: Introduce FenceProxySourceType
1. Introduces FenceProxySourceType enum which holds all available types
of fence proxy sources
2. Introduces FenceProxySourceTypeHelper to provide conversion of fence
proxy source from/to string
Change-Id: I7ee90c85c80f80208025a7ccbb2170f4c3611e1a
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceProxySourceType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/pm/FenceProxySourceTypeHelper.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/pm/FenceProxySourceTypeHelperTest.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
4 files changed, 267 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39758
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ee90c85c80f80208025a7ccbb2170f4c3611e1a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: Enable HE plugin on Fedora only
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: spec: Enable HE plugin on Fedora only
......................................................................
spec: Enable HE plugin on Fedora only
At moment, HE plugin will be enable only on Fedora node.
Change-Id: I75563ca7b1a58dcf3048200fac7386befb5a5ac9
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39852
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75563ca7b1a58dcf3048200fac7386befb5a5ac9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: use %license macro
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: spec: use %license macro
......................................................................
spec: use %license macro
Change-Id: Ida02bda6e597a8545ac1a687d8d9565c824f930c
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39851
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida02bda6e597a8545ac1a687d8d9565c824f930c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: requires HE plugin for el7 platform only
by dougsland＠redhat.com
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: spec: requires HE plugin for el7 platform only
......................................................................
spec: requires HE plugin for el7 platform only
Change-Id: I30daff3ad096fe3feb45314954a639f53c7b6d82
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-node-plugin-vdsm.spec.in
M recipe/vdsm-plugin-iso.ks
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39850
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30daff3ad096fe3feb45314954a639f53c7b6d82
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: dal: Add HostDev passthrough support #2
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: dal: Add HostDev passthrough support #2
......................................................................
dal: Add HostDev passthrough support #2
Added HostDevice and related VmDevice stored procedures and corresponding
DbFacadeImpl methods.
Change-Id: I000c54776b4c3f8dc78608481b5700a895c3d478
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDeviceView.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/host_device_sp.sql
A packaging/dbscripts/upgrade/03_06_1210_add_vm_host_device_commands.sql
M packaging/dbscripts/vm_device_sp.sql
13 files changed, 492 insertions(+), 16 deletions(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I000c54776b4c3f8dc78608481b5700a895c3d478
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: initializing domain sizes with null
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: initializing domain sizes with null
......................................................................
core: initializing domain sizes with null
Up till now, available size and used size properties in
StorageDomainDynamic were set to 0 instead of null on StorageDomain creation.
Change-Id: I182a4c25ed0bf896adaadb86e8b36cfaf17d93e6
Bug-Url: https://bugzilla.redhat.com/1211057
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/39827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I182a4c25ed0bf896adaadb86e8b36cfaf17d93e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Report storage size closer to reality
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Report storage size closer to reality
......................................................................
core: Report storage size closer to reality
When storage size in GB is less than 1, "[N/A]" was displayed.
Now displaying "<1", which is more accurate.
Glance size initialization is amended to correspond to the new display
(Should still show "[N/A]", but without amending would show "<1").
Change-Id: I758febd3b6b1a1f13ae4e48635bf185ea81d918b
Bug-Url: https://bugzilla.redhat.com/1211057
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
M packaging/dbscripts/inst_sp.sql
A packaging/dbscripts/upgrade/03_05_1260_set_third_party_storage_size_to_NA.sql
6 files changed, 15 insertions(+), 23 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/39826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I758febd3b6b1a1f13ae4e48635bf185ea81d918b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months