Change in ovirt-engine[ovirt-engine-3.5]: core: Remove constant SIZE_IS_NOT_AVAILABLE
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE
......................................................................
core: Remove constant SIZE_IS_NOT_AVAILABLE
Using null has the same effect, this constant only complicates things.
Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f
Bug-Url: https://bugzilla.redhat.com/1211057
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
A packaging/dbscripts/upgrade/03_05_1250_update_repo_file_metadata_size.sql
9 files changed, 23 insertions(+), 22 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/39825
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.2_rc4
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-live-3.5.2_rc4
......................................................................
build: ovirt-live-3.5.2_rc4
Change-Id: If5bff1c3300ba9361d162d12dddddcc9f8fb6657
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39832
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5bff1c3300ba9361d162d12dddddcc9f8fb6657
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.5
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-release[master]: build: ovirt-release35-003-1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-release35-003-1
......................................................................
build: ovirt-release35-003-1
Change-Id: I7829789cc008fac171727f2b2c27bdc457c4983d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-release-3.5/configure.ac
M ovirt-release-3.5/ovirt-release35.spec.in
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39831
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7829789cc008fac171727f2b2c27bdc457c4983d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-release[master]: 3.5: add fedora-virt-preview to fedora 20
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: 3.5: add fedora-virt-preview to fedora 20
......................................................................
3.5: add fedora-virt-preview to fedora 20
Adding fedora-virt-preview libvirt to fedora 20
in order to satisfy vdsm dependencies.
Change-Id: I457c6352fd1a700d3d865f45d20ce8bfcc7c6e8b
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-release-3.5/ovirt-f20-deps.repo.in
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I457c6352fd1a700d3d865f45d20ce8bfcc7c6e8b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-reports[master]: packaging: setup: add params to js.quartz.properties
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: setup: add params to js.quartz.properties
......................................................................
packaging: setup: add params to js.quartz.properties
Edit js.quartz.properties on upgrade to have these,
if not already set there:
report.quartz.misfirepolicy.singlesimplejob=SMART_POLICY
report.quartz.misfirepolicy.repeatingsimplejob=SMART_POLICY
report.quartz.misfirepolicy.calendarjob=SMART_POLICY
Change-Id: I2f9a42e4f7303f3a3cebe65e1e7166a5645278c7
Bug-Url: https://bugzilla.redhat.com/1209540
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
1 file changed, 29 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f9a42e4f7303f3a3cebe65e1e7166a5645278c7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: NPE on edit instance type
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: NPE on edit instance type
......................................................................
core: NPE on edit instance type
No way to edit the instance type - a NPE was thrown in the
UpdateVmTemplateCommand since instance type does not have a cluster.
Change-Id: I83f9d02b3eb6e0562a6854c106f36bebc5bb4ffe
Bug-Url: https://bugzilla.redhat.com/1209879
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83f9d02b3eb6e0562a6854c106f36bebc5bb4ffe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: incorrect instance type name validation
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: incorrect instance type name validation
......................................................................
webadmin: incorrect instance type name validation
Instance type missed the I18N name validation.
Change-Id: Icf3f55f50775e5cf09868ec896c9d7916a214985
Bug-Url: https://bugzilla.redhat.com/1209882
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39811
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf3f55f50775e5cf09868ec896c9d7916a214985
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Adjust setter to property name
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Adjust setter to property name
......................................................................
core: Adjust setter to property name
In order to avoid bean introspection warnings of
missing property, the setter VDS.setVdsName()
should be aligned with the property name VDS.name.
Else, it is considered to set a property which doesn't
exist.
Change-Id: Ifb1bb9bb9eee0937b907c1bd5e6b272746a7293f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
5 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/39824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1bb9bb9eee0937b907c1bd5e6b272746a7293f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-reports[master]: reports: add created by to br44
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: add created by to br44
......................................................................
reports: add created by to br44
Change-Id: I282d92a4b8f62d84025996fcda8c6dedc66d4717
Bug-Url:https://bugzilla.redhat.com/1052388
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Inventory/ccp_vm_inventory_br44_files/ccp_vm_inventory_br44_jrxml.data
M packaging/ovirt-reports/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data
2 files changed, 23 insertions(+), 31 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39793
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I282d92a4b8f62d84025996fcda8c6dedc66d4717
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: engine: fix Coverity CID 1292836
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: fix Coverity CID 1292836
......................................................................
engine: fix Coverity CID 1292836
Make org.ovirt.engine.core.CdiIntegration$InstanceImpl class static.
Fix for Coverity CID 1292836.
Change-Id: I1a7214df057cfbbfd0cf492cb59e4596e4e0049c
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/CdiIntegration.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a7214df057cfbbfd0cf492cb59e4596e4e0049c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months