Change in ovirt-engine[master]: packaging: setup: enhance editConfigContent
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: enhance editConfigContent
......................................................................
packaging: setup: enhance editConfigContent
Add an option to editConfigContent to keep existing params if found.
With this option, only params that do not appear in the input will be
added in the end.
Add an option for regular expression pattern for params.
Change-Id: Ib41cf1773e015f34c66fc7aaef0a079a7ccc8845
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/util.py
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/39774
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41cf1773e015f34c66fc7aaef0a079a7ccc8845
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Add Collection and Map support to ToStringBuilder
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Add Collection and Map support to ToStringBuilder
......................................................................
core: Add Collection and Map support to ToStringBuilder
Adds append(String, Collection) and append(String, Map) to allow adding
collections and maps attributes to toString() output.
Change-Id: Ie6ae7bced08092e4f1e635be394edc940d7083b4
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ToStringBuilder.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ToStringBuilderTest.java
2 files changed, 61 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39720
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6ae7bced08092e4f1e635be394edc940d7083b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: common: Fix "raw type" warnings in ToStringBuilder
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: common: Fix "raw type" warnings in ToStringBuilder
......................................................................
common: Fix "raw type" warnings in ToStringBuilder
Fixes "raw type" warnings in ToStringBuilder.
Change-Id: I3218520e01b5421d02d0d509c946fb4cc98f5f87
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ToStringBuilder.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39787
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3218520e01b5421d02d0d509c946fb4cc98f5f87
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: initializing domain sizes with null
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: initializing domain sizes with null
......................................................................
core: initializing domain sizes with null
Up till now, available size and used size properties in
StorageDomainDynamic were set to 0 instead of null on StorageDomain creation.
Change-Id: I182a4c25ed0bf896adaadb86e8b36cfaf17d93e6
Bug-Url: https://bugzilla.redhat.com/1202363
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
3 files changed, 1 insertion(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/39028
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I182a4c25ed0bf896adaadb86e8b36cfaf17d93e6
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Report storage size closer to reality
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Report storage size closer to reality
......................................................................
core: Report storage size closer to reality
When storage size in GB is less than 1, "[N/A]" was displayed.
Now displaying "<1", which is more accurate.
Glance size initialization is amended to correspond to the new display
(Should still show "[N/A]", but without amending would show "<1").
Change-Id: I758febd3b6b1a1f13ae4e48635bf185ea81d918b
Bug-Url: https://bugzilla.redhat.com/1170263
Related-To: https://bugzilla.redhat.com/1202363
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractStorageSizeColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
M packaging/dbscripts/inst_sp.sql
A packaging/dbscripts/upgrade/03_06_1200_set_third_party_storage_size_to_NA.sql
7 files changed, 17 insertions(+), 25 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/37428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I758febd3b6b1a1f13ae4e48635bf185ea81d918b
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Remove constant SIZE_IS_NOT_AVAILABLE
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE
......................................................................
core: Remove constant SIZE_IS_NOT_AVAILABLE
Using null has the same effect, this constant only complicates things.
Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f
Related-To: https://bugzilla.redhat.com/1170263
Related-To: https://bugzilla.redhat.com/1202363
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/RepoImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
A packaging/dbscripts/upgrade/03_06_1190_update_repo_file_metadata_size.sql
9 files changed, 23 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/39004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Remove VM pool if no VMs can be created
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Remove VM pool if no VMs can be created
......................................................................
core: Remove VM pool if no VMs can be created
If VM pool is created via REST API and one of VM parameters is
incorrect, the VM Pool is created, but VM creation fails. In this case
VM pool is also removed, because VM pool without VMs shouldn't exist.
Change-Id: I36b137a905ea1364255af2bcdb11b27ed5198342
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1202129
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 24 insertions(+), 2 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39336
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36b137a905ea1364255af2bcdb11b27ed5198342
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: history: update dwh_vm_disks_history_view
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: history: update dwh_vm_disks_history_view
......................................................................
history: update dwh_vm_disks_history_view
updated dwh_vm_disks_history_view.
changed logic of vm_disk_actual_size_mb field
to include the size of the vm snapshots.
Change-Id: I1a96176c6b2c8455cb46f53cbcc71b6d64ef1efe
Bug-Url:https://bugzilla.redhat.com/1169105
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/dbscripts/create_dwh_views.sql
1 file changed, 29 insertions(+), 14 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified
Eli Mesika: Looks good to me, approved
Yaniv Dary: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/37798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a96176c6b2c8455cb46f53cbcc71b6d64ef1efe
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: removed the content of the script changing blank templ...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: removed the content of the script changing blank template name
......................................................................
core: removed the content of the script changing blank template name
Renaming the Blank to Default caused issues with backward compatibility of the
REST API.
Fixed by removing the content of the script so it will have no effect - did not
delete it because there are newer scripts after this merged and it would create
inconsistencies in numbering.
Change-Id: I90b88dbdc314efb3db68498db3632c46058a3585
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M packaging/dbscripts/upgrade/03_06_1160_rename_blank_to_default.sql
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90b88dbdc314efb3db68498db3632c46058a3585
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: events: Refine Host Activation Message (#1193060)
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: events: Refine Host Activation Message (#1193060)
......................................................................
events: Refine Host Activation Message (#1193060)
When user activates a host, ActivateVdsCommand doesn't
perform the actual activation; it only changes the host
status. The host is activated later asynchronously.
When the command terminates it audits:
Host X activated by user Y.
This is not true, and if some error prvents the actual
activation, the audit log is confusing. So the auditing
was changed to:
Activation of host X initiated by user Y.
Bug-Url: http://bugzilla.redhat.com/1193060
Change-Id: I698dac3797c957ed3dabe33490482e334d9d27d8
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I698dac3797c957ed3dabe33490482e334d9d27d8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months