April 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: new job for jasper-reports
by dcaroest＠redhat.com 09 Apr '15

09 Apr '15

David Caro has submitted this change and it was merged. Change subject: new job for jasper-reports ...................................................................... new job for jasper-reports Change-Id: If46fe2edd4b60ce0ab8ed8882d1fd33c37913cb8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A jobs/confs/yaml/jobs/jasper-reports/jasper-reports_create-rpms.yaml 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If46fe2edd4b60ce0ab8ed8882d1fd33c37913cb8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: sos: updated FSF address
by sbonazzo＠redhat.com 09 Apr '15

09 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: updated FSF address ...................................................................... sos: updated FSF address updated FSF address as reported by rpmlint. Change-Id: Ifc5bfb976580e4fb447be4b3fd6a49a25b0eb123 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/ovirt.py M src/sos/plugins/postgresql.py 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc5bfb976580e4fb447be4b3fd6a49a25b0eb123 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RepoFileMetraDataDAOTest#testPrimaryKeyValidation
by amureini＠redhat.com 09 Apr '15

09 Apr '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RepoFileMetraDataDAOTest#testPrimaryKeyValidation ...................................................................... core: RepoFileMetraDataDAOTest#testPrimaryKeyValidation Cleaned up the test, used the proper expected exception syntax. Change-Id: Ief0c50fedf04697473b8e790ee883007f14bd91d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/39712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0c50fedf04697473b8e790ee883007f14bd91d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RepoFileMetaDataDAOTest boolean assertions
by amureini＠redhat.com 09 Apr '15

09 Apr '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RepoFileMetaDataDAOTest boolean assertions ...................................................................... core: RepoFileMetaDataDAOTest boolean assertions Simplified assertEquals and assertSame asserts which involved boolean literals to cleaner assertTrue and assertFalse statements. Change-Id: Iabb0fc701116164235a9daac3a6a275a07ffeb98 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java 1 file changed, 16 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/39710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabb0fc701116164235a9daac3a6a275a07ffeb98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RepoFileMetaDataDAOTest equality assertions
by amureini＠redhat.com 09 Apr '15

09 Apr '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RepoFileMetaDataDAOTest equality assertions ...................................................................... core: RepoFileMetaDataDAOTest equality assertions Fixed all equality based assertions to use the standard assertEquals method instead of explicitly calling equals or ==. assertSame calls were also removed, since although they are not strictly wrong, assertSame should be used to check identity, not primitive equality. Change-Id: I41a5ada68caf3421d9330b6f5a591dee98903096 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java 1 file changed, 7 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/39711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41a5ada68caf3421d9330b6f5a591dee98903096 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RepoFileMetaDataDAOTest generics
by amureini＠redhat.com 09 Apr '15

09 Apr '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: RepoFileMetaDataDAOTest generics ...................................................................... core: RepoFileMetaDataDAOTest generics Used Java 7 style diamond generics where possible. Change-Id: I7cf289f581d0c30bd513bcb1aa17c245f1431c4e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/39713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cf289f581d0c30bd513bcb1aa17c245f1431c4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Show data center name in add storage domain task info
by tnisan＠redhat.com 09 Apr '15

09 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Show data center name in add storage domain task info ...................................................................... webadmin: Show data center name in add storage domain task info Change-Id: I76f32f1bc2050c05f6396370d1302dcf2f9e3e78 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1139160 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76f32f1bc2050c05f6396370d1302dcf2f9e3e78 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Do not allow reinitialization of a Data Center whe...
by tnisan＠redhat.com 09 Apr '15

09 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Do not allow reinitialization of a Data Center when the DC is up ...................................................................... webadmin: Do not allow reinitialization of a Data Center when the DC is up Change-Id: I35ca10b2ebc7b438d05dd9ea2571759652c30dc7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1085012 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35ca10b2ebc7b438d05dd9ea2571759652c30dc7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: addHost form leaves json checkbox locked when swit...
by tnisan＠redhat.com 09 Apr '15

09 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters ...................................................................... webadmin: addHost form leaves json checkbox locked when switching between clusters When switching between clusters that don't support json protocol to ones that support the protocol the JSON checkbox is left disabled. Change-Id: I29f5de9f20ccf12382da99117c1f4fd922650b1b Bug-Url: https://bugzilla.redhat.com/1209754 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29f5de9f20ccf12382da99117c1f4fd922650b1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: spec: add python as build requirement
by sradco＠redhat.com 09 Apr '15

09 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: add python as build requirement ...................................................................... packaging: spec: add python as build requirement Change-Id: I1e8f4abda7844c2262d26966aa86e05fea855a91 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e8f4abda7844c2262d26966aa86e05fea855a91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0