Change in ovirt-engine[master]: pki: pki-create-ca.sh: add renew
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: pki: pki-create-ca.sh: add renew
......................................................................
pki: pki-create-ca.sh: add renew
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210486
Change-Id: I2a277fab7aedcdb23aa1c09cde84fc90b8a61536
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/pki-create-ca.sh
1 file changed, 33 insertions(+), 8 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a277fab7aedcdb23aa1c09cde84fc90b8a61536
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in jenkins[master]: ebay-cors-filter is included in fedora >= 22
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ebay-cors-filter is included in fedora >= 22
......................................................................
ebay-cors-filter is included in fedora >= 22
dropping fedora >= 22 build
Change-Id: I3c5fc4d21701df2c2aca5c79c80519c05de276e3
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/jobs/ebay-cors-filter/ebay-cors-filter.yaml
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sagi Shnaidman: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c5fc4d21701df2c2aca5c79c80519c05de276e3
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: engine: use @Test(excepted=..) instead of try-catch
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: use @Test(excepted=..) instead of try-catch
......................................................................
engine: use @Test(excepted=..) instead of try-catch
Change-Id: I0ff261bf0be53e51d7dbc5454ccb4896fd429ccd
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImplTest.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Alona Kaplan: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39694
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ff261bf0be53e51d7dbc5454ccb4896fd429ccd
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: Adds title to Optimize for virt confirmation dialog
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Adds title to Optimize for virt confirmation dialog
......................................................................
webadmin: Adds title to Optimize for virt confirmation dialog
The confirmation model window to confirm Optimize for virt store
is added with title text, which was missing earlier
Change-Id: I1e4fb62dc787220ceefc5d491bb0051da769cdef
Bug-Url: https://bugzilla.redhat.com/1186598
Signed-off-by: Karnan TC <kchidamb(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Karnan t c: Verified
Kanagaraj M: Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39591
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e4fb62dc787220ceefc5d491bb0051da769cdef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: Shows disperse count only for disperse volume
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Shows disperse count only for disperse volume
......................................................................
webadmin: Shows disperse count only for disperse volume
disperse count and redundancy count fields are displayed
on the general tab, only if the selected volume
is a disperse volume
Change-Id: I29932cefe3283a7d5fb2878ef5f0db36a4741230
Bug-Url: https://bugzilla.redhat.com/1205107
Signed-off-by: Karnan TC <kchidamb(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeGeneralView.java
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Karnan t c: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39567
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29932cefe3283a7d5fb2878ef5f0db36a4741230
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: engine: add passthrough validation to add/edit vnic profile
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: add passthrough validation to add/edit vnic profile
......................................................................
engine: add passthrough validation to add/edit vnic profile
edit-
- passthrough property is not changed
add/edit-
- passthroug profile doesn't have 'port-mirroring' and 'QoS'
Change-Id: Id99e822ec02ca62eab1a8b89e18b6cf047153c13
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 96 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38892
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id99e822ec02ca62eab1a8b89e18b6cf047153c13
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: engine: blocking unlinking of passthrough vnic
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: blocking unlinking of passthrough vnic
......................................................................
engine: blocking unlinking of passthrough vnic
Passthrough vnic should be always linked (even if the vm is down and
the vnic is unplugged).
Change-Id: Icbb89bcdc1af6b87b8e1e04c52424ca282db7222
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
12 files changed, 60 insertions(+), 11 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbb89bcdc1af6b87b8e1e04c52424ca282db7222
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: changed confirmation message restore snapshot popup
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: changed confirmation message restore snapshot popup
......................................................................
webadmin: changed confirmation message restore snapshot popup
changed the confirmation message to warn user that the volume
will be brought down to restore snapshot when volume is online.
Change-Id: I34d27eed4d24c039bbe74c0b165e6a6dce9baa95
Bug-Url: https://bugzilla.redhat.com/1203454
Signed-off-by: Karnan TC <kchidamb(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 1 insertion(+), 12 deletions(-)
Approvals:
Karnan t c: Verified
Shubhendu Tripathi: Looks good to me, but someone else must approve
Kanagaraj M: Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34d27eed4d24c039bbe74c0b165e6a6dce9baa95
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Karnan t c <kchidamb(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: pki: comply with rfc2459 UTCTime restriction
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: pki: comply with rfc2459 UTCTime restriction
......................................................................
pki: comply with rfc2459 UTCTime restriction
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210486
Change-Id: Ie7440b5918090fce595a237a4be861b2a7400b74
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/pki-create-ca.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7440b5918090fce595a237a4be861b2a7400b74
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: packaging: setup: clean up selinux and move to common
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: clean up selinux and move to common
......................................................................
packaging: setup: clean up selinux and move to common
Make all users use env and just a single plugin actually call selinux
commands.
Move to to common/base so it's available to others.
Change-Id: I7e2c7e6871cab4bed04186b8441b86d0476910f9
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/base/system/__init__.py
R packaging/setup/plugins/ovirt-engine-common/base/system/selinux.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/selinux.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py
6 files changed, 52 insertions(+), 95 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/39672
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e2c7e6871cab4bed04186b8441b86d0476910f9
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months