Change in ovirt-engine[master]: webadmin: add DiskStorageType to disks tree
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: add DiskStorageType to disks tree
......................................................................
webadmin: add DiskStorageType to disks tree
Adding DiskStorageType column to Disks tree (in Templates->Disks
sub-tab)
and Storage tree (in Templates->Storage sub-tab->Disk tables).
Change-Id: I476b074fa83ec316f4e7778050d5643e8092fbb2
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateDiskView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java
4 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I476b074fa83ec316f4e7778050d5643e8092fbb2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in ovirt-engine[master]: webadmin: support make template with Cinder disks
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: support make template with Cinder disks
......................................................................
webadmin: support make template with Cinder disks
make template dialog - include Cinder disks to support
template creation.
Change-Id: Id6000886d07a1a62150065d3305e537a32f27106
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 62 insertions(+), 19 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6000886d07a1a62150065d3305e537a32f27106
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in ovirt-engine[master]: backend: initAppsList should not process null objects
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: initAppsList should not process null objects
......................................................................
backend: initAppsList should not process null objects
If the appsList contains non-strings or null values, a
null value would have been passed to the string builder.
This patch handles these cases and warns about wrong types
in the appsList.
Change-Id: Ia51bb09466a870695c0457679362f34ec9f6202f
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Vinzenz Feenstra: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40381
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia51bb09466a870695c0457679362f34ec9f6202f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in jenkins[master]: Adding bats for old distros
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Adding bats for old distros
......................................................................
Adding bats for old distros
It seems that bats is not on el* or fc<21 repos, so I've compiled it and added
it to de ci-tools repo for the slaves to pull it when needed.
Change-Id: I5855311a2a4ed2943d311cd2ca4c61fffd13087b
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/yaml/jobs/repoman/repoman_build-artifacts.yaml
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Barak Korren: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved; Ready for merge
--
To view, visit https://gerrit.ovirt.org/40374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5855311a2a4ed2943d311cd2ca4c61fffd13087b
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in jenkins[master]: Adding gpg check for fc22
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Adding gpg check for fc22
......................................................................
Adding gpg check for fc22
Not having it makes running yum/dnf inside the mock env fail with a quite cryptic
message (inappropriate ioctl for device)
Change-Id: Ic62d05466f69f179686a9ae9bbb927820a4409db
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M mock_configs/fedora-22-x86_64.cfg
M mock_configs/fedora-22-x86_64_proxied.cfg
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Barak Korren: Looks good to me, but someone else must approve
David Caro: Verified; Looks good to me, approved; Ready for merge
--
To view, visit https://gerrit.ovirt.org/40305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic62d05466f69f179686a9ae9bbb927820a4409db
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
8 years, 11 months
Change in ovirt-engine[master]: core: enabled the memballoon for PPC since cluster level 3.5
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: enabled the memballoon for PPC since cluster level 3.5
......................................................................
core: enabled the memballoon for PPC since cluster level 3.5
Enabled it in the osinfo
Change-Id: I596eb1b10751b515d8d7a59c1bac86561faac342
Bug-Url: https://bugzilla.redhat.com/1198214
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40364
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I596eb1b10751b515d8d7a59c1bac86561faac342
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in ovirt-engine[master]: restapi: Don't display PM type when PM disabled (#1191478)
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Don't display PM type when PM disabled (#1191478)
......................................................................
restapi: Don't display PM type when PM disabled (#1191478)
Currenly Power-Management type is disaplyed even when
Power-Managemnent is disabled for the host. This patch
fixed that.
This patch also declares this field as deprecated, since
speaking of the 'type' of Power-Management doesn't make
sense since intorduction of fence-agents. Type should be
associated with a specific agent, not the entire PM.
It was not deleted from PM to maintain backwards
compatibility.
Bug-Url: http://bugzilla.redhat.com/1191478
Change-Id: I0630ebde2b342964f44c3fad51de1ca5032b5c23
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DeprecatedPowerManagementMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DeprecatedPowerManagementMapperTest.java
4 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40382
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0630ebde2b342964f44c3fad51de1ca5032b5c23
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in ovirt-engine[master]: restapi: Remove unused classes
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove unused classes
......................................................................
restapi: Remove unused classes
This patch removes unused classes and dependencies from the RESTAPI
"interface-common-jaxrs" module.
Change-Id: Ia28854f308c56e7ca48c127eae30329b3aea6b1c
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/AbstractActionableResource.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/AbstractUpdatableResource.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/BaseActionResource.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/UriInfoProvider.java
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/modules/org/ovirt/engine/api/interface-common-jaxrs/main/module.xml
6 files changed, 0 insertions(+), 436 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Juan Hernandez: Verified
--
To view, visit https://gerrit.ovirt.org/40328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28854f308c56e7ca48c127eae30329b3aea6b1c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Add an indicator if volume snapshot is scheduled
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Add an indicator if volume snapshot is scheduled
......................................................................
webadmin: Add an indicator if volume snapshot is scheduled
Added an indicator column to volume tab, to indicate if
volume snapshot creation is scheduled.
Change-Id: I4ea607285caaa343c389813681bd9e782381ae86
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/snapshot_scheduled.png
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java
5 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ea607285caaa343c389813681bd9e782381ae86
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix AddVmTemplate unreleased lock
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix AddVmTemplate unreleased lock
......................................................................
core: Fix AddVmTemplate unreleased lock
AddVmTemplate child command caused a lock lost in some conditions,
the problem occurred because the child command got the parent command
context instead of a clone, when the child command cleared the lock
(before it started the execution) it caused the parent command to lose
that lock as well.
The clone creation was missing in CommandBase::insertAsyncTaskPlaceHolders(),
because this mechanism was removed in 3.6, and because the current problem
seems to only affect addVmTemplate, this fix is local only to AddVmTemplate
so changes for the infrastructure are minimal.
Change-Id: I3e1f0c04094866bf0bb7b36a6e166280939a2d8c
Bug-Url: https://bugzilla.redhat.com/1203307
Signed-off-by: Eldan Shachar <eshachar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
2 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Eldan Shachar: Verified
Ravi Nori: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39773
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e1f0c04094866bf0bb7b36a6e166280939a2d8c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8 years, 11 months