April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Add Africa/Algiers Time Zone
by tnisan＠redhat.com 28 Apr '15

28 Apr '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add Africa/Algiers Time Zone ...................................................................... core: Add Africa/Algiers Time Zone Change-Id: Ia573080ed2a145c4198cb72985b1185cd3f78223 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1210633 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/39887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia573080ed2a145c4198cb72985b1185cd3f78223 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: fc21: reintroduce apache-sshd dependency
by sbonazzo＠redhat.com 28 Apr '15

28 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: fc21: reintroduce apache-sshd dependency ...................................................................... packaging: spec: fc21: reintroduce apache-sshd dependency Change-Id: If49b098bad820cc58ed07cdb0413ec98c9273d66 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If49b098bad820cc58ed07cdb0413ec98c9273d66 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Allow multiple scopes
by sbonazzo＠redhat.com 28 Apr '15

28 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Allow multiple scopes ...................................................................... packaging: engine-backup: Allow multiple scopes Allow passing '--scope=' more than once. Also fix some issues related to backing up or restoring with different or multiple scopes. Change-Id: I331900e5ca92bd91196189cf584694c64bddf240 Bug-Url: https://bugzilla.redhat.com/1208122 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 64 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I331900e5ca92bd91196189cf584694c64bddf240 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Add HostDev passthrough support #3
by ofrenkel＠redhat.com 28 Apr '15

28 Apr '15

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Add HostDev passthrough support #3 ...................................................................... backend: Add HostDev passthrough support #3 Added a new type of VmDevice for passthrough device -> VmHostDevice and related Add/Remove commands. One thing the commands need to handle is the IOMMU group restriction: The backend needs to make sure all device in given IOMMU group are either plugged or unplugged atomically. Otherwise libvirt will fail. To guarantee this we support bulk commands for Adding/Removing VmHostDevices that will compute the "closure" of affected devices -> devices that need to be either added or removed. After this the Add/Remove commad will apply the difference to get to desired state (e.g. some devices from group may already be attached/detached, we need to add/remove only the rest). To maintain consitency between configured VmHostDevices and actual HostDevices we run refresh host devices of UP hosts in InitBackendServicesOnStartupBean when engine restarts and in RefreshHostDevicesCommand we clear 'disappeard' host devices from Vms. To prevent conflicts when running multiple VMs with same configured host devices we introduced new LockingGroup.HOST_DEVICES. We are using this locking group to lock host id when we are accessing it's host devices from RunVmCommand, RefreshHostDevicesCommand, and ProcessDownVmCommand. Wiki: http://www.ovirt.org/Features/hostdev_passthrough Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099760 Change-Id: I93c746cdda71678f7840d37683b890080a74341d Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetExtendedHostDevicesByHostIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetExtendedVmHostDevicesByVmIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostDeviceByHostIdAndDeviceNameQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostDevicesByHostIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmHostDeviceByVmIdAndDeviceNameQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmHostDevicesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AbstractVmHostDevicesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/AddVmHostDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RemoveVmHostDevicesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmHostDevicesParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmHostDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VmHostDeviceQueryParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_1300_again_add_vm_host_device_commands.sql 35 files changed, 705 insertions(+), 54 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93c746cdda71678f7840d37683b890080a74341d Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <matobet(a)gmail.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Add "parent" prefix to parent identifier options
by juan.hernandez＠redhat.com 28 Apr '15

28 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add "parent" prefix to parent identifier options ...................................................................... cli: Add "parent" prefix to parent identifier options Currently the way to specify the identifier of a parent entity is to use the "--*-identifier" or "--*-name" options. These option, specially the "name" option, may conflict with other options used to populate the request. For example, when adding a storage domain the "--host-name" option is used to indicate what host name should perform the operation, but the CLI assumes that it is used to specify the parent host, which doesn't make sense. This patch changes the CLI so that it will require the "parent" prefix in the option used to specify the parent name. The option used to specify the parent identifier will also support the "parent" prefix, but it will still work without it, for backwards compatibility. Change-Id: I4150389b6c87cc178865757f99a2e09e272c530f Bug-Url: https://bugzilla.redhat.com/1213393 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/action.py M src/ovirtcli/command/add.py M src/ovirtcli/command/command.py M src/ovirtcli/command/list.py M src/ovirtcli/command/remove.py M src/ovirtcli/command/show.py M src/ovirtcli/command/update.py M src/ovirtcli/utils/autocompletionhelper.py 8 files changed, 82 insertions(+), 50 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4150389b6c87cc178865757f99a2e09e272c530f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: engine-backup: reset DwhCurrentlyRunning
by sbonazzo＠redhat.com 28 Apr '15

28 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: reset DwhCurrentlyRunning ...................................................................... packaging: engine-backup: reset DwhCurrentlyRunning Reset DwhCurrentlyRunning during restore, to avoid a later engine-setup failure due to it being set to '1' if dwhd was running during the time of backup. Change-Id: I4303279250c1ee1b3b470842e0d8ec17c03dd4d8 Related-To: https://bugzilla.redhat.com/1158985 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4303279250c1ee1b3b470842e0d8ec17c03dd4d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Improve exception handling in FOP writer
by juan.hernandez＠redhat.com 28 Apr '15

28 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Improve exception handling in FOP writer ...................................................................... restapi: Improve exception handling in FOP writer This is basically to make Coverity happy. Change-Id: I6d3202ba59ebe111f0180956a839e46b57149506 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/pdf/FOPMessageBodyWriter.java R backend/manager/modules/restapi/jaxrs/src/main/resources/pdf/GlusterVolumeProfileDetails.xsl 2 files changed, 136 insertions(+), 44 deletions(-) Approvals: Juan Hernandez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d3202ba59ebe111f0180956a839e46b57149506 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Consider provider name in NetworkView hashcode/equals
by lvernia＠redhat.com 28 Apr '15

28 Apr '15

Lior Vernia has submitted this change and it was merged. Change subject: core: Consider provider name in NetworkView hashcode/equals ...................................................................... core: Consider provider name in NetworkView hashcode/equals It was left out. Change-Id: Ibb320306eb0448923843e994fe0adff5c4f5c0cd Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb320306eb0448923843e994fe0adff5c4f5c0cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: use common pg_cmd
by sbonazzo＠redhat.com 28 Apr '15

28 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: use common pg_cmd ...................................................................... packaging: engine-backup: use common pg_cmd No need to copy pg_cmd around. 'local' variables defined by a bash (and ash/dash/posh) function are inherrited by other functions called from it. Change-Id: I745db3155f679a6cd6f49763d3f9df4e08031156 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 18 insertions(+), 39 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I745db3155f679a6cd6f49763d3f9df4e08031156 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Adding tests on all supported platforms
by dcaroest＠redhat.com 28 Apr '15

28 Apr '15

David Caro has submitted this change and it was merged. Change subject: Adding tests on all supported platforms ...................................................................... Adding tests on all supported platforms Change-Id: Ia00f735864a86f632c667f8e53d68734d3ff2aa4 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/jobs/repoman/repoman_build-artifacts.yaml 1 file changed, 6 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve; Ready for review David Caro: Verified; Looks good to me, approved; Ready for merge -- To view, visit https://gerrit.ovirt.org/40352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia00f735864a86f632c667f8e53d68734d3ff2aa4 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0