April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: codegen: Don't generate duplicated commas
by juan.hernandez＠redhat.com 06 Apr '15

06 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Don't generate duplicated commas ...................................................................... codegen: Don't generate duplicated commas Currently the generator of the SDK generates two commas inside the formal parameter list of the "delete" methods of resources that support both URL and header parameters. This patch fixes the generator so that it generates only one comman in this case. Change-Id: I2a84cb9b64839d3995cf0713640f6fbf5cbd7b64 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Resource.java 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a84cb9b64839d3995cf0713640f6fbf5cbd7b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 06 Apr '15

06 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 5848ebe. Change-Id: I0e4ec076eb4b6e623ef157e770d61725157a7268 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/resources/api.xsd M generator/src/main/resources/memory.properties M generator/src/main/resources/rsdl.xml M sdk/Makefile M sdk/src/main/java/org/ovirt/engine/sdk/Api.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Bookmarks.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Cluster.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ClusterAffinityGroup.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ClusterAffinityGroupVM.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ClusterAffinityGroupVMs.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ClusterAffinityGroups.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBond.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBondNetworks.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterIscsiBonds.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Event.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ExternalHostProvider.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ExternalHostProviders.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostAgent.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/HostAgents.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackVolumeProvider.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackVolumeProviderCertificate.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackVolumeProviderCertificates.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackVolumeProviderOpenStackVolumeType.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackVolumeProviderOpenStackVolumeTypes.java A sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackVolumeProviders.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainStorageConnection.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M sdk/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/Action.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/Agent.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/BaseResources.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/Cluster.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/ExternalProvider.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/OpenStackProvider.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/OpenStackVolumeProvider.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/OpenStackVolumeProviders.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/OpenStackVolumeType.java A sdk/src/main/java/org/ovirt/engine/sdk/entities/OpenStackVolumeTypes.java M sdk/src/main/java/org/ovirt/engine/sdk/entities/VmPool.java 43 files changed, 2,696 insertions(+), 75 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e4ec076eb4b6e623ef157e770d61725157a7268 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin : Fix Volumes tab space used column
by kmayilsa＠redhat.com 06 Apr '15

06 Apr '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fix Volumes tab space used column ...................................................................... webadmin : Fix Volumes tab space used column Fix Volumes tab space used column Change-Id: I48d0961cf0bf3d697069ac7902a3b39ee07e1335 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140132 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48d0961cf0bf3d697069ac7902a3b39ee07e1335 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Double Notification Received (#1192528)
by oourfali＠redhat.com 06 Apr '15

06 Apr '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Double Notification Received (#1192528) ...................................................................... engine: Double Notification Received (#1192528) When a Highly-Available VM goes down with an error, the engine attempts to re-run it. If the first attempt fails, the engine immediately attempts once more. Subscribers which subscribed to the notification: "VDS_INITIATED_RUN_VM_FAILED" receive notification about both events, even though they are milliseconds apart and one notification should be enough. This bug was solved by setting a 'flood limit' of 5 seconds on this event. Change-Id: Ib97d2e7f456f13331f843591716f280b9f17d1ca Bug-Url: https://bugzilla.redhat.com/1192528 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Verified mooli tayer: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib97d2e7f456f13331f843591716f280b9f17d1ca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: add OpenStackVolumeTypes sub-collection
by derez＠redhat.com 06 Apr '15

06 Apr '15

Daniel Erez has submitted this change and it was merged. Change subject: restapi: add OpenStackVolumeTypes sub-collection ...................................................................... restapi: add OpenStackVolumeTypes sub-collection Adding OpenStackVolumeTypes sub-collection to OpenStackVolumeProviders root-collection: * Added OpenStackVolumeType/OpenStackVolumeTypes elements. * Support GET /api/openstackvolumeproviders/{provider_id}/volumetypes. * Added relevant tests. * Updated rsdl_metadata.yaml accordingly. Feature Page: http://www.ovirt.org/Features/Cinder_Integration Change-Id: I08157edb4f4808880848bc9f7d07c29500d1197d Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeProviderResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeTypeResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackVolumeTypesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImagesResource.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackStorageProviderHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeProviderResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypeResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypesResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypeResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackVolumeTypesResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackVolumeTypeMapper.java 15 files changed, 558 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08157edb4f4808880848bc9f7d07c29500d1197d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: codegen: Sort and remember header parameters
by juan.hernandez＠redhat.com 06 Apr '15

06 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Sort and remember header parameters ...................................................................... codegen: Sort and remember header parameters Currently the order of parameters corresponding to headers in generated code is the same that the order of those parameters in the RSDL metadata. This means that adding new parameters or reordering them in the RSDL metadata produces the same reordering in the parameters of the methods of the generated code. For example, one of the methods to add a cluster has currently the following signature: Cluster add(Cluster cluster, String expect, String correlationId) The order is "expect" and then "correlation-id" because that is the order in the RSDL. If the RSDL changes in such a way that the parameters have a different order (because a new parameter is added, or just because the RSDL is generated with a different algorithm) then the method could become something like this: Cluster add(Cluster cluster, String correlationId, String expect) This is extremelly dangerous, as it it is swapping the parameters but it will compile just fine. To avoid this issue this patch changes the generator so that the parameters are always sorted by name before generating the code. This is not enough, as it doesn't solve the issue when new parameters are added. To solve that as well this patch introduces a "memory" (stored in a properties file) where the generator remembers what was the order of the previous execution. That order will be respected regardless of changes in the RSDL. Change-Id: I4a3916a04e8475f105099836de67ab85d3fb3feb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/pom.xml A generator/src/main/java/org/ovirt/engine/sdk/generator/Memory.java M generator/src/main/java/org/ovirt/engine/sdk/generator/java/Main.java A generator/src/main/java/org/ovirt/engine/sdk/generator/java/utils/ExceptionsAwareComparator.java M generator/src/main/java/org/ovirt/engine/sdk/generator/java/utils/LinkUtils.java A generator/src/main/resources/README.md A generator/src/main/resources/memory.properties M sdk/README.md 8 files changed, 657 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a3916a04e8475f105099836de67ab85d3fb3feb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: sdk: Add documentation subpackage
by juan.hernandez＠redhat.com 06 Apr '15

06 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add documentation subpackage ...................................................................... sdk: Add documentation subpackage This patch modifies the .spec of the SDK so that it generates a new "doc" subpackage that contains the documentation automatically generated with the "sphinx-apidoc" tool. Change-Id: Id0243488fb8349c127eadcd0e940bf462a45b449 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-python.spec.in 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0243488fb8349c127eadcd0e940bf462a45b449 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix injection for FenceAgentDAODbFacadeImpl
by emesika＠redhat.com 05 Apr '15

05 Apr '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix injection for FenceAgentDAODbFacadeImpl ...................................................................... core: Fix injection for FenceAgentDAODbFacadeImpl Adds missing @Named @Singleton annotations to FenceAgentDAODbFacadeImpl which cause NPE when getting DAO instance. The bug was introduced in patch Ic426126d690ab6dedb49ef6b67deeba67661d031 Change-Id: I9fd10b968b7742b2a91a103932e1d56c93db922b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/FenceAgentDaoDbFacadeImpl.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd10b968b7742b2a91a103932e1d56c93db922b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: allow tuning dump/restore
by sradco＠redhat.com 05 Apr '15

05 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: allow tuning dump/restore ...................................................................... packaging: setup: allow tuning dump/restore Adapt to the engine's recent changes: I271b1c7c3682a3d0bcc69ae6ea6c9e717ed029d1 I99de636d4da15a253f2186084902f0f133603f4d Change-Id: I6a07e5fef2f8aea6310047eb5210ad5d36be653a Bug-Url: https://bugzilla.redhat.com/1208578 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 2 files changed, 91 insertions(+), 27 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/39502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a07e5fef2f8aea6310047eb5210ad5d36be653a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: allow tuning dump/restore
by sradco＠redhat.com 05 Apr '15

05 Apr '15

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: allow tuning dump/restore ...................................................................... packaging: setup: allow tuning dump/restore Adapt to the engine's recent changes: I271b1c7c3682a3d0bcc69ae6ea6c9e717ed029d1 I99de636d4da15a253f2186084902f0f133603f4d Change-Id: Ie53dcde6c07cf8562f99334dbf575ba1fa393833 Bug-Url: https://bugzilla.redhat.com/1208578 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py 2 files changed, 100 insertions(+), 34 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/39503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie53dcde6c07cf8562f99334dbf575ba1fa393833 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0