Change in jenkins[master]: Adding rpm exporting as part of our iso build
by tlitovsk＠redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: Adding rpm exporting as part of our iso build
......................................................................
Adding rpm exporting as part of our iso build
Change-Id: I0842c52c81b44b148ecd26367bc567db4b5410e4
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
M jobs/confs/shell-scripts/build-local-ovirt-node-iso.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Anatoly Litovsky: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39482
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0842c52c81b44b148ecd26367bc567db4b5410e4
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: webadmin: change layout of table of vms to be imported
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: change layout of table of vms to be imported
......................................................................
webadmin: change layout of table of vms to be imported
Put the VM name as the first column since putting the collapse snapshots
as the first column is confusing because it contains checkboxes so it
looks like it indicates the selected VMs.
Change-Id: I0dea6b6b525f4f66697c9bfb76c90437dc06b160
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/37880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dea6b6b525f4f66697c9bfb76c90437dc06b160
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: REST API login popup
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: REST API login popup
......................................................................
webadmin: REST API login popup
- The REST API login popup would appear when one of the following was true:
1 The engine session hard limit was reached (10 hours) and the REST API
ping would happen before a refresh that would cause a logout.
2 The REST API ping would not happen due to it detecting that the refresh
flag was not set, however the engine would internally set the refresh
on a sub query. This causes the REST api http session to expire and on
a sub sequent ping would cause the popup to appear.
- This patch fixes 1. We take the hard limit into account and if we are close
enough to the hard limit the REST API ping is disabled causing the natural
logout of the webadmin UI to happen.
Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206908
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/EngineSessionTimeoutData.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
5 files changed, 53 insertions(+), 16 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: no auto logout when idle
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: no auto logout when idle
......................................................................
webadmin: no auto logout when idle
- The general VM sub tab and network interface VM sub tab
where executing queries that didn't have their refresh
false flag set.
Change-Id: I52b9ea108ddca3d2d137860b9425691ffc0a95ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206332
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
3 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52b9ea108ddca3d2d137860b9425691ffc0a95ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: Requesting to consume quota while extending a disk fix.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Requesting to consume quota while extending a disk fix.
......................................................................
core: Requesting to consume quota while extending a disk fix.
Until now when the user wanted to extend a disk, there was no
request generated for quota consumption. This fact let the user to
extend the disk's size as much as he likes when there are quota
limitations.
This patch adds a request for quota consumption when disks are
extended.
Change-Id: Ib31206b0a9172b35217845b01253951d93f380f1
Bug-Url: https://bugzilla.redhat.com/1203262
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
2 files changed, 42 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/39442
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib31206b0a9172b35217845b01253951d93f380f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in jenkins[master]: Adding iso builds for ovirt-node-iso 3.5 branch
by tlitovsk＠redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: Adding iso builds for ovirt-node-iso 3.5 branch
......................................................................
Adding iso builds for ovirt-node-iso 3.5 branch
Change-Id: Ic8986286520379b9f23bdf01c5fbc6324fa149b1
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt-node/ovirt-node-job.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Anatoly Litovsky: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39467
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8986286520379b9f23bdf01c5fbc6324fa149b1
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: gluster: add mount point in the brick creation.
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: add mount point in the brick creation.
......................................................................
gluster: add mount point in the brick creation.
Mount point is not returned as part of the createBrick VDSM verb.
So add the mount point which is given as a parameter to the create
brick.
Change-Id: I709b8a1e6e7b0732631ba4c4700a26def8433731
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateBrickCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/39438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I709b8a1e6e7b0732631ba4c4700a26def8433731
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: gluster: add 'gluster' prefix to getStorageDeviceList method
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: add 'gluster' prefix to getStorageDeviceList method
......................................................................
gluster: add 'gluster' prefix to getStorageDeviceList method
Add 'gluster' prefix to getStorageDeviceList method in IVdsServer.
Change-Id: Ia053fd11c2c8b8ef3faddcfb1660c55a1cbf56bf
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetStorageDeviceListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
4 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/38508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia053fd11c2c8b8ef3faddcfb1660c55a1cbf56bf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: core: use single thread on update sla policies
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: use single thread on update sla policies
......................................................................
core: use single thread on update sla policies
when vms monitoring cycle finish, it is calling update sla policies in a
new thread.
the new vms monitoring changed the call to be per-vm instead of one call
for all vms that succeeded to run.
in this patch the previous approach restored, calling once with list of
vms, resulting only one thread for all the vms.
Change-Id: Id7f92bf64d771e351f2aab46874515eb70a713fa
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
1 file changed, 4 insertions(+), 7 deletions(-)
Approvals:
Gilad Chaplik: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
Omer Frenkel: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f92bf64d771e351f2aab46874515eb70a713fa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month
Change in ovirt-engine[master]: core: vmsMonitoring - persist vms data in refresh vms phase
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: vmsMonitoring - persist vms data in refresh vms phase
......................................................................
core: vmsMonitoring - persist vms data in refresh vms phase
the new structure of the host-vms monitoring caused the save vms info to
db to be called later in the cycle than it used to be.
this caused issues in operations that executed in afterVMsRefreshTreatment, that
assumed the db is updated.
in this patch the save-to-db moved back into the refreshVmStats from the
afterVMsRefreshTreatment, also with processExternallyManagedVms and
processVmsWithDevicesChange that originally happened before the save to
db.
Change-Id: I5e69b0ba20588db55bb40e9ba6ca5472c3efe687
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
1 file changed, 10 insertions(+), 11 deletions(-)
Approvals:
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39406
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e69b0ba20588db55bb40e9ba6ca5472c3efe687
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 1 month