Change in ovirt-engine[master]: core: Replace FenceExecutor in Start/Stop/RestartVDSCommands
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Replace FenceExecutor in Start/Stop/RestartVDSCommands
......................................................................
core: Replace FenceExecutor in Start/Stop/RestartVDSCommands
Replaces FenceExecutor with HostFenceActionExecutor in
Start/Stop/RestartVDSCommands.
Change-Id: I2cda348997927decc1b61bf4ce06c4489859c1d3
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/StartVdsCommandTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 95 insertions(+), 586 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cda348997927decc1b61bf4ce06c4489859c1d3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Introduce HostFenceActionExecutor
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Introduce HostFenceActionExecutor
......................................................................
core: Introduce HostFenceActionExecutor
Introduces HostFenceActionExecutor which is responsible to
execute fence action on specified host.
Change-Id: I15bbc7e4a7a297173d3486394ac53587306078b1
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/HostFenceActionExecutor.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/HostFenceActionExecutorTest.java
2 files changed, 387 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38965
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15bbc7e4a7a297173d3486394ac53587306078b1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Introduce ConcurrentAgentsFenceActionExecutor
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Introduce ConcurrentAgentsFenceActionExecutor
......................................................................
core: Introduce ConcurrentAgentsFenceActionExecutor
Introduces ConcurrentAgentsFenceActionExecutor which is responsible to
execute fence action on multiple fence agents concurrently. It uses
SingleAgentFenceExecutor to execute action on each agent.
Change-Id: I42e7fc0b530a341e9137c4d1efda6ae3f7ab2752
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/ConcurrentAgentsFenceActionExecutor.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/ConcurrentAgentsFenceActionExecutorTest.java
2 files changed, 587 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38964
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42e7fc0b530a341e9137c4d1efda6ae3f7ab2752
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Introduce SingleAgentFenceActionExecutor
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Introduce SingleAgentFenceActionExecutor
......................................................................
core: Introduce SingleAgentFenceActionExecutor
Introduces SingleAgentFenceActionExecutor which is responsible to
execute fence action on the host using single fence agent. It contains
logic to get status of the host or to start/stop the host and to verify
requested status using FenceAgentExecutor.
Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceActionExecutor.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutorTest.java
3 files changed, 541 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38358
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95958b4821fa8f55ee8913e926f9528ae56e20e8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Introduce FenceAgentExecutor
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Introduce FenceAgentExecutor
......................................................................
core: Introduce FenceAgentExecutor
Introduces FenceAgentExecutor which is responsible to execute fence
action with one fence agent. It uses FenceProxyLocator to select proxy
host and it also uses the retry logic if the first fence attempt
failed.
Change-Id: I10936f4bc6a3b824a10a7ebc39de1f3a48eb778e
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 505 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38063
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10936f4bc6a3b824a10a7ebc39de1f3a48eb778e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Refactor FenceVdsVDSCommand return value
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Refactor FenceVdsVDSCommand return value
......................................................................
core: Refactor FenceVdsVDSCommand return value
Introduces FenceOperationResult which will provider better support for
FenceVdsVDSCommand result management
Change-Id: I4b3ada18bb36a376c5c19327461d2daa53eedc59
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/PowerStatus.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResultTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommandTest.java
5 files changed, 568 insertions(+), 41 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b3ada18bb36a376c5c19327461d2daa53eedc59
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Prepare FenceVdsVDSCommand params on caller
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Prepare FenceVdsVDSCommand params on caller
......................................................................
core: Prepare FenceVdsVDSCommand params on caller
Moves all FenceVdsVDSCommand parameters conversion to caller, where they
belongs.
Change-Id: Ie17020705e411160f0cceb149d1fe64185d612a5
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceExecutorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceVdsVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
4 files changed, 68 insertions(+), 66 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie17020705e411160f0cceb149d1fe64185d612a5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: FenceVdsVDSCommandParameters code cleanup
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: FenceVdsVDSCommandParameters code cleanup
......................................................................
core: FenceVdsVDSCommandParameters code cleanup
1. Use FenceAgent class instead of its attributes
2. Code cleanup
Change-Id: I055276a4012180fda23bb2063c38df3bdd6ce876
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceVdsVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
3 files changed, 51 insertions(+), 67 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38061
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I055276a4012180fda23bb2063c38df3bdd6ce876
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: FenceVdsVDSCommand code cleanup
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: FenceVdsVDSCommand code cleanup
......................................................................
core: FenceVdsVDSCommand code cleanup
1. Use getDbFacade() to get the instance
2. Do parameters conversions and call to fenceNode() on one place
3. Code cleanup
Change-Id: I480f03acf41d53e90c3c0da6725523d0578adb52
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java
1 file changed, 59 insertions(+), 76 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I480f03acf41d53e90c3c0da6725523d0578adb52
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Provide copy constructor for FenceAgent
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Provide copy constructor for FenceAgent
......................................................................
core: Provide copy constructor for FenceAgent
Provides copy contsructor for FenceAgent
Change-Id: I382e01d35af79a3600e34e9a74757c2eba831482
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceAgent.java
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I382e01d35af79a3600e34e9a74757c2eba831482
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months