May 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: vdsm: Fedora 20 is not supported on master
by eedri＠redhat.com 20 May '15

20 May '15

Eyal Edri has submitted this change and it was merged. Change subject: vdsm: Fedora 20 is not supported on master ...................................................................... vdsm: Fedora 20 is not supported on master Vdsm requires now recent 1.2.9 libvirt versions which are not available on Fedora 20 even when using virt-preview repo. Change-Id: I14f2276aa8b7fabd828e60adfd971cea9606471c Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm/vdsm_install-rpm-sanity.yaml 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Looks good to me; Passed CI tests David Caro: Looks good to me Allon Mureinik: Looks good to me -- To view, visit https://gerrit.ovirt.org/41033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14f2276aa8b7fabd828e60adfd971cea9606471c Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: added support for iothreads
by tjelinek＠redhat.com 20 May '15

20 May '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: added support for iothreads ...................................................................... webadmin: added support for iothreads Added a new property to the VM dialogs. It is supported only for the 3.6 cluster level. Change-Id: I92b5829a585f1c2f92f7cb355741c6cc802e0596 Bug-Url: https://bugzilla.redhat.com/1214311 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/HwOnlyCoreUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/HwOnlyVmBaseToUnitBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ExistingBlankTemplateModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingNonClusterModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeAttachDetachManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmListModelTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmTest.java 14 files changed, 187 insertions(+), 47 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92b5829a585f1c2f92f7cb355741c6cc802e0596 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: added support for iothreads
by tjelinek＠redhat.com 20 May '15

20 May '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: added support for iothreads ...................................................................... core: added support for iothreads Added a new field 'num_of_io_threads' to vm_static. If 0 it means no iothreads are supposed to be allocated in qemu. If set, than: - numOfIoThreads will be passed to VDSM in VM properties - each virtio disk will be pinned to one IO thread using the round robin alg Change-Id: I32963f241b377f7fddb06e2b6b6492ebee2de207 Bug-Url: https://bugzilla.redhat.com/1214311 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/InstanceType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CustomInstanceType.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1430_add_num_of_io_threads_to_vm_static.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 24 files changed, 151 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32963f241b377f7fddb06e2b6b6492ebee2de207 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Incorrect check of VirtIO-SCSI status on VM update
by ofrenkel＠redhat.com 20 May '15

20 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Incorrect check of VirtIO-SCSI status on VM update ...................................................................... core: Incorrect check of VirtIO-SCSI status on VM update If VirtIO-SCSI device is to be enabled on VM update, cluster and OS compatibility must be verified. If getParameters().isVirtioScsiEnabled() is null, that means the current device status must be preserved. In this case, cluster and OS compatibility must be verified, if VirtIO-SCSI device is currently enabled. This logic is correctly implemented in UpdateVmCommand.isVirtioScsiEnabled() method, so we use it instead of incorrect condition used previously. Change-Id: I459256da7df4ef0f6662479df2d6d0a6cabc001b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219697 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I459256da7df4ef0f6662479df2d6d0a6cabc001b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: add missing safelease to ovirt-release36
by sbonazzo＠redhat.com 20 May '15

20 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: add missing safelease to ovirt-release36 ...................................................................... add missing safelease to ovirt-release36 - following new dependencies Change-Id: I1a9d85d04756fe73b6d92797a288809d0f908a97 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.6/ovirt-el6-deps.repo.in M ovirt-release-3.6/ovirt-el7-deps.repo.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9d85d04756fe73b6d92797a288809d0f908a97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: add missing safelease to ovirt-release-master
by sbonazzo＠redhat.com 20 May '15

20 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: add missing safelease to ovirt-release-master ...................................................................... add missing safelease to ovirt-release-master - following new dependencies Change-Id: I2a6638449078bfb09e298ee4fd8f2f702086e85d Signed-off-by: Max Kovgan <mvk(a)redhat.com> --- M ovirt-release-master/ovirt-el6-deps.repo.in M ovirt-release-master/ovirt-el7-deps.repo.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve Max Kovgan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a6638449078bfb09e298ee4fd8f2f702086e85d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI plugins - control tab priority
by kmayilsa＠redhat.com 20 May '15

20 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: UI plugins - control tab priority ...................................................................... webadmin: UI plugins - control tab priority When adding custom main or sub tab, UI plugins can now specify the priority of the tab, denoting its relative position within the tab panel. Standard main and sub tabs typically have their priority starting at 0 (left-most tab) and incremented by 1 for each next tab. For example, "DataCenter" main tab priority is 0, "Cluster" main tab priority is 1, and so on. Example usage: api.addMainTab('Test', 'test-tab', 'plugin/TestPlugin/tab.html', // tab options object, as documented at // http://www.ovirt.org/Features/UIPlugins#Main_and_sub_tabs { priority: -1 // position this tab before all standard ones } ); This patch also improves priority comparison in AbstractTabPanel to account for rounding procedure, e.g. representing real numbers in a floating point number system. Change-Id: I1251ccbe7b3cfbb378fa31ef6009184216409265 Bug-Url: https://bugzilla.redhat.com/1214624 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/FloatingPointHelper.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTabPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/TabOptions.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxyFactory.java 5 files changed, 85 insertions(+), 5 deletions(-) Approvals: Shubhendu Tripathi: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1251ccbe7b3cfbb378fa31ef6009184216409265 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI plugin revealPlace API - rename parameter
by kmayilsa＠redhat.com 20 May '15

20 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: UI plugin revealPlace API - rename parameter ...................................................................... webadmin: UI plugin revealPlace API - rename parameter Renamed placeToken to historyToken for consistency with existing APIs such as addMainTab & addSubTab. No impact on revealPlace API implementation. Change-Id: I073f51acb95438fbccf1f0c58796a885a44c1a50 Bug-Url: https://bugzilla.redhat.com/1168334 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Shubhendu Tripathi: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I073f51acb95438fbccf1f0c58796a885a44c1a50 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI plugin API - setSearchString
by kmayilsa＠redhat.com 20 May '15

20 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: UI plugin API - setSearchString ...................................................................... webadmin: UI plugin API - setSearchString This patch adds new UI plugin API function ('setSearchString') that can be used to apply given search string in WebAdmin's search panel. Just like the Search button, calling setSearchString function triggers transition to the corresponding application place, e.g. following code: api.setSearchString('Vms:'); causes the application to reveal following place: WebAdmin.html#vms // 'VM' main tab place API signature: setSearchString(searchString) Example usage: api.setSearchString('Hosts: name = abc'); Change-Id: I36eb8647577e974bddefe9462d302165a39b1c27 Bug-Url: https://bugzilla.redhat.com/1081028 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplySearchStringEvent.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java 5 files changed, 159 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Shubhendu Tripathi: Verified Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/41030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36eb8647577e974bddefe9462d302165a39b1c27 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI plugin API - revealPlace
by kmayilsa＠redhat.com 20 May '15

20 May '15

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: UI plugin API - revealPlace ...................................................................... webadmin: UI plugin API - revealPlace This patch adds new UI plugin API function ('revealPlace') that can be used to reveal desired application place, e.g. main or sub tab. An application place denotes a logical state of the web application, represented as '#placeToken' in application's URL, for example: WebAdmin.html#vms // 'VM' main tab place WebAdmin.html#vms-general // 'VM General' sub tab place revealPlace function works for both standard (built-in) and custom (UI-plugin-contributed) places, assuming that given place to reveal is available at time the function is called. (Otherwise, WebAdmin will transition to its default place, currently set to 'VM' main tab.) API signature: revealPlace(placeToken) Example usage: // switch to 'Hosts' main tab api.revealPlace('hosts'); // add custom main tab and switch to it api.addMainTab('Test', 'test', 'plugin/TestPlugin/tab.html'); api.revealPlace('test'); Note: setting place parameters, such as: WebAdmin.html#placeToken;paramName=paramValue is not supported (yet) since there currently aren't any application places utilizing such parameters. Change-Id: Ib4ae30f62c5bcd6793e19c8be6806f32bf68eee1 Bug-Url: https://bugzilla.redhat.com/1168334 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4ae30f62c5bcd6793e19c8be6806f32bf68eee1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0