Change in ovirt-engine[master]: core: backup awareness, full backup check
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: backup awareness, full backup check
......................................................................
core: backup awareness, full backup check
This patch changes the backup awareness logic as follows:
We will check only for FULL backup , a full backup contains 'db' and
'files' as scope
If one of 'db' or 'files' is missing or both we will generate NO BACKUP
alert
If two exists but at least one is OLD we will generate an alert with the
oldest date
Change-Id: I71a8b2b4278db039518f7bfc9b684f390ca449fe
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/audit_log_sp.sql
M packaging/dbscripts/engine_backup_log_sp.sql
6 files changed, 40 insertions(+), 14 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40543
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71a8b2b4278db039518f7bfc9b684f390ca449fe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: host-deploy: Remove unreachable deploy status
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: host-deploy: Remove unreachable deploy status
......................................................................
host-deploy: Remove unreachable deploy status
Termination of oVirt-node installation might end
either by installation failure (InstallFailed) or
by rebooting the node (Reboot) in case of a successful
installation.
Change-Id: I21c43254fb969f69bafca65730eab659d068cbb6
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommand.java
2 files changed, 2 insertions(+), 9 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/40561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21c43254fb969f69bafca65730eab659d068cbb6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: webadmin: do not persist RunOnce boot sequence accidentally
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: webadmin: do not persist RunOnce boot sequence accidentally
......................................................................
webadmin: do not persist RunOnce boot sequence accidentally
VmDeviceCommonUtils.updateVmDevicesBootOrder() method was using RunOnce
boot sequence if vm.isRunOnce() is true. When called from
VmDeviceUtils.updateBootOrderInVmDeviceAndStoreToDB() this caused
RunOnce boot sequence to be persisted when attaching/detaching disks,
adding/removing NICs etc.
Do avoid this undesired behavior,
VmDeviceCommonUtils.updateVmDevicesBootOrder() is no more using RunOnce
boot sequence. The RunOnce boot sequence is passed to it only from
VmInfoBuilder.buildVmBootSequence() that is called when VM is started.
The result is used to boot the VM and never persisted.
Note that VmDynamic.bootSequence is still persisted, this is done in
another place.
Change-Id: Ibfa685f8d81b67eff41234a450185879f5bbccfd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209038
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
3 files changed, 29 insertions(+), 9 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfa685f8d81b67eff41234a450185879f5bbccfd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-release[master]: add missing dependency for ovirt-optimizer
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: add missing dependency for ovirt-optimizer
......................................................................
add missing dependency for ovirt-optimizer
add missing dep for ovirt-optimizer from epel repo.
Change-Id: I04b4e7dbb14dec48e5c7129c49cce79073276cd9
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-release-3.6/ovirt-el7-deps.repo.in
M ovirt-release-master/ovirt-el7-deps.repo.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04b4e7dbb14dec48e5c7129c49cce79073276cd9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: multiple login messages
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: userportal,webadmin: multiple login messages
......................................................................
userportal,webadmin: multiple login messages
- When the backend would return multiple login failure
messages (for instance with the password expired). All
messages after the first would be discarded. This would
lead to configured messages to not be displayed.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157773
Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginFormView.ui.xml
7 files changed, 115 insertions(+), 86 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.2]: build: ovirt-engine-3.5.2.1
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.5.2.1
......................................................................
build: ovirt-engine-3.5.2.1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219038
Change-Id: Ia88df0820478050e7645a1d0c116de5f5f0c9f00
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M backend/manager/dependencies/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M ovirt-engine.spec.in
M pom.xml
M version.mak
51 files changed, 53 insertions(+), 50 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia88df0820478050e7645a1d0c116de5f5f0c9f00
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[master]: packaging: setup: creating fn_db_unlock_all before executing
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: creating fn_db_unlock_all before executing
......................................................................
packaging: setup: creating fn_db_unlock_all before executing
fn_db_unlock_all stored procedure was not available on 3.5
Creating it before executing to unlock every entity also
upgrading from 3.5.z to 3.6
Change-Id: I3d43e5d27654916aa440a2405c6f4474e49c9590
Bug-Url: https://bugzilla.redhat.com/1204673
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/dbutils/unlock_entity.sh
A packaging/setup/dbutils/unlock_entity.sql
2 files changed, 35 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40081
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d43e5d27654916aa440a2405c6f4474e49c9590
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.2]: core: Add OVF_STORE disks registration on Data Center initia...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add OVF_STORE disks registration on Data Center initialization
......................................................................
core: Add OVF_STORE disks registration on Data Center initialization
Add existing OVF_STORE disks to Storage Domains which are registered to
the Data Center
Change-Id: I9a6dd41c220dd1e91c458e0af5a600860a3ae466
Bug-Url: https://bugzilla.redhat.com/1217339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/40595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a6dd41c220dd1e91c458e0af5a600860a3ae466
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.2]: core: Refactor register of OVF_STORE disks
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Refactor register of OVF_STORE disks
......................................................................
core: Refactor register of OVF_STORE disks
Refactor the OVF_STORE disks' registration on attach Storage Domain
process, by moving the code to StorageHandlingCommandBase,
so it can be used also for initializing a new Data Center.
Change-Id: I0d24f059c0073d8744b46b0d0697e323f63ce119
Bug-Url: https://bugzilla.redhat.com/1217339
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java
3 files changed, 236 insertions(+), 55 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/40594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d24f059c0073d8744b46b0d0697e323f63ce119
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5.3]: core: Check attached VMs snapshot preview only status when m...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Check attached VMs snapshot preview only status when moving a disk
......................................................................
core: Check attached VMs snapshot preview only status when moving a disk
Change-Id: Ibe4de57b5e0dabcb28320a305dd32bbfb705a623
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1211330
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40600
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe4de57b5e0dabcb28320a305dd32bbfb705a623
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months