May 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : Math operations on SizeConverter converted sizes
by ofrenkel＠redhat.com 04 May '15

04 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine : Math operations on SizeConverter converted sizes ...................................................................... engine : Math operations on SizeConverter converted sizes Facilitate Math operations on SizeConverter converted sizes Change-Id: Ie9fd4e7b7b9411cf17d66037e6424a979c2d037f Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SizeConverterTest.java 2 files changed, 100 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve anmolbabu: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9fd4e7b7b9411cf17d66037e6424a979c2d037f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: setup: reconnect on connection refused
by sbonazzo＠redhat.com 04 May '15

04 May '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: reconnect on connection refused ...................................................................... setup: reconnect on connection refused reconnect on connection refused while starting the Hosted Engine VM. Added after seeing vdsm crashing after VM shutdown on master. Change-Id: I1d8825f0ee4aaf0a43bdabecd61c871c842e1bfb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 1 file changed, 69 insertions(+), 40 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d8825f0ee4aaf0a43bdabecd61c871c842e1bfb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix errors for retry of failed DestroyImageCommand
by tnisan＠redhat.com 03 May '15

03 May '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix errors for retry of failed DestroyImageCommand ...................................................................... core: Fix errors for retry of failed DestroyImageCommand Fix issues encountered while re-executing Live Merge after a failure of DestroyImageCommand: 1. Some images may have been marked illegal from a prior failure; this is an expected condition so allow live merge execution in this case. 2. The endSuccessfully and endWithFailure methods should always indicate their own success using setSucceeded(true) to avoid endAction retries. 3. If the DestroyImage SPM async task was started and converged before CoCo called doPolling() again on RemoveSnapshotSingleDiskLive, the child command list was not updated. Subsequently the end action methods were not able to call endAction on DestroyImageCommand and no commands in the Live Merge command tree would converge. This is fixed by updating the child command list before referencing it to ensure all children are present. Change-Id: Icbbcc30fa035de82de05c5c60ce224ed36aee831 Related-To: https://bugzilla.redhat.com/1213157 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 38 insertions(+), 21 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbbcc30fa035de82de05c5c60ce224ed36aee831 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Reset OVF_STORE disks list
by mlipchuk＠redhat.com 03 May '15

03 May '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Reset OVF_STORE disks list ...................................................................... core: Reset OVF_STORE disks list several Storage Domains can be attached to the Data Center once it is being initilaized. before each Storage Domain we should reset the OVF_STORE disk list. Change-Id: I32cdc3e3a1dcf84a621ee305e2353d4be6074383 Bug-Url: https://bugzilla.redhat.com/1214408 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32cdc3e3a1dcf84a621ee305e2353d4be6074383 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Adding error log for image validation.
by mlipchuk＠redhat.com 03 May '15

03 May '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding error log for image validation. ...................................................................... core: Adding error log for image validation. Adding error log to indicate more details about the disk and Storage Domain which could not be found to validate disk once importing an unregistered VM. Change-Id: I9b1787641622b6d430b8b06775a335b912a7798f Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b1787641622b6d430b8b06775a335b912a7798f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Truncate percentage in case NIC speed is too low
by lvernia＠redhat.com 03 May '15

03 May '15

Lior Vernia has submitted this change and it was merged. Change subject: engine: Truncate percentage in case NIC speed is too low ...................................................................... engine: Truncate percentage in case NIC speed is too low Reported NIC speed may be lower than it effectively is, in which case we supposedly wouldn't want to display utilisation percentage higher than 100%. Change-Id: I83bd4d642e93af312d65fefc4417eeccc88bc9dc Bug-Url: https://bugzilla.redhat.com/1118699 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkStatisticsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 26 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83bd4d642e93af312d65fefc4417eeccc88bc9dc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Allow empty Host Network QoS override
by lvernia＠redhat.com 03 May '15

03 May '15

Lior Vernia has submitted this change and it was merged. Change subject: engine: Allow empty Host Network QoS override ...................................................................... engine: Allow empty Host Network QoS override Allow overriding Host Network QoS with all null values, and have that translate to no QoS configuration. This is needed to move a host to an older cluster without affecting the QoS setting for the entire network. Change-Id: Iaddd2738a2db0666a07c6db9db23d4fe4572816f Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/EditHostNetworkQosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/NewHostNetworkQosModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/SharedHostNetworkQosParametersModel.java 8 files changed, 46 insertions(+), 15 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaddd2738a2db0666a07c6db9db23d4fe4572816f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix errors for retry of failed DestroyImageCommand
by amureini＠redhat.com 03 May '15

03 May '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix errors for retry of failed DestroyImageCommand ...................................................................... core: Fix errors for retry of failed DestroyImageCommand Fix issues encountered while re-executing Live Merge after a failure of DestroyImageCommand: 1. Some images may have been marked illegal from a prior failure; this is an expected condition so allow live merge execution in this case. 2. The endSuccessfully and endWithFailure methods should always indicate their own success using setSucceeded(true) to avoid endAction retries. 3. If the DestroyImage SPM async task was started and converged before CoCo called doPolling() again on RemoveSnapshotSingleDiskLive, the child command list was not updated. Subsequently the end action methods were not able to call endAction on DestroyImageCommand and no commands in the Live Merge command tree would converge. This is fixed by updating the child command list before referencing it to ensure all children are present. Change-Id: Icbbcc30fa035de82de05c5c60ce224ed36aee831 Related-To: https://bugzilla.redhat.com/1213157 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 38 insertions(+), 21 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbbcc30fa035de82de05c5c60ce224ed36aee831 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix the description of the osinfo syntax
by ofrenkel＠redhat.com 03 May '15

03 May '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix the description of the osinfo syntax ...................................................................... core: fix the description of the osinfo syntax Fixed small mistake in the description of the versions Change-Id: Ie73088c82a1d0099c93e3ec4419782ef97d2e039 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie73088c82a1d0099c93e3ec4419782ef97d2e039 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0