Change in ovirt-engine[master]: core: add UnregisterLibvritVdsCommand
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: add UnregisterLibvritVdsCommand
......................................................................
core: add UnregisterLibvritVdsCommand
Adding UnregisterLibvirtSecretsVDSCommand and integrate
with vdsm's unregisterSecrets api.
Change-Id: Ib27ca3e5fb5a8402650c28baf650c7d3ae7a3226
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UnregisterLibvirtSecretsVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UnregisterLibvirtSecretsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
11 files changed, 92 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/41559
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib27ca3e5fb5a8402650c28baf650c7d3ae7a3226
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: unregister secrets on DisconnectHostFromStoragePoolSer...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: unregister secrets on DisconnectHostFromStoragePoolServersCommand
......................................................................
core: unregister secrets on DisconnectHostFromStoragePoolServersCommand
Invoke UnregisterLibvirtSecrets command on
DisconnectHostFromStoragePoolServersCommand in order to ensure all secrets
are unregistered when an host is moved to maintenance status.
Change-Id: Ibe60afa5f0581018338cc32f5534dc908821b566
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
Objections:
Jenkins CI: I would prefer that you didn't submit this
--
To view, visit https://gerrit.ovirt.org/41565
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe60afa5f0581018338cc32f5534dc908821b566
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: register secrets on connect storage domain
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: register secrets on connect storage domain
......................................................................
core: register secrets on connect storage domain
Invoke RegisterLibvirtSecrets command on all hosts
upon Cinder storage domain activation.
Change-Id: I832147a33183139ade488e161b496858413d43f5
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 64 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41558
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I832147a33183139ade488e161b496858413d43f5
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: register secrets on ConnectHostToStoragePoolServersCom...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: register secrets on ConnectHostToStoragePoolServersCommand
......................................................................
core: register secrets on ConnectHostToStoragePoolServersCommand
Invoke RegisterLibvirtSecrets command on ConnectHostToStoragePoolServersCommand
in order to ensure relevant secrets are registered
when an host is moved to active status.
Change-Id: I64bdeae25b6e4317c8b824fc7df3306e90225585
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RegisterLibvirtSecretsVDSParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RegisterLibvirtSecretsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
11 files changed, 64 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/41564
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64bdeae25b6e4317c8b824fc7df3306e90225585
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Add disk alias to "Scan Alignment" error message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add disk alias to "Scan Alignment" error message
......................................................................
core: Add disk alias to "Scan Alignment" error message
When running "Scan Alignment" on a disk based on a file storage, the
error message that is showing up doesn't contain the disk's alias like
error messages for other failure reasons of the command.
This patch adds this error message the disk's alias.
Change-Id: Ibfc66dd3b7264ff7b8e5136c7e7d5694e3f501df
Bug-Url: https://bugzilla.redhat.com/1142781
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/42483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfc66dd3b7264ff7b8e5136c7e7d5694e3f501df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: Size info in GB along side % (2)
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Size info in GB along side % (2)
......................................................................
webadmin: Size info in GB along side % (2)
In Edit Storage Domain popup view, there's a percentage threshold. Add to it
the information in GB, out of the storage's total size.
Change-Id: Ib3c3e0108086ae528cc856d6e4183177ef6d2cb4
Bug-Url: https://bugzilla.redhat.com/1213134
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml
5 files changed, 75 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/41936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3c3e0108086ae528cc856d6e4183177ef6d2cb4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: db: Remove RenameManagementNetwork stored procedure
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: db: Remove RenameManagementNetwork stored procedure
......................................................................
db: Remove RenameManagementNetwork stored procedure
This stored procedure is no longer necessary and used by the
RHEVM setup plugins, since we're going now to align the naming
of the bridge with the upstream naming
Change-Id: I1328f4ad8e359e411f4474f68cee36556a127c69
Bug-URL: https://bugzilla.redhat.com/1204793
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M packaging/dbscripts/network_sp.sql
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Vinzenz Feenstra: Verified
Moti Asayag: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1328f4ad8e359e411f4474f68cee36556a127c69
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: cleanup in EventVmStatsRefresher
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in EventVmStatsRefresher
......................................................................
core: cleanup in EventVmStatsRefresher
1. The VM that is being created in createVmInternalData is based on the
VM from the DB, so no need to set its id.
2. The status field was set twice, removed one.
3. No need to keep backward compatibility with previous versions of VDSM
when using events, thus not set 'unknown' reason state as default.
Change-Id: I8d829cda50428e2f6f2d74ae3aaa7ec83978476d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/42465
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d829cda50428e2f6f2d74ae3aaa7ec83978476d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-hosted-engine-setup[master]: packaging: setup: improoving cloud-init config UX
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: improoving cloud-init config UX
......................................................................
packaging: setup: improoving cloud-init config UX
- asking about appliance location just after disk/cdrom/pxe
- asking about appliance root password only if generating
cloud-init ISO
- adding a warning if the user is not configuring the
appliance root password (there is no default one!)
- using an empty string to indicate that the user
doesn't want to set the appliance root password
(there is a bug in otopi which suddenly stops logging
if we try to filter a boolean value but we don't want
to fix it)
Change-Id: I8fc500e6324a81414e2a18047045ee0b4e3ff5e0
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
2 files changed, 64 insertions(+), 38 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc500e6324a81414e2a18047045ee0b4e3ff5e0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: packaging: setup: adding DOCKERC_NEEDED
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: adding DOCKERC_NEEDED
......................................................................
packaging: setup: adding DOCKERC_NEEDED
Adding DOCKERC_NEEDED to enable dockerc related code under
engine-common only if really needed
Change-Id: I587c403072a4c2b690ed8fdadbfb386dbdde829f
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/dockerc/constants.py
M packaging/setup/plugins/ovirt-engine-common/dockerc/core.py
M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py
M packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py
4 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I587c403072a4c2b690ed8fdadbfb386dbdde829f
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months