June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VmIcons DAO for the REST part
by ofrenkel＠redhat.com 16 Jun '15

16 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: VmIcons DAO for the REST part ...................................................................... core: VmIcons DAO for the REST part DAO methods necessary for efficient implementation of Vm Icons REST interface. Change-Id: I765eafe88cbb6f9d0c0fb8019970a6c7134ceddd Bug-Url: https://bugzilla.redhat.com/1103175 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDefaultDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDefaultDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmIconDefaultDaoTest.java M packaging/dbscripts/vm_icons_sp.sql 7 files changed, 70 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I765eafe88cbb6f9d0c0fb8019970a6c7134ceddd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-host-deploy[master]: build: remove unneeded autogen.sh
by Alon Bar-Lev 16 Jun '15

16 Jun '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: remove unneeded autogen.sh ...................................................................... build: remove unneeded autogen.sh Change-Id: I9508f49b6f44be6bb72e3d708c468defd38362ad Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am D autogen.sh 2 files changed, 0 insertions(+), 30 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9508f49b6f44be6bb72e3d708c468defd38362ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: build: remove unneeded autogen.sh
by Alon Bar-Lev 16 Jun '15

16 Jun '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: remove unneeded autogen.sh ...................................................................... build: remove unneeded autogen.sh Change-Id: I9f1059d9e7bc4e036f9f5e68ab18cede20e3bf7c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am D autogen.sh 2 files changed, 0 insertions(+), 30 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved Jenkins CI: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f1059d9e7bc4e036f9f5e68ab18cede20e3bf7c Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: SPICE copyPaste/fileTransfer not passed properly
by tjelinek＠redhat.com 16 Jun '15

16 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core: SPICE copyPaste/fileTransfer not passed properly ...................................................................... core: SPICE copyPaste/fileTransfer not passed properly The problem was that the VmInfoBuilderBase checked if the SPICE device is there according to the graphicsInfo. The problem was that the graphicsInfo is a dynamic attribute containing things like IP, port etc which exists only after the VM has been created - here we are just creating it so it does not yet exist. Fixed by creating this information in the RunVm and RunVmOnce commands according to the DB value/parameters passed Change-Id: Ic09709b579fd3e2fe622790f66286537ad01e728 Bug-Url: https://bugzilla.redhat.com/983019 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 2 files changed, 23 insertions(+), 20 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic09709b579fd3e2fe622790f66286537ad01e728 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: events: removing vm.getStats from event processing
by ofrenkel＠redhat.com 16 Jun '15

16 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: events: removing vm.getStats from event processing ...................................................................... events: removing vm.getStats from event processing Instead of having additional call to fetch vm stats we decided to incorporate more information to status change event. Now event contains status (recently changed), statusTime (time when status was sent), hash and when status changes to "Down" we provide exit_code, exit_message and exit_reason. Change-Id: Ib15df9ce78bbb86c9284bdd6b772d0e6801db765 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 10 files changed, 217 insertions(+), 57 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib15df9ce78bbb86c9284bdd6b772d0e6801db765 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine, backend: enable vmconsole in host deploy
by ofrenkel＠redhat.com 16 Jun '15

16 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: engine, backend: enable vmconsole in host deploy ...................................................................... engine, backend: enable vmconsole in host deploy Add glue code to enable the Serial Console in host deploy. Feature wiki page: http://www.ovirt.org/Features/Serial_Console Bug-Url: https://bugzilla.redhat.com/1223671 Signed-off-by: Francesco Romani <fromani(a)redhat.com> Change-Id: Icb0503507d3a03789f1f14d3e95c17d121a60c59 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Looks good to me, but someone else must approve Francesco Romani: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb0503507d3a03789f1f14d3e95c17d121a60c59 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: hostdeploy: fix findbugs
by ofrenkel＠redhat.com 16 Jun '15

16 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: hostdeploy: fix findbugs ...................................................................... hostdeploy: fix findbugs Fixes DLS_DEAD_LOCAL_STORE, which is pretty harmless anyway. Change-Id: I5a44be674d96256121c7f3d09ab0996ccd6bfb3e Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a44be674d96256121c7f3d09ab0996ccd6bfb3e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: events: VM Status based on an event
by ahadas＠redhat.com 16 Jun '15

16 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: events: VM Status based on an event ...................................................................... events: VM Status based on an event Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 9 files changed, 179 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: events: vm stats refresher refactoring
by ahadas＠redhat.com 16 Jun '15

16 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: events: vm stats refresher refactoring ...................................................................... events: vm stats refresher refactoring Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VMStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 4 files changed, 132 insertions(+), 36 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40139f9c90bd9ceeb297adf9f8bd3ab7f9113930 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: it is possible to attach the same disk twice
by tjelinek＠redhat.com 16 Jun '15

16 Jun '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: it is possible to attach the same disk twice ...................................................................... webadmin: it is possible to attach the same disk twice Problem happend in the "instance image flow" only. The problem was that the disks which can not be attached (e.g. the ones already attached) were returned only from server. But in the instance image flow the disks are first configured in the new/edit vm dialog and than submitted at once. Fixed by removing the this disks from the list of disks to be attached. Change-Id: I3eb3b0608e957c88c98c264e87dbb651b179c8e3 Bug-Url: https://bugzilla.redhat.com/1228975 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesAttachDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 3 files changed, 63 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eb3b0608e957c88c98c264e87dbb651b179c8e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0