Change in ovirt-engine[master]: restapi: Move Vnic-Profile remove to entity
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Move Vnic-Profile remove to entity
......................................................................
restapi: Move Vnic-Profile remove to entity
This patch moves the method that implements the DELETE operation
from the collection interface to the entity interface.
This is needed to avoid issues with newer versions of Resteasy.
Change-Id: Ic603af4dbe08cec8e4487f44e2a8aa513d51cb59
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedVnicProfileResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedVnicProfilesResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VnicProfileResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VnicProfilesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfileResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedVnicProfileResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVnicProfileResourceTest.java
10 files changed, 142 insertions(+), 94 deletions(-)
Approvals:
Ori Liel: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic603af4dbe08cec8e4487f44e2a8aa513d51cb59
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: backend: Parse 'hostdevPassthrough' host capability
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: backend: Parse 'hostdevPassthrough' host capability
......................................................................
backend: Parse 'hostdevPassthrough' host capability
Added new host field to track whether the device passthrough is
configured at the given host.
Change-Id: Id81e298f47f33ddcafafdd3787ce991b4ff8d2f1
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_1530_add_host_passthrough_flag.sql
M packaging/dbscripts/vds_sp.sql
10 files changed, 46 insertions(+), 9 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Verified; Looks good to me, but someone else must approve
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id81e298f47f33ddcafafdd3787ce991b4ff8d2f1
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: check hosts statuses to determine the data center status
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: check hosts statuses to determine the data center status
......................................................................
core: check hosts statuses to determine the data center status
On data centers with SPM, the status of the data center was decided
according to the SPM status. On data center without SPM we need to
decide on that based on whether there are reporting hosts or not.
Change-Id: I36dcbb410784f589b2f333c731aecd46ce479ab8
Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
3 files changed, 30 insertions(+), 13 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41685
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36dcbb410784f589b2f333c731aecd46ce479ab8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Fix cascade delete with Job/Step
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fix cascade delete with Job/Step
......................................................................
core: Fix cascade delete with Job/Step
Job/Step had an incorrect behavior of cascade delete, causing exception to be thrown.
This patch aims to fix it.
Change-Id: I53021c91c138059816e58c4f25bb2851f6c29800
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobsByCorrelationIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
7 files changed, 9 insertions(+), 50 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Liran Zelkha: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41912
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53021c91c138059816e58c4f25bb2851f6c29800
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: add support for power8e cpu
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add support for power8e cpu
......................................................................
core: add support for power8e cpu
Change-Id: Ife78aa7a7bf22007672c16aa0f84d943d0336934
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42131
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife78aa7a7bf22007672c16aa0f84d943d0336934
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: backend: Added missing mapping for Australia/Darwin
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Added missing mapping for Australia/Darwin
......................................................................
backend: Added missing mapping for Australia/Darwin
Change-Id: I673e099a61d8e9e63e1bb380a19446c0edf2daa6
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Vinzenz Feenstra: Verified
Martin Betak: Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I673e099a61d8e9e63e1bb380a19446c0edf2daa6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: packaging: setup: Small fix for queryPassword
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Small fix for queryPassword
......................................................................
packaging: setup: Small fix for queryPassword
Use the tests param.
Also fix doctext of queryEnvKey.
Change-Id: I8f07bd91c882821c08fd83bd1cd1bd9baf0898e3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/dialog.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Verified; Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/42161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f07bd91c882821c08fd83bd1cd1bd9baf0898e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: introduce DiskContentType
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: introduce DiskContentType
......................................................................
core: introduce DiskContentType
Generalize the ovf-store into a content-type of disk. Ovf-store is just
one example for a case where decisions are taken according to the type
of the content that is stored inside a disk. Another example would be
memory dump. So this patch replaces the ovf-store specific fields with
an enum that reflects the type of the content inside a disk.
Change-Id: I410a346cf0be32a99e10e503c26eb29b3688e748
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskContentType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
7 files changed, 29 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, but someone else must approve
Arik Hadas: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39143
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I410a346cf0be32a99e10e503c26eb29b3688e748
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: adding DataCenterWithoutSpm config value
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: adding DataCenterWithoutSpm config value
......................................................................
core: adding DataCenterWithoutSpm config value
Change-Id: I2dd88f249cd90f1cb7ef95a3f3bf8cf821921cf1
Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dd88f249cd90f1cb7ef95a3f3bf8cf821921cf1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: offering files of unknown type as candidates for k...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: offering files of unknown type as candidates for kernel and initrd images
......................................................................
webadmin: offering files of unknown type as candidates for kernel and initrd images
• to keep things simple, when refreshing list of images, ALL type is
used to refresh all files (since there's no way how to tell vdsm
'refresh all files but ...'), but only images of type UNKNOWN are
presented to the user, since there's not specific type for kernel
initrd images and we know, that we do not want to offer them iso's,
floppies, or others. To do that,
RepoImageToImageFileNameAsyncConverter converter callback was altered
to allow filtering. Subclass used for obtaining images of UNKNOWN type
then can query all and filter unwanted by that type.
• when passing image name back to backend, it must start with prefix
'iso://' otherwise root of iso domain for given data-center won't be
added before selected filename. To do that,
RepoImageToImageFileNameAsyncConverter converter callback was altered
to provide overridable method for converting each record, and subclass
of this callback used for obtaining images of UNKNOWN type prepends
"iso://" prefix to image name. That way, all images in comboboxes
starts with 'iso://', which may seem ackward at first, but it offers
clear distinction, that this is the image from iso domain
Note: technically run once dialog coud use only one call to get all
images, categorize them by type and use where approriate, instead of
current three calls, and refreshed could refresh files of specific
type(when type's known) or all files (where it's unknown), but that
would be harder to implement in given time window, so easier solution
was selected.
Bug-Url: https://bugzilla.redhat.com/1200952
Change-Id: Ic5ce60fb187fbfd6efe1b6e497f21157bd7a9484
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
4 files changed, 184 insertions(+), 79 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Mucha: Verified
--
To view, visit https://gerrit.ovirt.org/41358
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5ce60fb187fbfd6efe1b6e497f21157bd7a9484
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months