June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: storage main tab 500
by awels＠redhat.com 09 Jun '15

09 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: storage main tab 500 ...................................................................... webadmin: storage main tab 500 - Due to the hibernate collection to java collection conversion the getWarningLowSpaceSize method was being called while some of the information was missing causing null pointer exceptions. This patch fixed that problem. Change-Id: Iaf6fe9c3e5c83944753eb16b750a565f1f110572 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf6fe9c3e5c83944753eb16b750a565f1f110572 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix sorting issue with new grouped list box
by awels＠redhat.com 09 Jun '15

09 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix sorting issue with new grouped list box ...................................................................... webadmin: Fix sorting issue with new grouped list box - Fixed issue where items were being added to the underlying list box and then sorted in the display in a different order. This caused the wrong selected item to be used during save. Change-Id: I521c1ac3eaf0dc1dbc78acddd7301ab3dc4f1490 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Verified; Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521c1ac3eaf0dc1dbc78acddd7301ab3dc4f1490 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce convert vm command
by ahadas＠redhat.com 09 Jun '15

09 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce convert vm command ...................................................................... core: introduce convert vm command This patch introduces ConvertVmCommand which converts a virtual machine from an external provider. This command should be executed using the command-coordination framework and it assumes the job is reported by VDSM in vds-statistics. Change-Id: I7bc67ff237d5c01fc5f3c9f21c822573e5db32a3 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCallback.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConvertVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConvertVmVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConvertVmVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DeleteV2VJobVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetConvertedOvfVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OvfReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 21 files changed, 793 insertions(+), 0 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/33055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bc67ff237d5c01fc5f3c9f21c822573e5db32a3 Gerrit-PatchSet: 100 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Re-extract diskImageDynamic BaseImagesCommand
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Re-extract diskImageDynamic BaseImagesCommand ...................................................................... core: Re-extract diskImageDynamic BaseImagesCommand Re-extract code for DiskImageDynamic from addDiskImageToDb to be used in a seperate dedicated method. Change-Id: I458db364b5332450ad5e2f252d274a9cd565239e Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I458db364b5332450ad5e2f252d274a9cd565239e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add parentHasTasks to ImagesContainterParametersBase
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add parentHasTasks to ImagesContainterParametersBase ...................................................................... core: Add parentHasTasks to ImagesContainterParametersBase Add parentHasTasks flag to indicate if we have VDSM tasks, engine should wait for when finishing creating the snapshot. Change-Id: Id4e1172f429086465d993079ca8bd307591b8c32 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e1172f429086465d993079ca8bd307591b8c32 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Refactor addDiskImageToDb to use active flag
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Refactor addDiskImageToDb to use active flag ...................................................................... core: Refactor addDiskImageToDb to use active flag Refactor the existing method addDiskImageToDb to use the active flag as an argument in the method API, since with Cinder the volume for a snapshot might not be always true. Change-Id: Ie77b70d83c7436533c7e62ea56fe52eaa67d2366 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/41818 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie77b70d83c7436533c7e62ea56fe52eaa67d2366 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove redundant method in CreateSnapshotCommand.
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant method in CreateSnapshotCommand. ...................................................................... core: Remove redundant method in CreateSnapshotCommand. The validation if a VM is not during snapshot is already being done at CreateAllSnapshotsCommand, Change-Id: Ie0ae57eac69d502182fa40a2968926ba289f27ad Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 2 files changed, 12 insertions(+), 31 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0ae57eac69d502182fa40a2968926ba289f27ad Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Filter in Cinder disks to be used for snapshots
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Filter in Cinder disks to be used for snapshots ...................................................................... core: Filter in Cinder disks to be used for snapshots Unfilter Cinder disks when creating a snapshot. Change-Id: I7949ecb3ef9c5fef90ef300182718c4b4f05e967 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 22 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/40974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7949ecb3ef9c5fef90ef300182718c4b4f05e967 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove filter for Cinder disk when creating a snapshot.
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove filter for Cinder disk when creating a snapshot. ...................................................................... core: Remove filter for Cinder disk when creating a snapshot. don't filter out cinder disks for snapshot Change-Id: I0f97720fc77e56d4a7b8dee8e18b6e04040f7635 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderDisk.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f97720fc77e56d4a7b8dee8e18b6e04040f7635 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce volume classification enum
by mlipchuk＠redhat.com 09 Jun '15

09 Jun '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce volume classification enum ...................................................................... core: Introduce volume classification enum Introduce volume classification enum to determined if a Cinder disk is volume or snapshot when deleting it. Change-Id: I6f74be35f5ea89c1073fac5769d95bc2befe58c3 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/VolumeClassification.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 4 files changed, 46 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f74be35f5ea89c1073fac5769d95bc2befe58c3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0