Change in ovirt-hosted-engine-setup[master]: packaging: setup: let the user configure engine VM networking
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: let the user configure engine VM networking
......................................................................
packaging: setup: let the user configure engine VM networking
Let the user specify a static configuration for the engine VM
network configuration.
The configuration will be applyed via cloud-init.
Change-Id: Ic09f4d92e44f1bf810f06ada703e533b8c5e2061
Bug-Url: https://bugzilla.redhat.com/1223801
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/util.py
M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
M src/plugins/ovirt-hosted-engine-setup/engine/fqdn.py
M src/plugins/ovirt-hosted-engine-setup/engine/health.py
M src/plugins/ovirt-hosted-engine-setup/network/gateway.py
M src/plugins/ovirt-hosted-engine-setup/vm/boot_cdrom.py
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
9 files changed, 627 insertions(+), 121 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic09f4d92e44f1bf810f06ada703e533b8c5e2061
Gerrit-PatchSet: 30
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: webadmin: IVdcQueryable changes
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: IVdcQueryable changes
......................................................................
webadmin: IVdcQueryable changes
- The fix to the persistent bag implementation follows the
entire object tree and calls all the getters. This particular
object did not override the getQueryableId method which caused
an exception to occur.
- This patch changes the getQueryableId to be an interface and thus forces
all classes that used to extend it, to implement it instead, allowing a
different base class.
Change-Id: I91c8f0af966a0d4fcab7fa8afeb4dcb90b7fd36c
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapGroup.java
M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/DirectoryEntry.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineBackupLog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EngineSession.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Erratum.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdcQueryable.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IscsiBond.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OvfEntityData.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permission.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaStorage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaUsagePerUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaVdsGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserProfile.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserSession.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroupHostsAndVMs.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsNumaNode.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmGuestAgentInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWatchdog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/AuthzGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerService.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterService.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeOptionEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfig.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotSchedule.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalSubnet.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNicVfsConfig.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/pseudo/NetworkLabel.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/RepoImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcFault.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairQueryable.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonIVdcQueryableMixIn.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkStatisticsBuilderTest.java
72 files changed, 144 insertions(+), 121 deletions(-)
Approvals:
Alexander Wels: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91c8f0af966a0d4fcab7fa8afeb4dcb90b7fd36c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine-sdk[master]: sdk: Use alternative imports for Python 3
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Use alternative imports for Python 3
......................................................................
sdk: Use alternative imports for Python 3
This patch checks for import errors and tries to import alternative
modules that work with Python 3, in particular it tries the following
alternatives:
urlparse -> urllib.parse
UserDict -> collections.UserDict
thread -> _thread
Change-Id: I79748d9dac0961dc290e539ae9f8e555bcd0aa2a
Related: https://bugzilla.redhat.com/1096137
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/EntryPointHeadTemplate
M src/ovirtsdk/api.py
M src/ovirtsdk/utils/ordereddict.py
M src/ovirtsdk/utils/reflectionhelper.py
M src/ovirtsdk/utils/searchhelper.py
5 files changed, 31 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me; Ready for merge; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/41328
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79748d9dac0961dc290e539ae9f8e555bcd0aa2a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Georep sync fix deletion of sessions
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Georep sync fix deletion of sessions
......................................................................
engine: Georep sync fix deletion of sessions
When syncing georep sessions for a volume, sessions
from other volumes are wrongly removed.
Fixing this
Bug-Url: https://bugzilla.redhat.com/1224962
Change-Id: Ib45f071885caf17d1acbc87fde6590476d849dc7
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
1 file changed, 21 insertions(+), 10 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41963
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib45f071885caf17d1acbc87fde6590476d849dc7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Validate on network remove/modify
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Validate on network remove/modify
......................................................................
engine: Validate on network remove/modify
Validate that gluster bricks do not use the
network on modification of networks with
gluster role
Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744
Bug-Url: https://bugzilla.redhat.com/1222503
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 70 insertions(+), 1 deletion(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41930
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e1fb2a64e68d8b8e4574c8bf3ca0c8aeb03e744
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Hiding virt network fields in gluster mode
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Hiding virt network fields in gluster mode
......................................................................
webadmin: Hiding virt network fields in gluster mode
Hiding columns and fields not relevant in
gluster only mode of installation
Change-Id: If9380697adc0c6e1d698e7aacc1f9b47be0d3851
Bug-Url: https://bugzilla.redhat.com/1207947
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java
5 files changed, 44 insertions(+), 9 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41929
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9380697adc0c6e1d698e7aacc1f9b47be0d3851
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: VmDeviceUtils refactoring
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: VmDeviceUtils refactoring
......................................................................
core: VmDeviceUtils refactoring
* Extracted common actions performed on a device into separate methods;
* Unified naming scheme applied to all methods related to the same
device and all similar methods across the devices;
* Reordered methods to group related methods together.
* Given more meaningful names to some methods;
* Given meaningful names to methods' parameters and local variables;
* Simplified parameter lists of some methods;
* Removed redundant comments, corrected spelling in others and added doc
comments to methods.
Change-Id: Iffa1ae3176b4082ef3b96277f6ea351e82f3e613
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/smartcard/SmartcardSpecParams.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
25 files changed, 1,636 insertions(+), 1,082 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41620
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffa1ae3176b4082ef3b96277f6ea351e82f3e613
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: db: Fix size of guest memory information from INTEGER => BIGINT
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: db: Fix size of guest memory information from INTEGER => BIGINT
......................................................................
db: Fix size of guest memory information from INTEGER => BIGINT
When using the maximum supported amount of RAM for a VM this value
can overflow.
Change-Id: I88a5a0e73a1f41caabb1fa88e7fb140c651056db
Bug-Url: https://bugzilla.redhat.com/1024010
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_1480_change_guest_mem_free_to_bigint.sql
M packaging/dbscripts/vms_sp.sql
2 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a5a0e73a1f41caabb1fa88e7fb140c651056db
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: core: refactoring in import-vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: refactoring in import-vm
......................................................................
core: refactoring in import-vm
1. Add canDoAction that contains checks that should be common to all
import-vm operations in ImportVmCommandBase. Currently it only contains
the check for valid cluster
2. Move the validation of balloon device to ImportVmCommandBase as it
should be validated on all import-vm commands
3. As a first stage, we will not support to map different disks to
different storage domains, thus imageToDestinationDomainMap will not be
set in ImportVmCommandBase
4. Move the look-up of balloon device in a given devices collection to
VmDeviceCommonUtils instead of being in the import command.
Change-Id: If8f420419b2a0b5789e0337450fc3c5576bb2d8f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
3 files changed, 56 insertions(+), 48 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/32643
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8f420419b2a0b5789e0337450fc3c5576bb2d8f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-dwh[master]: history: change date format in aggregation
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: history: change date format in aggregation
......................................................................
history: change date format in aggregation
Format lastDayAggr and lastHourAggr timezones
in the aggregation queries, as digits and not as text.
Change-Id: Ic6cb94a248013b1bce8ee9ebd0bc0a2c91b7cbdd
Bug-Url:https://bugzilla.redhat.com/1164125
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/aggregationtodaily_3_6/AggregationToDaily.java
M etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_6/AggregationToHourly.java
M etl_export/src/ovirt_engine_dwh/configurationsync_3_6/ConfigurationSync.java
M etl_export/src/ovirt_engine_dwh/dailytimekeepingjob_3_6/DailyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/deletetimekeepingjob_3_6/DeleteTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/historydelete_3_6/HistoryDelete.java
M etl_export/src/ovirt_engine_dwh/hourlytimekeepingjob_3_6/HourlyTimeKeepingJob.java
M etl_export/src/ovirt_engine_dwh/parallelrun_3_6/ParallelRun.java
M etl_export/src/ovirt_engine_dwh/sampletimekeepingjob_3_6/SampleTimeKeepingJob.java
M etl_export/src/routines/RoutineHistoryETL.java
M tos_project/code/routines/RoutineHistoryETL_3.6.item
M tos_project/code/routines/RoutineHistoryETL_3.6.properties
M tos_project/process/AggregationToDaily_3.6.item
M tos_project/process/AggregationToDaily_3.6.properties
M tos_project/process/AggregationToHourly_3.6.item
M tos_project/process/AggregationToHourly_3.6.properties
M tos_project/process/ConfigurationSync_3.6.item
M tos_project/process/ConfigurationSync_3.6.properties
M tos_project/process/DailyTimeKeepingJob_3.6.item
M tos_project/process/DailyTimeKeepingJob_3.6.properties
M tos_project/process/DeleteTimeKeepingJob_3.6.item
M tos_project/process/DeleteTimeKeepingJob_3.6.properties
M tos_project/process/HistoryDelete_3.6.item
M tos_project/process/HistoryDelete_3.6.properties
M tos_project/process/HourlyTimeKeepingJob_3.6.item
M tos_project/process/HourlyTimeKeepingJob_3.6.properties
M tos_project/process/ParallelRun_3.6.item
M tos_project/process/ParallelRun_3.6.properties
M tos_project/process/SampleTimeKeepingJob_3.6.item
M tos_project/process/SampleTimeKeepingJob_3.6.properties
30 files changed, 1,012 insertions(+), 1,775 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6cb94a248013b1bce8ee9ebd0bc0a2c91b7cbdd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months