Change in ovirt-engine[master]: engine: Update specific fields in SetVdsStatusVDSCommand
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Update specific fields in SetVdsStatusVDSCommand
......................................................................
engine: Update specific fields in SetVdsStatusVDSCommand
The command should concern only about the host status and the
reason fields, and shouldn't update the entire host dynamic record
which lead to an unexpected result in certain flows, such described
in the bug.
Change-Id: I6322fc882eb85ceb143e6184a61428a7e4c0fb4d
Bug-Url: https://bugzilla.redhat.com/1213809
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M packaging/dbscripts/vds_sp.sql
7 files changed, 67 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me, but someone else must approve
Liran Zelkha: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6322fc882eb85ceb143e6184a61428a7e4c0fb4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5.3]: build: ovirt-engine-3.5.3.1-1
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.5.3.1-1
......................................................................
build: ovirt-engine-3.5.3.1-1
Change-Id: I9e04035f240be6921627f6dd9550d812959db1f6
Bug-Url: https://bugzilla.redhat.com/1198142
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
M version.mak
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41873
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e04035f240be6921627f6dd9550d812959db1f6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Disable pki renewal for 3.5
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: Disable pki renewal for 3.5
......................................................................
packaging: setup: Disable pki renewal for 3.5
Change-Id: Ib0de9b1f1c3aa3aa1f3d81d47a91d44f458e7192
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/41882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0de9b1f1c3aa3aa1f3d81d47a91d44f458e7192
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5.3]: packaging: setup: Disable pki renewal for 3.5
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: packaging: setup: Disable pki renewal for 3.5
......................................................................
packaging: setup: Disable pki renewal for 3.5
Change-Id: Ib0de9b1f1c3aa3aa1f3d81d47a91d44f458e7192
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41904
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0de9b1f1c3aa3aa1f3d81d47a91d44f458e7192
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: webadmin: combine datacenter/cluster in host popup
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: combine datacenter/cluster in host popup
......................................................................
webadmin: combine datacenter/cluster in host popup
- Combine datacenter and cluster into a single drop down.
- Removed population of partial cluster that would cause
equals of two logical equivalents to fail causing issues
for the drop down.
Change-Id: If42ada78c0b5e72509f0a5a6a5d8cfcefc3ed7d5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=865810
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBoxEditor.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
8 files changed, 337 insertions(+), 72 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41240
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If42ada78c0b5e72509f0a5a6a5d8cfcefc3ed7d5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: frontend: consider Everyone->diskProfileUser as basic user p...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: frontend: consider Everyone->diskProfileUser as basic user permission
......................................................................
frontend: consider Everyone->diskProfileUser as basic user permission
Similar to vnicProfileUser, an upgrade will make Everyone a
profileEditor or a diskProfileUser,
but that should not make them viewthe Extended User Portal.
Change-Id: I81bf88b7d4d0e16142dfad83b2e0d03039243a18
Bug-Url: https://bugzilla.redhat.com/1225274
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
2 files changed, 20 insertions(+), 19 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Daniel Erez: Looks good to me, but someone else must approve
Jenkins CI: Verified; Looks good to me, but someone else must approve
Roy Golan: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41834
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81bf88b7d4d0e16142dfad83b2e0d03039243a18
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in jenkins[master]: Adding a developer job for test enviroment
by tlitovsk＠redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: Adding a developer job for test enviroment
......................................................................
Adding a developer job for test enviroment
Change-Id: Ic8dcaeff22e28105ee5dd456e416fed548bc0621
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt/system-tests.yaml
M jobs/confs/yaml/templates/system_tests_templates.yaml
2 files changed, 86 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me; Passed CI tests
Anatoly Litovsky: Ready for merge
--
To view, visit https://gerrit.ovirt.org/41839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8dcaeff22e28105ee5dd456e416fed548bc0621
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
8 years, 11 months
Change in jenkins[master]: Adding a container based testenv job
by tlitovsk＠redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: Adding a container based testenv job
......................................................................
Adding a container based testenv job
Change-Id: Ifc2a0cc2dc61d7aba2888a11ea57ea8d0d8f3504
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
A jobs/confs/shell-scripts/system_tests_common_container.sh
R jobs/confs/shell-scripts/system_tests_common_std.sh
A jobs/confs/shell-scripts/system_tests_generate_scenario.sh
D jobs/confs/yaml/builders/system_tests.yaml
A jobs/confs/yaml/builders/system_tests_builders.yaml
M jobs/confs/yaml/jobs/ovirt/system-tests.yaml
R jobs/confs/yaml/templates/system_tests_templates.yaml
7 files changed, 249 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Verified; Looks good to me; Passed CI tests
Anatoly Litovsky: Ready for merge
--
To view, visit https://gerrit.ovirt.org/41833
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc2a0cc2dc61d7aba2888a11ea57ea8d0d8f3504
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
8 years, 11 months
Change in ovirt-engine[master]: restapi: Move Fence Agent remove from collection to entity
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Move Fence Agent remove from collection to entity
......................................................................
restapi: Move Fence Agent remove from collection to entity
This patch moves the method that implements the DELETE operation from
the collection interface to the entity interface. This is needed to
avoid issues with newer versions of Resteasy.
Change-Id: I1c71979e506d0ccbeded9f4182da31188e8980dc
Related: https://gerrit.ovirt.org/41783
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/FenceAgentResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/FenceAgentsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFenceAgentResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFenceAgentsResource.java
4 files changed, 25 insertions(+), 42 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c71979e506d0ccbeded9f4182da31188e8980dc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months
Change in ovirt-engine[master]: webadmin: disk permissions never loads
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: disk permissions never loads
......................................................................
webadmin: disk permissions never loads
- In commit d1060a824f1ea0b5a6efae486cad9ccbb6e6804a the type of the permissions
changed from DiskListModel to Disk, however the bound type of the interface
was never changed to match which caused the permissions to not be properly
passed to the sub tab presenter and thus the view. This patch matches the
interface to the correct type.
Change-Id: Ib583e92b4108081d65294e793637c7738e94cb08
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219396
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Verified; Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/41603
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib583e92b4108081d65294e793637c7738e94cb08
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 11 months