June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Source VM is deleted after failed cloning attempt
by ofrenkel＠redhat.com 28 Jun '15

28 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Source VM is deleted after failed cloning attempt ...................................................................... core: Source VM is deleted after failed cloning attempt The root cause was that in the rollback flow the VM id has been inited from the getParameters().getVmId() which points to the old VM. Than, in AddVmCommand.removeVmRelatedEntitiesFromDb() the removeVmStatic() used it to delete the VM - but since it pointed to the old VM it has been deleted. Fixed by making sure that the VM ID always points to the new VM. Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301 Bug-Url: https://bugzilla.redhat.com/1235179 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Handle null user when Adding VM internally
by tnisan＠redhat.com 28 Jun '15

28 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Handle null user when Adding VM internally ...................................................................... core: Handle null user when Adding VM internally a recent change to AddVm commands is making the current user and explicit owner. It didn't check the absent of a user in case of internal command, when adding external VMs and specially the Hosted Engine VM. Bug-Url: https://bugzilla.redhat.com/1236381 Change-Id: I64166c38930b79944b57abf4e7312d173b40bcfe Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64166c38930b79944b57abf4e7312d173b40bcfe Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Configure network on install with network attachments
by alkaplan＠redhat.com 28 Jun '15

28 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Configure network on install with network attachments ...................................................................... engine: Configure network on install with network attachments The host installation flow changed the network configuration from the deprecated setupnetworks command to the new setup networks which uses network attachments. Change-Id: I0bdf4ddec4be8ded779e6f5f711b90099dce4054 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java 1 file changed, 23 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/34972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bdf4ddec4be8ded779e6f5f711b90099dce4054 Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add network attachments queries
by alkaplan＠redhat.com 28 Jun '15

28 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add network attachments queries ...................................................................... engine: Add network attachments queries The queries will be used by the api to fetch the network attachments in the relevant context: host or nic. Change-Id: Iaf231d90d4599c0c79f908e6afd9549c176dad5e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostNicIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 4 files changed, 55 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Objections: Jenkins CI: Fails -- To view, visit https://gerrit.ovirt.org/33926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf231d90d4599c0c79f908e6afd9549c176dad5e Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add vmware providers
by ahadas＠redhat.com 28 Jun '15

28 Jun '15

Arik Hadas has submitted this change and it was merged. Change subject: core: add vmware providers ...................................................................... core: add vmware providers Add VMware as a new kind of external provider that provides VMs. Change-Id: I5e98983760ce875384ab00a06cacc455b19558b0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/VmwareVmProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmwareVmProviderProperties.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/providers_sp.sql A packaging/dbscripts/upgrade/03_06_1650_add_additional_properties_to_providers.sql 10 files changed, 218 insertions(+), 1 deletion(-) Approvals: Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/29379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e98983760ce875384ab00a06cacc455b19558b0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal: Make storage space config values available to user
by tnisan＠redhat.com 28 Jun '15

28 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal: Make storage space config values available to user ...................................................................... userportal: Make storage space config values available to user The configuration values of the storage space threshold were available only to an admin so when creating a disk in the userportal when the disk popup initialized those values came back as null causing an NPE thus not allowing the user to create/edit disks Change-Id: I3261bfd507c722840e02a655a9ba09bebcfbb30c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1234258 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3261bfd507c722840e02a655a9ba09bebcfbb30c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: DB: modify storage username field type
by amureini＠redhat.com 28 Jun '15

28 Jun '15

Allon Mureinik has submitted this change and it was merged. Change subject: packaging: DB: modify storage username field type ...................................................................... packaging: DB: modify storage username field type storage_server_connections table, user_name field type was modified from varchar to text, in order to support longer usernames, as supported by some of the storage appliances, i.e. 256 character long usernames, and software based solutions, i.e. 512 character long usernames. Note that generally CHAP RFC doesn't provide a limit on the length of the username. Change-Id: Ibb95cd5ce9bd623b765ab73b4fff7060a1d90b77 Bug-Url: https://bugzilla.redhat.com/1234100 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1640_change_storage_connections_user_name_type.sql 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb95cd5ce9bd623b765ab73b4fff7060a1d90b77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Introduce network attachments command
by alkaplan＠redhat.com 28 Jun '15

28 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce network attachments command ...................................................................... engine: Introduce network attachments command The Add/Update/Remove network attachments are added in order to support a solely network attachment action. Change-Id: I3c1b7a4e0b5ceacf6ea436c4ede84e414817dbdd Signed-off-by: Moti Asayag <masayag(a)redhat.com> Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddNetworkAttachmentCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveNetworkAttachmentCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkAttachmentCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/NetworkAttachmentParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkAttachmentParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 272 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/34971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c1b7a4e0b5ceacf6ea436c4ede84e414817dbdd Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Introduce HostSetupNetworks command
by alkaplan＠redhat.com 28 Jun '15

28 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce HostSetupNetworks command ...................................................................... engine: Introduce HostSetupNetworks command A replacement to the old SetupNetworkCommand which aims to behave as setupnetworks VDSM API compliant. Change-Id: I60077019f308f371f21fb7b5545ba48adb38bd06 Signed-off-by: Moti Asayag <masayag(a)redhat.com> Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserConfiguredNetworkData.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkInterfacesPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersister.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 1,337 insertions(+), 27 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/33333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60077019f308f371f21fb7b5545ba48adb38bd06 Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Dismissing alerts from context sometimes dismisses...
by oourfali＠redhat.com 28 Jun '15

28 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Dismissing alerts from context sometimes dismisses other aler ...................................................................... webadmin: Dismissing alerts from context sometimes dismisses other aler The alert that will be dismissed depends on current selected item in list model. However the right click (to invoke context menu) not always sets proper current selected item. Change-Id: Ie1643c9c33c2f13a616f85dfcdfc4c897a199ce0 Bug-Url: https://bugzilla.redhat.com/1224716 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42914 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1643c9c33c2f13a616f85dfcdfc4c897a199ce0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0