June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : add brick to geo-rep slave volume
by sabose＠redhat.com 25 Jun '15

25 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: engine : add brick to geo-rep slave volume ...................................................................... engine : add brick to geo-rep slave volume This patch handles brick addition to geo-rep slave volume. Change-Id: Id85cb7c3eb35ee84b4eb298cd20d9c657ed608d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1231176 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHostPubKeyToSlaveInternalCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/SetUpMountBrokerParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/SetUpPasswordLessSSHParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M packaging/dbscripts/gluster_georep_sp.sql 22 files changed, 516 insertions(+), 175 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85cb7c3eb35ee84b4eb298cd20d9c657ed608d3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin, engine : fix geo-rep issues
by sabose＠redhat.com 25 Jun '15

25 Jun '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin,engine : fix geo-rep issues ...................................................................... webadmin,engine : fix geo-rep issues This patch fixes the following: 1. Fix column width for long geo-rep config descriptions makes use of ScrollableTextCell. 2. Defaults use_meta_volume to false (changing the order of allowed options as false;true) so that when user wants to set it to true the change is detected by UI as an attempt to set/reset an option.UI assumes the selection to be the first element in list if explictly selectedItem is not passed This appears as supposed be UI fix. But, a. the configs are set as a list in the table So, conditional handling of only this element in list correspoding to the table might not be a better idea. 3. Refactored geo-rep crawl status enum as per current geo-rep session status o/p.Earlier cli used to return Changelog_Crawl and now its changed to Changelog Crawl. 4. Fix UI NPE in updating geo-rep config occuring during new changes detection.This started appearing after introducing the changes to the query to display even those configs that were not listed by cli as the user has no other option to set/ reset them. With this change in query the UI would catch NPE as the set of configs not shown by cli have null value against the config key and during comparison to detect change, NPE used to occur. 5. Fix availability of remove session when session is anything other than Stopped. 6. If the config is reset from cli or from engine, and sync of config is attempted, some of them don't appear in the config list(if the config doesn't have a value), such configs' value need to be reset from db as well. Change-Id: Ie0bb13c54649ce2980e15b36ed363161b8ab679e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232611 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233165 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1232699 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233171 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepCrawlStatus.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoReplicationSessionConfigPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeGeoRepSessionDetailsPopUpView.java A packaging/dbscripts/upgrade/03_05_1520_update_config_option.sql 9 files changed, 53 insertions(+), 24 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0bb13c54649ce2980e15b36ed363161b8ab679e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Test helper should compare correctly two nulls
by juan.hernandez＠redhat.com 25 Jun '15

25 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Test helper should compare correctly two nulls ...................................................................... restapi: Test helper should compare correctly two nulls Currently the method that is used to compare expected and actual arguments doesn't work correctly when cpmparing two new values, and it may throw a NPE. This patch avoids that NPE using the Objects.equals method. Change-Id: I22317f4dd1e5f81ce0b42db27c63b8689519e6e3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22317f4dd1e5f81ce0b42db27c63b8689519e6e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fence agents ui
by awels＠redhat.com 25 Jun '15

25 Jun '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fence agents ui ...................................................................... webadmin: fence agents ui - Updated fence agent UI to allow for more than 2 fence agents as well as concurrent fence agent groups. - Updated fence agent proxy ui to match new fence agent UI Change-Id: I4fbe6643bdb5277e978bfe37609c35ef0bf2ddc0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198628 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostFenceAgentPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostFenceAgentPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostFenceAgentPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/FenceAgentModelProvider.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentConcurrentWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentConcurrentWidget.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentWidget.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentsEditor.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentsEditor.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostProxySourceEditor.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostProxySourceEditor.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostProxySourceWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostProxySourceWidget.ui.xml 33 files changed, 2,850 insertions(+), 1,393 deletions(-) Approvals: Alexander Wels: Verified; Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fbe6643bdb5277e978bfe37609c35ef0bf2ddc0 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: renamed cryptic method names, added method for often u...
by alkaplan＠redhat.com 25 Jun '15

25 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: renamed cryptic method names, added method for often used code ...................................................................... core: renamed cryptic method names, added method for often used code renamed: ———————— //testing if interface is slave for some bond isBondSlave ——> isPartOfBond added: —————— //testing if interface is slave for certain bond specified by name isPartOfBond(String) //tests if interface is a bond isBond() Change-Id: Icbf4712fe6767ddf2a2abef4adc89ff223750f65 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 3 files changed, 12 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbf4712fe6767ddf2a2abef4adc89ff223750f65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: dont save vdsmVm to db
by ofrenkel＠redhat.com 25 Jun '15

25 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: dont save vdsmVm to db ...................................................................... core: dont save vdsmVm to db we should not save the vdsmVm to the db, as it doesnt contain the host-id that the vm runs on. also, it might initialize some information that exists in the db but not received from vdsm. changed prepareGuestAgentNetworkDevicesForUpdate method to use the right object (dbVm). Change-Id: Ie12c02f00eced21e4203235f29b94d62507bedc0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1230082 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie12c02f00eced21e4203235f29b94d62507bedc0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add host poller for setup network actions
by alkaplan＠redhat.com 25 Jun '15

25 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add host poller for setup network actions ...................................................................... engine: Add host poller for setup network actions The poller will monitor the connectivity to vdsm for the liveness of the engine-host communication. Change-Id: Ic11e71f0ee4e4ed4d6ae9a1d8fe4e5613da7a48f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved; Passed CI tests Jenkins CI: Verified -- To view, visit https://gerrit.ovirt.org/34970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic11e71f0ee4e4ed4d6ae9a1d8fe4e5613da7a48f Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Network attachments parameters completer
by alkaplan＠redhat.com 25 Jun '15

25 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Network attachments parameters completer ...................................................................... engine: Network attachments parameters completer The purpose of the class is to ensure partial entities provided by the clients is being populated if possible by the entity data as appeared on engine side. Change-Id: Ifdba99938f17db724e0c62c0780f7595619f2a9c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkAttachmentCompleter.java 1 file changed, 49 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Jenkins CI: Verified -- To view, visit https://gerrit.ovirt.org/33332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdba99938f17db724e0c62c0780f7595619f2a9c Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add HostInterfaceValidator
by alkaplan＠redhat.com 25 Jun '15

25 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add HostInterfaceValidator ...................................................................... engine: Add HostInterfaceValidator The validator validates the subject host interface is valid for certain operations. Change-Id: Iba235a70b0f42a75ca443b635c9eb51a4b2fee9a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 73 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/34969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba235a70b0f42a75ca443b635c9eb51a4b2fee9a Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add NetworkAttachmentsValidator
by alkaplan＠redhat.com 25 Jun '15

25 Jun '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add NetworkAttachmentsValidator ...................................................................... engine: Add NetworkAttachmentsValidator The validator is used to verify constraints on the entire destined network attachments. Change-Id: I92771cc35560ff4101231c3c7a40e6becbe3e8f2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 133 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/34968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92771cc35560ff4101231c3c7a40e6becbe3e8f2 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0