Change in ovirt-engine[master]: Revert "core: creating dbutils SPs in engine-setup"
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: Revert "core: creating dbutils SPs in engine-setup"
......................................................................
Revert "core: creating dbutils SPs in engine-setup"
This reverts commit cab81c95b17a3352b67ef05fb0237783cda42f15.
Due to
https://bugzilla.redhat.com/show_bug.cgi?id=1235707#c2
Solving that requires a change in dbscripts which is locked
Change-Id: I38ae2d0a739cb761b6e54d6f605c53ea76b023c4
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/setup/dbutils/fkvalidator.sh
R packaging/setup/dbutils/fkvalidator_sp.sql
M packaging/setup/dbutils/taskcleaner.sh
R packaging/setup/dbutils/taskcleaner_sp.sql
A packaging/setup/dbutils/taskcleaner_sp_3_5.sql
5 files changed, 110 insertions(+), 10 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved; Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42932
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38ae2d0a739cb761b6e54d6f605c53ea76b023c4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: enlarge assign quota dialog
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: enlarge assign quota dialog
......................................................................
webadmin: enlarge assign quota dialog
Enlarge the width of assign quota to disk dialog
(to avoid horizontal scroll-bar).
Change-Id: I22ba9433c94030b919a735b9b17b7dce3f764f3e
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/ChangeQuotaPopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/42708
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22ba9433c94030b919a735b9b17b7dce3f764f3e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: status column in disks tab on All view
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: status column in disks tab on All view
......................................................................
webadmin: status column in disks tab on All view
Added status column to Disks main-tab/sub-tab
for 'All' view (status for DirectLUN disk will be
displayed as 'N/A').
Change-Id: I4de1f44f0ea91a66d175949fecce5dc8dd9962fb
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/42707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4de1f44f0ea91a66d175949fecce5dc8dd9962fb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: fix quota for add cinder disk
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: fix quota for add cinder disk
......................................................................
webadmin: fix quota for add cinder disk
Fix AbstractDiskModel to support quota for cinder.
Change-Id: Ic8446c31f19fe50bee006c7d6e438d39ffb4b93b
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/42706
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8446c31f19fe50bee006c7d6e438d39ffb4b93b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: quota for cinder on disks general sub-tab
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: quota for cinder on disks general sub-tab
......................................................................
webadmin: quota for cinder on disks general sub-tab
Display quota on 'Disks -> General sub-tab' for
cinder disks.
Change-Id: I825148e5c20159b882011eeb74e2a47d11f104e0
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/42705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I825148e5c20159b882011eeb74e2a47d11f104e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: support Cinder disks on assign quota dialog
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: support Cinder disks on assign quota dialog
......................................................................
webadmin: support Cinder disks on assign quota dialog
Supporting Cinder disks on ChangeQuotaModel.
Change-Id: I4fbac43dacc0855510803fbb7e24c8e7184a5939
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java
2 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/42704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fbac43dacc0855510803fbb7e24c8e7184a5939
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in jenkins[master]: Added simple verification guidelines
by dcaroest@redhat.com
David Caro has submitted this change and it was merged.
Change subject: Added simple verification guidelines
......................................................................
Added simple verification guidelines
Change-Id: Icc9633f87b4fe551b7e1acb8ea6c8a1ef155e5a0
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/README
1 file changed, 54 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
David Caro: Verified; Looks good to me; Ready for merge
--
To view, visit https://gerrit.ovirt.org/41139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9633f87b4fe551b7e1acb8ea6c8a1ef155e5a0
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com>
Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com>
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>
9 years, 6 months
Change in ovirt-guest-agent[master]: Send an automatic refresh if the version changed
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Send an automatic refresh if the version changed
......................................................................
Send an automatic refresh if the version changed
Currently OGA does not send any updated information in case the version
changed. That causes data to be missing on the VDSM side when there's
a version difference.
The only solution to solve this was until now is to restart VDSM, this
patch addresses this limitation.
Change-Id: I4b53609644438f661d8db1025e609b4b8d4efc7e
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/OVirtAgentLogic.py
1 file changed, 13 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b53609644438f661d8db1025e609b4b8d4efc7e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-guest-agent[master]: Fix exceptions on guest os reporting
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Fix exceptions on guest os reporting
......................................................................
Fix exceptions on guest os reporting
During the verification of the engine side of this feature, stacktraces
have been found in the guest agent logs.
The functionality was not affected by these exceptions, however need to
be addressed properly. This patch solves this.
Change-Id: I626081377ca6eb25588f4fc42aa70af7048ab7bd
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentLinux2.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Looks good to me, but someone else must approve
Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42260
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I626081377ca6eb25588f4fc42aa70af7048ab7bd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months
Change in ovirt-engine[master]: webadmin: Fix Null pointer dereferences in VolumeGeoRepListM...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Fix Null pointer dereferences in VolumeGeoRepListModel
......................................................................
webadmin: Fix Null pointer dereferences in VolumeGeoRepListModel
This patch fixes Null pointer dereferences in VolumeGeoRepListModel.
The null check was not required there as it is guranteed to be non-null
and it suffices to check for newConfig's value to be null or non-null.
Hence relaxed the null check there.
Change-Id: I9491a79f60c3a8517bb5c51de675630a01363f3f
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9491a79f60c3a8517bb5c51de675630a01363f3f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 6 months