Change in ovirt-host-deploy[master]: doc: README: create fakevmstats section
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: doc: README: create fakevmstats section
......................................................................
doc: README: create fakevmstats section
Change-Id: Ia5e46474574063d7843a25cf83e1718184fb818e
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M README
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43958
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5e46474574063d7843a25cf83e1718184fb818e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: core: Added comments to StorageDomainValidator
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Added comments to StorageDomainValidator
......................................................................
core: Added comments to StorageDomainValidator
Added java doc to public storage allocation validations.
Change-Id: Ieaa53c1e5fc1afeada41ac3cde118c09a480572d
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
1 file changed, 25 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/44007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaa53c1e5fc1afeada41ac3cde118c09a480572d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest generics
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ActivateStorageDomainCommandTest generics
......................................................................
core: ActivateStorageDomainCommandTest generics
Used Java-7 style diamond generics to reduce code bloating.
Change-Id: I85dc44316b5ef5ce789206436f11f8c513cca9c5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85dc44316b5ef5ce789206436f11f8c513cca9c5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest modifiers
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ActivateStorageDomainCommandTest modifiers
......................................................................
core: ActivateStorageDomainCommandTest modifiers
Made data members private as per proper Java and JUnit conventions.
Change-Id: I0a4164a8a94e5e70810a61b6e5e2c05d3a6ad356
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a4164a8a94e5e70810a61b6e5e2c05d3a6ad356
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest asserts
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ActivateStorageDomainCommandTest asserts
......................................................................
core: ActivateStorageDomainCommandTest asserts
Used the standard CanDoActionTestUtils to avoid code duplication and
standardize assertions.
Change-Id: I40e42bba7db2232b4b4aae821a89fdd423a19e2f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
1 file changed, 6 insertions(+), 30 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40e42bba7db2232b4b4aae821a89fdd423a19e2f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest lists
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ActivateStorageDomainCommandTest lists
......................................................................
core: ActivateStorageDomainCommandTest lists
Remove usage of ArrayList from the test and replace it with explicit
usages of Collections.emptyList() and Collections.singletonList(Object),
which are both clearer to understand and less bug prone in the future.
Change-Id: Id497f77375030ee1ef0b4f735ae2bf044b027ffd
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id497f77375030ee1ef0b4f735ae2bf044b027ffd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: core: get down vm from monitoring also on power off
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: get down vm from monitoring also on power off
......................................................................
core: get down vm from monitoring also on power off
currently power off flow assume vm will not be reported by vdsm anymore,
and set vm to down and call processDownVm directly.
this is not always true:
* if it takes some time to vdsm to destroy the vm
the vm might be reported as down on monitoring cycle.
* when using events - event with status down in received.
so changed DestroyVmVDSCommand to set the vm to powering down, and down
will be received from the monitoring.
also changed the monitoring to allow vm in Powering Down status not to
be reported anymore, and treat as normal down (and not error).
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1242500
Change-Id: Ic60cceac6ad71adcb4d96a8938f98b5ea08f2043
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
2 files changed, 11 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic60cceac6ad71adcb4d96a8938f98b5ea08f2043
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in otopi[master]: services: improve error messages
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: services: improve error messages
......................................................................
services: improve error messages
Change-Id: I3dd0359d5baac676e61113792c22e93c2e32d09c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/otopi/services/openrc.py
M src/plugins/otopi/services/rhel.py
M src/plugins/otopi/services/systemd.py
3 files changed, 59 insertions(+), 12 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44062
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dd0359d5baac676e61113792c22e93c2e32d09c
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-host-deploy[master]: kdump: Display clear message when kdump fails to start
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: kdump: Display clear message when kdump fails to start
......................................................................
kdump: Display clear message when kdump fails to start
Displays clear error message when kdump service failed to start.
Change-Id: Ib23538998b39ed89b30dbc9637750ee6cc1c1daa
Bug-Url: http://bugzilla.redhat.com/1203727
Signed-off-by: Martin Perina <mperina(a)redhat.com>
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/kdump/packages.py
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib23538998b39ed89b30dbc9637750ee6cc1c1daa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months
Change in ovirt-engine[master]: webadmin: renames & removed unnecesary explicit typing.
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: renames & removed unnecesary explicit typing.
......................................................................
webadmin: renames & removed unnecesary explicit typing.
Change-Id: Ib5b233c5e94497ef8738dda43cf881fa54fdce6c
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
2 files changed, 65 insertions(+), 65 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/38233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5b233c5e94497ef8738dda43cf881fa54fdce6c
Gerrit-PatchSet: 78
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 9 months