July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix username for commands executed from Quartz jobs
by tnisan＠redhat.com 27 Jul '15

27 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix username for commands executed from Quartz jobs ...................................................................... core: Fix username for commands executed from Quartz jobs Set username for audit log to "engine@internal" for commands which are executed from Quartz jobs (those commands are not bound to any logged in user). Change-Id: Ibc7bae0be74d3a5f7c5b7cfc4f3827a1dcfda8b7 Bug-Url: https://bugzilla.redhat.com/1246823 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc7bae0be74d3a5f7c5b7cfc4f3827a1dcfda8b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: Revert "build: post ovirt-hosted-engine-setup-1.2.5.1"
by sbonazzo＠redhat.com 27 Jul '15

27 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "build: post ovirt-hosted-engine-setup-1.2.5.1" ...................................................................... Revert "build: post ovirt-hosted-engine-setup-1.2.5.1" This reverts commit 01f9aa8b68d8f8af72262b9fd53dc3cce6530309. Change-Id: I9e3aa5a9bcc0566d19a47af4e3d3b98a17d33a5c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 6 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e3aa5a9bcc0566d19a47af4e3d3b98a17d33a5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove redundant casting
by oourfali＠redhat.com 27 Jul '15

27 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Remove redundant casting ...................................................................... engine: Remove redundant casting Change-Id: Ia0829c8cc791ecdf6bfac1b81f13bcb1fbfbd29d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForHostQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForVmQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErratumByIdForHostQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErratumByIdForVmQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/SystemProviderFinder.java 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0829c8cc791ecdf6bfac1b81f13bcb1fbfbd29d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Send 'device' property for RNG device
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Send 'device' property for RNG device ...................................................................... core: Send 'device' property for RNG device When sending device info to VDSM, set 'device' property for RNG device as VDSM relies on presence of this property. Change-Id: I5b27b2a8b2867f3b77aff2fb1cf99c8ccc74d7c4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233825 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b27b2a8b2867f3b77aff2fb1cf99c8ccc74d7c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix start/stop fence job message
by emesika＠redhat.com 26 Jul '15

26 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: core: fix start/stop fence job message ...................................................................... core: fix start/stop fence job message Override getJobMessageProperties in FenceVdsBaseCommand in order to put the cluster type and name into the map This is not done automatically since both stop/start are host command and will fill only the host details in the map Change-Id: I10bfed3f458e9711fcc7c053cc43d3102b6a75e7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1246440 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10bfed3f458e9711fcc7c053cc43d3102b6a75e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: use db status when processing down vms
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: use db status when processing down vms ...................................................................... core: use db status when processing down vms when analyzing vm in down status, if the vm is not running on that host, the status from db is not taken in consideration. in some cases, like during migration, the analyzer can use the status from db, even if the vm is not running this host, in order to understand the current state of the vm. scenrio for example: vm moves to down on destination, since the analyzer dont use the status from the db, it doesnt know its migration process and clears the migrate command from the cache, breaking rerun/further treatment of the command. Change-Id: I1a893f7e06e417ca1a516cb04feb3a5defdb9c23 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a893f7e06e417ca1a516cb04feb3a5defdb9c23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: No '; ' at the end of customProperties
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: No ';' at the end of customProperties ...................................................................... core: No ';' at the end of customProperties Construct customProperties value always without ';' at the end. CustomPropertiesUtils.convertProperties() and VmPropertiesUtils.customProperties() produced different results in this case which caused comparisons to fail. Change-Id: Ibcbb840537dc55c9264cec769ee0b250af409838 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238742 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcbb840537dc55c9264cec769ee0b250af409838 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: minor refactor in handleVmOnDown
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor refactor in handleVmOnDown ...................................................................... core: minor refactor in handleVmOnDown Currently handleVmOnDown get VmStatistics object as parameter and only use its id, which is already passed in other params, so removed. Change-Id: Ife943dde06565b2cb40f9c54efc60a5061b15cc6 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife943dde06565b2cb40f9c54efc60a5061b15cc6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix vmDynamic copy ctor
by ofrenkel＠redhat.com 26 Jul '15

26 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix vmDynamic copy ctor ...................................................................... core: fix vmDynamic copy ctor Change-Id: I869867a9fa2a9b88c9e5b994211ac5a68ddbbe55 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I869867a9fa2a9b88c9e5b994211ac5a68ddbbe55 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: changing NULL in sort behaviour
by oourfali＠redhat.com 26 Jul '15

26 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: changing NULL in sort behaviour ...................................................................... core: changing NULL in sort behaviour Modifying the search engine code to put NULLS first in case that order was ASC NULLS last in case that order was DESC Change-Id: I249f341007f84ed0fca49179598f19b87ff43045 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1243444 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Liran Zelkha: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I249f341007f84ed0fca49179598f19b87ff43045 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0