Change in jenkins[master]: publish-rpms-nightly-master: fix f22 repoclosure
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: publish-rpms-nightly-master: fix f22 repoclosure
......................................................................
publish-rpms-nightly-master: fix f22 repoclosure
Change-Id: I1da1552b4e8ccf56a16fea8f46349a55bfd7bd8d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/builders/copy-create-job-artifact.yaml
M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml
2 files changed, 9 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43757
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1da1552b4e8ccf56a16fea8f46349a55bfd7bd8d
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 5 months
Change in jenkins[master]: publish-rpms-nightly-master: add ovirt-register
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: publish-rpms-nightly-master: add ovirt-register
......................................................................
publish-rpms-nightly-master: add ovirt-register
Add ovirt-register_master_build-artifacts-el7-x86_64
to publish-rpms-nightly-master.
Change-Id: Id44854475728f1c0c849b7eebb69478b9dd08470
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id44854475728f1c0c849b7eebb69478b9dd08470
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[master]: core: Resurrect VdsBrokerObjectBuilderTest
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Resurrect VdsBrokerObjectBuilderTest
......................................................................
core: Resurrect VdsBrokerObjectBuilderTest
VdsBrokerObjectBuilderTest was commented out in patch
7469b8d5392840a30e1cb8e6a05eafce83114d6c, since it used PowerMock which
slowed down the build considerably.
This patch uncomments the class and properly removes PowerMock usages so
this test can be used again.
With regard to performance, this test runs in ~800 milliseconds on my
laptop, which is completely reasonable, although exact times may change
depending on the machine, the load it's experiencing, etc.
Note that this patch is pretty raw, and just introduces the minimal work
required to re-enable this test. Following patches in the series will
continue to improve this class as per the project's standards.
Changes performed:
* Uncommented all the class.
* Removed the top "TODO" comment, as this patch does exactly that.
* Removed PowerMockito calls and annotations.
* Replaced the test runner with MockitoJUnitRunner.
* Re-introduced JsonObjectDeserializer#deserializeUnformattedJson
removed in b2983fad2002ac47cfc98a7d84401daa85874c5e that's needed for
asserting the disk statistics results.
* Removed usages of XmlRpcStruct and replaced them with
Map<String, Object> as done in VdsBrokerObjectsBuilder in commit
fa3c96ad55ed3aac5b0a923c0a30363c57d5c293.
* Reordered the imports to comply with the checkstyle verification
added in commit a4f50e3be1717fd9cc60314f87b3d56bae6ba048.
Change-Id: I7b05b287f7938fa26197dc4dfd3f5681ea7a86a2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
2 files changed, 338 insertions(+), 346 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b05b287f7938fa26197dc4dfd3f5681ea7a86a2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Fix typo doulbe -> double
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix typo doulbe -> double
......................................................................
core: Fix typo doulbe -> double
Change-Id: I355b5437fe37ff0f288eb9a3c878bd54e150387d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I355b5437fe37ff0f288eb9a3c878bd54e150387d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Diamond generics
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Diamond generics
......................................................................
core: Diamond generics
Employed Java 7 style diamond generics to improve the class'
readability.
Change-Id: I4b8de9110d9cd55cebc5a670986959bf718311aa
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43740
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b8de9110d9cd55cebc5a670986959bf718311aa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Simplify assertions
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Simplify assertions
......................................................................
core: Simplify assertions
Simplified assertEquals(null, someVariable) assertions to easier to read
assertNull(someVariable) statements.
Change-Id: I26129af764d546722af5615ff8773161b67c0b27
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26129af764d546722af5615ff8773161b67c0b27
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Java style constants
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Java style constants
......................................................................
core: Java style constants
Fixed the conceptual constants in VdsBrokerObjectBuilderTest to be
private static final and to be named in UPPER_CASE, as per Java's coding
standard.
Change-Id: Ib81b146f49708cd2d8ae562d352d955cb3500866
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43737
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib81b146f49708cd2d8ae562d352d955cb3500866
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Use constants from VdsProperties
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Use constants from VdsProperties
......................................................................
core: Use constants from VdsProperties
Use the same string constants in VdsBrokerObjectBuilderTest as
VdsBrokerObjectBuilder uses in order to make the test safer and easier
to read.
Change-Id: I38f3295930c6841e245a15fef6b554974e68be0e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 19 insertions(+), 22 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38f3295930c6841e245a15fef6b554974e68be0e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Don't mock in VdsBrokerObjectBuilderTest
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Don't mock in VdsBrokerObjectBuilderTest
......................................................................
core: Don't mock in VdsBrokerObjectBuilderTest
VdsBrokerObjectBuilderTest contains leftover mocking of DAO classes
which are no longer used by the class under testing,
VdsBrokerObjectBuilder.
Change-Id: Ia6b20a5ebdda2e47d611ca6cccea73019ebef7b9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 1 insertion(+), 34 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6b20a5ebdda2e47d611ca6cccea73019ebef7b9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: Inline useless variable
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Inline useless variable
......................................................................
core: Inline useless variable
Change-Id: I66ae188fb5771af397d3e5d840a277fd74a47f25
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66ae188fb5771af397d3e5d840a277fd74a47f25
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months