July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VM pinning to multiple hosts (database refactor)
by rgolan＠redhat.com 16 Jul '15

16 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: VM pinning to multiple hosts (database refactor) ...................................................................... core: VM pinning to multiple hosts (database refactor) 1. Create connection table vm_vds_pinning_map. Many to many relations from vm_static to vds_static 2. Populate vm_vds_pinning_map with existing dedicated_vm_for_vds fields. 3. Create funtion getDedicatedHostsIdsByVmId(v_vm_id UUID) in create_functions.sql Returns csv list of dedicated hosts guids 4. Create a view on vm_vds_pinning_map (create_views.sql) Providing the coresponding host name and vm name. 5. Update dependant views (create_views.sql and create_dwh_views.sql) 6. Refactor CRUD operations for vm_static (vms_sp.sql and vm_templates_sp.sql) 7. Refacotr dedicated_vm_for_vds dependant operation (vds_sp.sql) Bug-Url: https://bugzilla.redhat.com/1107512 Change-Id: I9d6750936553a3f88a8a24291ecb9725611b8618 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_functions.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1750_pinning_to_multiple_hosts_connection_table.sql M packaging/dbscripts/vds_sp.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 10 files changed, 279 insertions(+), 168 deletions(-) Approvals: Dudi Maroshi: Verified Roy Golan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d6750936553a3f88a8a24291ecb9725611b8618 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sim Zacks <szacks(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: logger: do not allow extra parameters
by masayag＠redhat.com 16 Jul '15

16 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: logger: do not allow extra parameters ...................................................................... exttool: logger: do not allow extra parameters Change-Id: I62ccb219134842c5001441629f849b64d7f83d3e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62ccb219134842c5001441629f849b64d7f83d3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: logger: remove stderr usage
by masayag＠redhat.com 16 Jul '15

16 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: logger: remove stderr usage ...................................................................... exttool: logger: remove stderr usage Change-Id: I130c8c01e62b8d86d4b8063105c8b1fe7cee09af Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I130c8c01e62b8d86d4b8063105c8b1fe7cee09af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: help: minor cleanup
by masayag＠redhat.com 16 Jul '15

16 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: help: minor cleanup ...................................................................... exttool: help: minor cleanup Change-Id: I7f41bab9615bf64f043b9191a3aeae465fc93ebc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/HelpServiceImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f41bab9615bf64f043b9191a3aeae465fc93ebc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: removing startPool command
by sbonazzo＠redhat.com 16 Jul '15

16 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: removing startPool command ...................................................................... packaging: setup: removing startPool command Removing startPool command since hosted-engine SD is not anymore connected to a pool. Change-Id: I2fb7e896875762318eb41de2ec9d091c5e0756fc Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in 2 files changed, 1 insertion(+), 35 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fb7e896875762318eb41de2ec9d091c5e0756fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: adding --deploy-hc CLI option
by sbonazzo＠redhat.com 16 Jul '15

16 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: adding --deploy-hc CLI option ...................................................................... packaging: setup: adding --deploy-hc CLI option Adding --deploy-hc command line option in order to provide a set of answers to hyper-converged related questions Change-Id: I7c74bf18063a0d58585d2f993652ae2fd321367d Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M man/ovirt-hosted-engine-setup.8 M src/bin/hosted-engine.in M src/bin/ovirt-hosted-engine-setup M src/plugins/ovirt-hosted-engine-setup/core/misc.py M templates/Makefile.am A templates/hc.answer.conf.in 7 files changed, 49 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c74bf18063a0d58585d2f993652ae2fd321367d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix typo "cant"->"can't" throughout the code
by amureini＠redhat.com 16 Jul '15

16 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix typo "cant"->"can't" throughout the code ...................................................................... core: Fix typo "cant"->"can't" throughout the code Change-Id: I1692104c9f4d281c7e4b7f6d20fd601a0853c7e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1692104c9f4d281c7e4b7f6d20fd601a0853c7e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: adding VdsCommandsHelper
by laravot＠redhat.com 16 Jul '15

16 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: adding VdsCommandsHelper ...................................................................... adding VdsCommandsHelper Change-Id: I4cb8e979bead136cb4e6409ed8aeedbd14699f59 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VdsCommandsHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineException.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VdsIdVDSCommandParametersBase.java 4 files changed, 133 insertions(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cb8e979bead136cb4e6409ed8aeedbd14699f59 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: vdsbroker: adding StorageDomainMetadataCommand
by laravot＠redhat.com 16 Jul '15

16 Jul '15

Liron Aravot has submitted this change and it was merged. Change subject: vdsbroker: adding StorageDomainMetadataCommand ...................................................................... vdsbroker: adding StorageDomainMetadataCommand Change-Id: Ide34242f4b477bf882e7e6e5b44de7ceed409e44 Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/StorageDomainVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSReturnValue.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StorageDomainMetadataCommand.java 5 files changed, 169 insertions(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide34242f4b477bf882e7e6e5b44de7ceed409e44 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Allow user to subscribe to cert events
by masayag＠redhat.com 16 Jul '15

16 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Allow user to subscribe to cert events ...................................................................... webadmin: Allow user to subscribe to cert events Change-Id: I7d72edba49b15485652a3389b6f981a5f9c53268 Bug-Url: https://bugzilla.redhat.com/1188759 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d72edba49b15485652a3389b6f981a5f9c53268 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0