July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: jsonrpc: fixing spelling mistake
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: jsonrpc: fixing spelling mistake ...................................................................... jsonrpc: fixing spelling mistake Change-Id: Ic6a53053ccd04d0e6e4158bc01cc2b537b3f7aed Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M ovirt-engine.spec.in M pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a53053ccd04d0e6e4158bc01cc2b537b3f7aed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix options format message
by oourfali＠redhat.com 15 Jul '15

15 Jul '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix options format message ...................................................................... core: fix options format message Since fence-agents package removed support of sending boolean parameters by their own (i.e. lanplus, ssl etc.) and now we are forced to send the boolean value explicitly (i.e lanplus=1 ssl=1 etc.), we have to change the help message in the UI for the options field to reflect that. Change-Id: Iad4339a68608f29d279dce74fbd056c5dd80f2ad Signed-off-by: emesika <emesika(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad4339a68608f29d279dce74fbd056c5dd80f2ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: core: remove EXTENSION_TOOLGLOBAL_EXTENSIONS_MAP key
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: core: remove EXTENSION_TOOLGLOBAL_EXTENSIONS_MAP key ...................................................................... exttool: core: remove EXTENSION_TOOLGLOBAL_EXTENSIONS_MAP key it was replaced by EXTENSION_TOOL_EXTENSION_MANAGER Change-Id: I10dbc1f5fc240747adb598a6992ee9506aaf2a2a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java 2 files changed, 13 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondra Machacek: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10dbc1f5fc240747adb598a6992ee9506aaf2a2a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: display->type did not work for instance types
by tjelinek＠redhat.com 15 Jul '15

15 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: display->type did not work for instance types ...................................................................... restapi: display->type did not work for instance types Change-Id: I6c8c22d3bec079e7b3022ad72b2f092ecd001b2e Bug-Url: https://bugzilla.redhat.com/1236497 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypesResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateBasedResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java 5 files changed, 26 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c8c22d3bec079e7b3022ad72b2f092ecd001b2e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: calling prepareImage on additional host
by sbonazzo＠redhat.com 15 Jul '15

15 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: calling prepareImage on additional host ...................................................................... packaging: setup: calling prepareImage on additional host Calling VDSM prepareImage to initially prepare VDSM structures on additional hosts. Change-Id: Iabebf6abfc875c11df433f8ee9a6071fa9ab1163 Bug-Url: https://bugzilla.redhat.com/1215967 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 31 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabebf6abfc875c11df433f8ee9a6071fa9ab1163 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix table context menu error
by vszocs＠redhat.com 15 Jul '15

15 Jul '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix table context menu error ...................................................................... webadmin,userportal: Fix table context menu error When a user right-clicks the "No items to display" section within an empty table, IndexOutOfBoundsException is thrown since AbstractActionTable tries to resolve value associated with clicked row, but fails. This patch fixes that problem. Change-Id: Ic7084517ea4d64329c09b8b52e7342a5362d32e1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/43403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7084517ea4d64329c09b8b52e7342a5362d32e1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: exttool: logger: convert to enum pattern
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: exttool: logger: convert to enum pattern ...................................................................... exttool: logger: convert to enum pattern Change-Id: I1986da9a81362c5f87e81c56e2052d0afa0c00cb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/logger/arguments.properties 2 files changed, 113 insertions(+), 101 deletions(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1986da9a81362c5f87e81c56e2052d0afa0c00cb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: api: cleanup
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: api: cleanup ...................................................................... api: cleanup I do not know process of deprication of api but we have not used following methods in 3.5 so it should be ok to remove them for 3.6. Change-Id: Ifa1acf386d1860cd31440c97890f87941086f717 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/StartSpiceVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageConnectionsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StartSpiceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 12 files changed, 0 insertions(+), 252 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/36104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa1acf386d1860cd31440c97890f87941086f717 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: Improve View/Table JavaDoc
by vszocs＠redhat.com 15 Jul '15

15 Jul '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve View/Table JavaDoc ...................................................................... webadmin,userportal: Improve View/Table JavaDoc This patch addresses source code documentation concerns raised by Greg: https://gerrit.ovirt.org/#/c/42824/3 Change-Id: I9a5437c8b282389e5b898485d908d6bd071a32f8 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractModelBoundPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 2 files changed, 90 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a5437c8b282389e5b898485d908d6bd071a32f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: clear format of allowable characters in error msg
by masayag＠redhat.com 15 Jul '15

15 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: clear format of allowable characters in error msg ...................................................................... clear format of allowable characters in error msg Clear format of allowable characters in error messages "a-z0-9A-Z" or "-_" => 'a-z', 'A-Z', '0-9', '_' or '-' Change-Id: If7c387a6e256135d820c09cede74ee593be88b8d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1235118 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 32 insertions(+), 32 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c387a6e256135d820c09cede74ee593be88b8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0