July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: removed duplicates
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: removed duplicates ...................................................................... core: removed duplicates removed duplicates in finding incoherent references & creating variable replacements Change-Id: I6f4e7f25b23e1c245b1f292390902c5b2ec77cbd Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 38 insertions(+), 52 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f4e7f25b23e1c245b1f292390902c5b2ec77cbd Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove unused import
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: remove unused import ...................................................................... core: remove unused import Change-Id: I6a4f221a2de9f3b3fe72db4009d6dd4a9fada829 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UnmanagedNetworksHelper.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a4f221a2de9f3b3fe72db4009d6dd4a9fada829 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: allow indetifying network by its name when adding netw...
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: allow indetifying network by its name when adding network attachment allow indetifying network by its name. ...................................................................... core: allow indetifying network by its name when adding network attachment allow indetifying network by its name. Change-Id: I2b692915593a86e9ea4b8faa8056cbcafefe328e Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddNetworkAttachmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkIdNetworkNameCompleter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkIdOrNetworkNameIsSetConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/NetworkIdOrNetworkNameIsSet.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 196 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b692915593a86e9ea4b8faa8056cbcafefe328e Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: unmanaged network queries, removing unmanaged networks...
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: unmanaged network queries, removing unmanaged networks via HostSetupNetworksCommand ...................................................................... core: unmanaged network queries, removing unmanaged networks via HostSetupNetworksCommand Change-Id: I6cf3d8b99b6c9909caba1d88c150859f8dc91750 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetAllUnmanagedNetworksByHostIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetUnmanagedNetworkByHostIdAndNameQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UnmanagedNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostSetupNetworksParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/UnmanagedNetworkParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 7 files changed, 187 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cf3d8b99b6c9909caba1d88c150859f8dc91750 Gerrit-PatchSet: 74 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introducing UnmanagedNetwork business entity.
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: introducing UnmanagedNetwork business entity. ...................................................................... core: introducing UnmanagedNetwork business entity. Change-Id: I69d75d91ba6646f5a11e3445266e7e54cef30148 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UnmanagedNetwork.java 1 file changed, 72 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69d75d91ba6646f5a11e3445266e7e54cef30148 Gerrit-PatchSet: 73 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introducing queries for ReportedConfigurations busines...
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: introducing queries for ReportedConfigurations business entity. ...................................................................... core: introducing queries for ReportedConfigurations business entity. Change-Id: I4c8cb1020263988af7a09c0cf86772965e9d3560 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostNicIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFiller.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFillerTest.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 9 files changed, 678 insertions(+), 36 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c8cb1020263988af7a09c0cf86772965e9d3560 Gerrit-PatchSet: 73 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add machine type for ppc64le 7.2
by ofrenkel＠redhat.com 12 Jul '15

12 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: add machine type for ppc64le 7.2 ...................................................................... core: add machine type for ppc64le 7.2 Newest ppc64le reports emulated machine as pseries-rhel7.2. That is version supported by 3.6 and therefore, needs to be added. On the other hand, 7.1 is unsupported. Change-Id: If3ea2f0c0f1e2dd180aa906489f983fd2565cd08 Signed-off-by: Martin Polednik <mpolednik(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/43374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3ea2f0c0f1e2dd180aa906489f983fd2565cd08 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove getEntityGraphicsTypes.
by ofrenkel＠redhat.com 12 Jul '15

12 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Remove getEntityGraphicsTypes. ...................................................................... core: Remove getEntityGraphicsTypes. Removed AddVmFromTemplateCommand#getEntityGraphicsTypes, which isn't used anywhere in the code base. Change-Id: Ie0e9ea6a2cb53f9226a8aee0259198f8a2c46ac4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0e9ea6a2cb53f9226a8aee0259198f8a2c46ac4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, userportal, webadmin: using reporting configurations bus...
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core,userportal,webadmin: using reporting configurations business entity. ...................................................................... core,userportal,webadmin: using reporting configurations business entity. Change-Id: Iad5de470320ff83e7b3c4606a450c62dbd6d223f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad5de470320ff83e7b3c4606a450c62dbd6d223f Gerrit-PatchSet: 71 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introducing ReportedConfigurations business entity.
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: introducing ReportedConfigurations business entity. ...................................................................... core: introducing ReportedConfigurations business entity. Change-Id: Ifceb49f7b0aeda8ed094c8a91f853744cc8facff Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfiguration.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurationType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurations.java 3 files changed, 147 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifceb49f7b0aeda8ed094c8a91f853744cc8facff Gerrit-PatchSet: 71 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0