July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: override configuration
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: override configuration ...................................................................... core: override configuration add 'overrideConfiguration' field so user can explicitely express his intention. Change-Id: I6e966a1cb51aee4743b0a40e4ea82d7f961e7bac Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/MapNetworkAttachments.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidNameOfVdsNetworkInterface.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 335 insertions(+), 116 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e966a1cb51aee4743b0a40e4ea82d7f961e7bac Gerrit-PatchSet: 74 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introducing QosDaoCache
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: introducing QosDaoCache ...................................................................... core: introducing QosDaoCache Class which caches already queried HostNetworkQos instances loading missing ones as needed. Code was extracted from HostSetupNetworksCommand, because it will be also needed on other locations. Change-Id: Iac75ac3a09cce8790b454178f2d3f7ceda534649 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/QosDaoCache.java 2 files changed, 42 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac75ac3a09cce8790b454178f2d3f7ceda534649 Gerrit-PatchSet: 69 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: mtu validation refactored out from HostSetupNetworkVal...
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: mtu validation refactored out from HostSetupNetworkValidator ...................................................................... core: mtu validation refactored out from HostSetupNetworkValidator Change-Id: Ia06d89a7091deefd39974a6d996a282913847e8d Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidatorTest.java 4 files changed, 217 insertions(+), 129 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia06d89a7091deefd39974a6d996a282913847e8d Gerrit-PatchSet: 74 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: multiple tests & refactoring of HostSetupNetworksValid...
by alkaplan＠redhat.com 12 Jul '15

12 Jul '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: multiple tests & refactoring of HostSetupNetworksValidator.java ...................................................................... core: multiple tests & refactoring of HostSetupNetworksValidator.java This is a combination of 11 commits: ———————————————————————————————————— core: refactoring of HostSetupNetworksValidator.java • inlined variable in #validateNetworkExclusiveOnNics • renamed variable and extracted boolean condition in #networksUniquelyConfiguredOnHost • removed 'passed' variable in #validateNotRemovingUsedNetworkByVms • removed unnecessary continue in #getAttachmentsToConfigure • extracted validation of slaves into separate method from overgrown #validModifiedBonds • 'narrowed' visibility of #getVmInterfaceManager core: calculate attachmentsToConfigure only once. core: test for mtu validation core: tests for HostSetupNetworksValidator#notRemovingLabeledNetworks. core: tests for HostSetupNetworksValidator#validRemovedBonds core: unified field/param names. •unified field/param names •inlined unnecessary getter. core: tests for HostSetupNetworksValidator#validateNotRemovingUsedNetworkByVms core: tests for HostSetupNetworksValidator#networksUniquelyConfiguredOnHost core: tests for HostSetupNetworksValidator#validModifiedBonds • added tests • extracted creation of HostInterfaceValidator for mocking purposes • renamed two methods allowing to use them in different context as well. core: fixes & tests for HostSetupNetworksValidator#getAttachmentsToConfigure • getAttachmentsToConfigure did not return NetworkAttachments which were changed by the user. Implementation was entirely changed • added tests for this new configuration core: tests for HostSetupNetworksValidator#validateCustomProperties() ———————————————————————————————————— Change-Id: If921e9d74b54057e43708fc48f53f81b05293c71 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 1,201 insertions(+), 88 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If921e9d74b54057e43708fc48f53f81b05293c71 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: events refresher - handle migrating and external vms
by ofrenkel＠redhat.com 12 Jul '15

12 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: events refresher - handle migrating and external vms ...................................................................... core: events refresher - handle migrating and external vms currently the events refresher ignores external vms (vm not in db) and wrong handling vms that are in 'migration destination'. the vms-monitoring expects the dbVm to be null on these cases, and knows to handle migration destination and external vms. this patch sends the right data to the monitoring. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238114 Change-Id: If861153fb8893bcf35044d4371794ca58d05f366 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java 1 file changed, 19 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If861153fb8893bcf35044d4371794ca58d05f366 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Print pre-defined available packages
by masayag＠redhat.com 12 Jul '15

12 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Print pre-defined available packages ...................................................................... engine: Print pre-defined available packages The output of the updates available check in the event log should be restricted to the defined packages to prevent flood of the dependencies. Change-Id: I51f31f41ff52f8f6fbb1cbf76159bb8047e68c59 Bug-Url: https://bugzilla.redhat.com/1235668 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/AvailableUpdatesFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/UpdateAvailable.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 7 files changed, 89 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51f31f41ff52f8f6fbb1cbf76159bb8047e68c59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Fixed to run on el hosts
by dcaroest＠redhat.com 10 Jul '15

10 Jul '15

David Caro has submitted this change and it was merged. Change subject: Fixed to run on el hosts ...................................................................... Fixed to run on el hosts Change-Id: Ia778844885f43b474e6d880f07e5a7797fecff25 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/site-defaults.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/43422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia778844885f43b474e6d880f07e5a7797fecff25 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Build correctly instance type NIC links
by juan.hernandez＠redhat.com 10 Jul '15

10 Jul '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Build correctly instance type NIC links ...................................................................... restapi: Build correctly instance type NIC links The collection of NICs of instance types has been implemented reusing the class that implements the collection of NICs of templates. As a side effect the links to these NICs point to the templates collection instead of to the instance types collection. This patch introduces a new class to implement the collection of NICs of instance types, so that the "setParents" method that is used as part of the calculation of the link can be overriden to set a instance type as parent instead of a template. Change-Id: Ib3ab0857517a1fefc88b835457aa4b4241a3bb5d Bug-Url: https://bugzilla.redhat.com/1241574 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeResource.java 3 files changed, 23 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ab0857517a1fefc88b835457aa4b4241a3bb5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal: make template from snapshot does not work in use...
by tjelinek＠redhat.com 10 Jul '15

10 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: make template from snapshot does not work in userportal ...................................................................... userportal: make template from snapshot does not work in userportal 2 issues: 1: user poral used the webadmin's NewTemplateVmModelBehavior while it was supposed to use the UserPortalNewTemplateVmModelBehavior 2: the userportal's VmSnapshotListModelProvider completely ignored the getCloneTemplateCommand Change-Id: I9f72dad9a5522f87ae085528168d5a1b9ccec275 Bug-Url: https://bugzilla.redhat.com/1231729 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmSnapshotListModelProvider.java 4 files changed, 19 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f72dad9a5522f87ae085528168d5a1b9ccec275 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: made show/hide advanced options with static width
by tjelinek＠redhat.com 10 Jul '15

10 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: made show/hide advanced options with static width ...................................................................... webadmin: made show/hide advanced options with static width Change-Id: I2dfde1002e858f763a85f08116262e18b08ec0a8 Bug-Url: https://bugzilla.redhat.com/1063765 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/VmPopupResources.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/VmPopupStyle.css M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateEditPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmClonePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/instancetypes/InstanceTypesPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/template/TemplateEditPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmClonePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmPopupView.java 13 files changed, 55 insertions(+), 22 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dfde1002e858f763a85f08116262e18b08ec0a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0