Change in ovirt-log-collector[master]: sos: drop sos 2 build support
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sos: drop sos 2 build support
......................................................................
sos: drop sos 2 build support
Change-Id: Iabdf9b918d8aa299a494c84e1508f5476fc542e2
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252063
---
M configure.ac
M ovirt-log-collector.spec.in
M po/POTFILES.in
M src/Makefile.am
D src/sos/Makefile.am
D src/sos/plugins/Makefile.am
D src/sos/plugins/ovirt.py
D src/sos/plugins/postgresql.py
8 files changed, 2 insertions(+), 478 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44623
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabdf9b918d8aa299a494c84e1508f5476fc542e2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: gluster: Sync the bricks immediately after snapshot restore
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: gluster: Sync the bricks immediately after snapshot restore
......................................................................
gluster: Sync the bricks immediately after snapshot restore
Sync the gluster volume bricks immediately after snapshot
restore for a volume as system sync would cause event
logs mentioning bricks removal and addition.
Change-Id: I0983a9b31f495689f9cc58e72d6bde9caaef05af
Bug-Url: https://bugzilla.redhat.com/1236696
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeInfoVDSParameters.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
8 files changed, 110 insertions(+), 6 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shubhendu Tripathi: Verified
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0983a9b31f495689f9cc58e72d6bde9caaef05af
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: packaging: dbutils: add schema names to tables in fkvalidator
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: dbutils: add schema names to tables in fkvalidator
......................................................................
packaging: dbutils: add schema names to tables in fkvalidator
This change is needed since aaa-jdbc using different schema names
for the aaa-jdbc users/group
Change-Id: I69a6ef8429abb99aeed4ab47bd40d049b9fa457a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254639
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M packaging/setup/dbutils/fkvalidator_sp.sql
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45148
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69a6ef8429abb99aeed4ab47bd40d049b9fa457a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Don't call DefaultHttpClient.execute
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Don't call DefaultHttpClient.execute
......................................................................
sdk: Don't call DefaultHttpClient.execute
Thte DefaultHttpClient class has been deprecated in version 4.3 of
HttpCoponents, and the "execute" method signature has changed from this:
HttpResponse execute(HttpUriRequest, HttpContext)
To this:
CloseableHttpResponse execute(HttpUriRequest, HttpContext)
This means that the result of compiling calls to this method depends on
the version of HttpComponents used during the build. When using version
4.2 or older the result is this:
invokevirtual #14 // Method
org/apache/http/impl/client/DefaultHttpClient.execute:(
Lorg/apache/http/client/methods/HttpUriRequest;
Lorg/apache/http/protocol/HttpContext;
)Lorg/apache/http/HttpResponse;
When using version 4.3 or newer the result is this:
invokevirtual #14 // Method
org/apache/http/impl/client/DefaultHttpClient.execute:(
Lorg/apache/http/client/methods/HttpUriRequest;
Lorg/apache/http/protocol/HttpContext;
)Lorg/apache/http/client/methods/CloseableHttpResponse;
Note that with 4.2 the return type is "HttpResponse" but with 4.3 the
return type is "CloseableHttpResponse".
This shouldn't be a problem when building with maven, as we explicitly
specify version 4.2 in the POM of the project, but it can be a problem
in other build environments that don't use maven.
When built with the newer HttpComponents version execution will fail if
the older version is used, with the following error message:
Exception in thread "main" java.lang.NoSuchMethodError:
org.apache.http.impl.client.DefaultHttpClient.execute(
Lorg/apache/http/client/methods/HttpUriRequest;
Lorg/apache/http/protocol/HttpContext;
)Lorg/apache/http/client/methods/CloseableHttpResponse;
The right solution to this problem is to modify the SDK so that it
doesn't use the deprecated "DefaultHttpClient" class at all, but this
requires many changes. Instead of that this patch changes the SDK
minimally, so that the "DefaultHttpClient" class is used, but not for
calling the "execute" method, the "HttpClient" interface is used for
that instead. This way the result of compiling the calls to "execute" is
the same regardless of the version used. The changes required to stop
using "DefaultHttpClient" will be included in other patches.
Change-Id: I06f99256566f67034bbeff843eaf959cf4a87760
Bug-Url: https://bugzilla.redhat.com/1255078
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit f970761625ab6e5ff146259a3910315e6823228b)
---
M sdk/Makefile
M sdk/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06f99256566f67034bbeff843eaf959cf4a87760
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine-sdk-java[master]: sdk: Don't call DefaultHttpClient.execute
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Don't call DefaultHttpClient.execute
......................................................................
sdk: Don't call DefaultHttpClient.execute
Thte DefaultHttpClient class has been deprecated in version 4.3 of
HttpCoponents, and the "execute" method signature has changed from this:
HttpResponse execute(HttpUriRequest, HttpContext)
To this:
CloseableHttpResponse execute(HttpUriRequest, HttpContext)
This means that the result of compiling calls to this method depends on
the version of HttpComponents used during the build. When using version
4.2 or older the result is this:
invokevirtual #14 // Method
org/apache/http/impl/client/DefaultHttpClient.execute:(
Lorg/apache/http/client/methods/HttpUriRequest;
Lorg/apache/http/protocol/HttpContext;
)Lorg/apache/http/HttpResponse;
When using version 4.3 or newer the result is this:
invokevirtual #14 // Method
org/apache/http/impl/client/DefaultHttpClient.execute:(
Lorg/apache/http/client/methods/HttpUriRequest;
Lorg/apache/http/protocol/HttpContext;
)Lorg/apache/http/client/methods/CloseableHttpResponse;
Note that with 4.2 the return type is "HttpResponse" but with 4.3 the
return type is "CloseableHttpResponse".
This shouldn't be a problem when building with maven, as we explicitly
specify version 4.2 in the POM of the project, but it can be a problem
in other build environments that don't use maven.
When built with the newer HttpComponents version execution will fail if
the older version is used, with the following error message:
Exception in thread "main" java.lang.NoSuchMethodError:
org.apache.http.impl.client.DefaultHttpClient.execute(
Lorg/apache/http/client/methods/HttpUriRequest;
Lorg/apache/http/protocol/HttpContext;
)Lorg/apache/http/client/methods/CloseableHttpResponse;
The right solution to this problem is to modify the SDK so that it
doesn't use the deprecated "DefaultHttpClient" class at all, but this
requires many changes. Instead of that this patch changes the SDK
minimally, so that the "DefaultHttpClient" class is used, but not for
calling the "execute" method, the "HttpClient" interface is used for
that instead. This way the result of compiling the calls to "execute" is
the same regardless of the version used. The changes required to stop
using "DefaultHttpClient" will be included in other patches.
Change-Id: I06f99256566f67034bbeff843eaf959cf4a87760
Bug-Url: https://bugzilla.redhat.com/1255078
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06f99256566f67034bbeff843eaf959cf4a87760
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: validate that updated attachment already exists
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: validate that updated attachment already exists
......................................................................
core: validate that updated attachment already exists
added method to HostSetupNetworksValidator to validate, whether
network attachment to be updated actually exists.
Change-Id: I5ab5f215088746650b850a27ba1cb7afd2de9959
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/39500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ab5f215088746650b850a27ba1cb7afd2de9959
Gerrit-PatchSet: 39
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: engine: Remove Host Network QoS commitment validation
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Remove Host Network QoS commitment validation
......................................................................
engine: Remove Host Network QoS commitment validation
Since the speed reported by the host is not reliable (and in a lot of
cases, not even exists), this check doesn't have any added value
(and just makes it difficult for the user to configure qos on a nic).
Change-Id: I109463874e29c5388837461805ca32a7baf925f1
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfacesSpeed.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 3 insertions(+), 461 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I109463874e29c5388837461805ca32a7baf925f1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webamin: Disable qos for out-of-sync network
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webamin: Disable qos for out-of-sync network
......................................................................
webamin: Disable qos for out-of-sync network
In case the network is not in sync, the 'override qos' and the qos feilds
should be disabled
Change-Id: Id44cd41200ddc3e62a47a116d000f3d67ff42101
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/QosWidget.java
5 files changed, 33 insertions(+), 23 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44907
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id44cd41200ddc3e62a47a116d000f3d67ff42101
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: validating qos & using overridden qos in HostSetup...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: validating qos & using overridden qos in HostSetupNetworksCommand
......................................................................
webadmin: validating qos & using overridden qos in HostSetupNetworksCommand
Change-Id: I50c2b633823db2848c9e5955b78eec1b1b740d77
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java
7 files changed, 269 insertions(+), 185 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50c2b633823db2848c9e5955b78eec1b1b740d77
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: core: validating qos & using overridden qos in HostSetupNetw...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: validating qos & using overridden qos in HostSetupNetworksCommand
......................................................................
core: validating qos & using overridden qos in HostSetupNetworksCommand
Bug-Url: https://bugzilla.redhat.com/1192807
Change-Id: Ife65ad6ca750a7ee72711a24e648bfa560b0554f
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/QosDaoCache.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFiller.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostNetworkQosValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFillerTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/MapNetworkAttachments.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NetworkCommonUtils.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CalculateBaseNic.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/EffectiveHostNetworkQos.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/CalculateBaseNicTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/EffectiveHostNetworkQosTest.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsTest.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
34 files changed, 1,966 insertions(+), 924 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43984
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife65ad6ca750a7ee72711a24e648bfa560b0554f
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months