Change in ovirt-engine[ovirt-engine-3.6]: webadmin: network general tab layout
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: network general tab layout
......................................................................
webadmin: network general tab layout
- Fixed network general tab layout to not overlap when resizing.
Change-Id: Id58d67169b670e9ae37c174a2d8d389cb5a57113
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252987
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45466
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id58d67169b670e9ae37c174a2d8d389cb5a57113
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: New datacenter invalid highlight
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: New datacenter invalid highlight
......................................................................
webadmin: New datacenter invalid highlight
- The new Datacenter popup was changed to have tabs but never
had the code hooked up to highlight invalid fields on the tabs.
This patch hooks up the tabs to the infrastructure.
Change-Id: Iac7e452d282775d0f1bc296bf2dfce9ae62091f1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252525
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml
5 files changed, 46 insertions(+), 12 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45468
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac7e452d282775d0f1bc296bf2dfce9ae62091f1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix PUT on host pinning update
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix PUT on host pinning update
......................................................................
restapi: Fix PUT on host pinning update
Only adding new hosts to the pinned to host list for a VM was possible.
Removing hosts had no effect at all because the original list was always
readded by the mapper.
Bug-Url: https://bugzilla.redhat.com/1258389
Change-Id: I4fffc086f69f266623dec5091b28f5268cce4b52
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
(cherry picked from commit f1fb3e722ab9c748548f58e129a1080d68859f3d)
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java
2 files changed, 30 insertions(+), 11 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fffc086f69f266623dec5091b28f5268cce4b52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: make template - disable volume format for Cinder
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: make template - disable volume format for Cinder
......................................................................
webadmin: make template - disable volume format for Cinder
Disable volume format select-box for Cinder disks (as it's irrelevant).
Change-Id: I864db99f664f9cf2873162233ba35fc917da09e5
Bug-Url: https://bugzilla.redhat.com/1252969
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I864db99f664f9cf2873162233ba35fc917da09e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: adding QoS column to networks tab
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: adding QoS column to networks tab
......................................................................
engine: adding QoS column to networks tab
Adding a column in the network_view
The column is needed to display qos in the Networks
main tab
Change-Id: I99314acda36195fe708ca3c9f1d685f4cf08227f
Bug-Url: https://bugzilla.redhat.com/1180891
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkViewDaoImpl.java
M packaging/dbscripts/create_views.sql
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99314acda36195fe708ca3c9f1d685f4cf08227f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: adding QoS column to networks tab
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: adding QoS column to networks tab
......................................................................
webadmin: adding QoS column to networks tab
Adding a column in the Networks main tab for host QoS entity
for specific network
Change-Id: I797e83fda3bb961e17773cdc1ddb4f0834ea97d2
Bug-Url: https://bugzilla.redhat.com/1180891
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkView.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
3 files changed, 25 insertions(+), 0 deletions(-)
Approvals:
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I797e83fda3bb961e17773cdc1ddb4f0834ea97d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: ui: Grammar fix console connection denied: 'to not' -> 'not to'
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: ui: Grammar fix console connection denied: 'to not' -> 'not to'
......................................................................
ui: Grammar fix console connection denied: 'to not' -> 'not to'
Bug-Url: https://bugzilla.redhat.com/1080383
Change-Id: I0617118ca41d07c9e7964bdb40d4c84eea5f7918
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Shahar Havivi: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45524
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0617118ca41d07c9e7964bdb40d4c84eea5f7918
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: pki: pki-enroll-openssh-cert.sh: do not allow interactive pa...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: pki: pki-enroll-openssh-cert.sh: do not allow interactive passphrase prompt
......................................................................
pki: pki-enroll-openssh-cert.sh: do not allow interactive passphrase prompt
passphrase is done in older ssh-keygen implementation in any error
condition. for example, if ca key cannot be read a passphrase prompt
will be issued.
feeding empty passphrase will workaround this for now.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258365
Change-Id: I6da2a357b428778fa897392b48d06849ca8727e7
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/pki-enroll-openssh-cert.sh
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6da2a357b428778fa897392b48d06849ca8727e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: fixing error message length for attaching label to i...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: fixing error message length for attaching label to interface
......................................................................
engine: fixing error message length for attaching label to interface
Change-Id: I636c99e9e6088681f1f0155d50f44c1730b799ac
Bug-Url: https://bugzilla.redhat.com/1141512
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45514
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I636c99e9e6088681f1f0155d50f44c1730b799ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: Remove vm button is disabled in vms context menu if multiple...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Remove vm button is disabled in vms context menu if multiple vms selected
......................................................................
Remove vm button is disabled in vms context menu if multiple vms selected
Enable VMs removal if some of the selected VMs are down and not if all
VMs are down.
Change-Id: I8c5cb4bd46390b137917279756a2e77d4b6bbcf1
Bug-Url: https://bugzilla.redhat.com/1218527
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
1 file changed, 11 insertions(+), 10 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Passed CI tests
Shahar Havivi: Verified
--
To view, visit https://gerrit.ovirt.org/45519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5cb4bd46390b137917279756a2e77d4b6bbcf1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months