Change in ovirt-engine[master]: aaa: AuthRecord.VALID_TO should be Z timezone
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: AuthRecord.VALID_TO should be Z timezone
......................................................................
aaa: AuthRecord.VALID_TO should be Z timezone
Fix also extension documentation to match java format expectation to
avoid future mistakes.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258275
Change-Id: I282fdd4a1a2a197da9a4616c55066d200de62755
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
M backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authn.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45503
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I282fdd4a1a2a197da9a4616c55066d200de62755
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Extract addNetworksToPool
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Extract addNetworksToPool
......................................................................
core: Extract addNetworksToPool
Extracted common code from addManagementNetworksToPool and
addNonManagementNetworks to pool to the new addNetworksToPool method
that receives a boolean parameter to indicate whether the newly added
network is a management network or not.
Change-Id: I927840e6ffbc0f1b6b7447d987c93d3c4d0b81a5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45049
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I927840e6ffbc0f1b6b7447d987c93d3c4d0b81a5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Standardize imports
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Standardize imports
......................................................................
core: Standardize imports
Standardized the usages of Mockito.mock and Mockito.spy so they are both
imported statically, for consistency's sake.
Change-Id: I2d858a0f7879441492cc92affb305dbeaa193803
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45048
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d858a0f7879441492cc92affb305dbeaa193803
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Stop mocking sdList
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Stop mocking sdList
......................................................................
core: Stop mocking sdList
java.util.List is part of the JDK, and its implementations can be
trusted - There's no reason to mock it instead of using a concrete one.
Change-Id: I3c304a1d725be369a010e5c0ea5f76a2b117a222
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 4 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/45047
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c304a1d725be369a010e5c0ea5f76a2b117a222
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Move config mocking to the rule
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Move config mocking to the rule
......................................................................
core: Move config mocking to the rule
Placed the config mocking inline in the rule. This makes the test
both clearer to read (as all config mocking is at a single centralized
place) and faster (as it's only done once).
Change-Id: I9945da8994bb6065b82379c2880416c68e937060
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 17 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45046
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9945da8994bb6065b82379c2880416c68e937060
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: remove useless TODO comment
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: remove useless TODO comment
......................................................................
core: remove useless TODO comment
Change-Id: Ic66b040484620cac33cd1ab6fa110998688ea5ed
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45045
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic66b040484620cac33cd1ab6fa110998688ea5ed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Remove AttachDomainValidatorForTesting
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove AttachDomainValidatorForTesting
......................................................................
core: Remove AttachDomainValidatorForTesting
Removed AttachDomainValidatorForTesting and replaced the way it handled
DAO mocks with direct mocking.
This test was too "deep" - UpdateStoragePoolCommandTest should test the
logic in UpdateStoragePoolCommand, not the logic in the validators it
uses.
Change-Id: I0e56d2963ec95453a34e3991714a5eb1f94b65c2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 5 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45131
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e56d2963ec95453a34e3991714a5eb1f94b65c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Remove StoragePoolValidatorForTesting
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove StoragePoolValidatorForTesting
......................................................................
core: Remove StoragePoolValidatorForTesting
Removed StoragePoolValidatorForTesting and replaced the way it handled
DAO mocks with direct mocking.
This test was too "deep" - UpdateStoragePoolCommandTest should test the
logic in UpdateStoragePoolCommand, not the logic in the validators it
uses.
Change-Id: Iae0602e65c66becd3353deb97d4152b619b8587a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 9 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45130
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae0602e65c66becd3353deb97d4152b619b8587a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Remove hard-coded Guids
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove hard-coded Guids
......................................................................
core: Remove hard-coded Guids
Removed hard-coded Guid values that contain no meaning. Using
Guid.newGuid() is less distracting to the reader, and makes the test
more robust.
Change-Id: I74eee93249ec03b6d31826ed1b3ed06f1c2ba686
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74eee93249ec03b6d31826ed1b3ed06f1c2ba686
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: Remove allDcNetworks member
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove allDcNetworks member
......................................................................
core: Remove allDcNetworks member
Removed the allDcNetworks member - it has nothing to do with the class'
state, and should just be a local variable.
Change-Id: Ifb96b6ff6741d79245fbe83b33b420103ccefed2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45050
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb96b6ff6741d79245fbe83b33b420103ccefed2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months