August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: Reboot button is disabled in vm context menu if multiple vms...
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: Reboot button is disabled in vm context menu if multiple vms selected ...................................................................... Reboot button is disabled in vm context menu if multiple vms selected Enable some of the VMs to reboot if not all of the VMs are rebootable. Currently one need to select all VMs that can be reboot for multiple reboots. Bug-Url: https://bugzilla.redhat.com/1218541 Change-Id: Ie5a7e04f91be719d703ba1db2f29953ada706f5a Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Shahar Havivi: Verified -- To view, visit https://gerrit.ovirt.org/45518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5a7e04f91be719d703ba1db2f29953ada706f5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: ui: fix cloud-init password hover text
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: ui: fix cloud-init password hover text ...................................................................... ui: fix cloud-init password hover text Removing the 'root' from the test since a regular user can be created via cloud init. Change-Id: Ic922d4f39784c348f53a923ad77fd831fba5acbf Bug-Url: https://bugzilla.redhat.com/1248838 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Shahar Havivi: Verified -- To view, visit https://gerrit.ovirt.org/45517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic922d4f39784c348f53a923ad77fd831fba5acbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: validate MTU against any non-VLAN network
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: validate MTU against any non-VLAN network ...................................................................... engine: validate MTU against any non-VLAN network Validate MTU against any non-VLAN network Change-Id: I9025787776fe6f567c94fe7b66a235c2f81229f5 Bug-Url: https://bugzilla.redhat.com/1242227 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> (cherry picked from commit 595a1feae929bcd4cd7a93a2e589669cbe4ad289) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidatorTest.java 2 files changed, 17 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9025787776fe6f567c94fe7b66a235c2f81229f5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Allow a VM trunk network be mixed with VLAN tagged...
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow a VM trunk network be mixed with VLAN tagged ones ...................................................................... webadmin: Allow a VM trunk network be mixed with VLAN tagged ones Allow a VM trunk network be mixed with VLAN tagged ones in Setup host networks dialog. Change-Id: Id31c89d360b3e50b85cc24811a84cf884008e9e0 Bug-Url: https://bugzilla.redhat.com/1227865 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java 3 files changed, 22 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31c89d360b3e50b85cc24811a84cf884008e9e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Allow a VM trunk network be mixed with VLAN tagged ones
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Allow a VM trunk network be mixed with VLAN tagged ones ...................................................................... engine: Allow a VM trunk network be mixed with VLAN tagged ones Allow a VM trunk network be mixed with VLAN tagged ones. The new permissive validation is supported for a 3.6+ hosts only. The patch includes refactoring that allows sharing the same validation code between the legacy flow and the new network attachements flavor. Change-Id: I3f0b52ad6bb91947848cb03d516b2b014f876769 Bug-Url: https://bugzilla.redhat.com/1227865 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/LegacyNetworkExclusivenessValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkExclusivenessValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkExclusivenessValidatorResolver.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkType.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/UntaggedNetworkPredicate.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/LegacyNetworkExclusivenessValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/NetworkExclusivenessValidatorResolverTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/UntaggedNetworkPredicateTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 25 files changed, 672 insertions(+), 122 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f0b52ad6bb91947848cb03d516b2b014f876769 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: ui: Console/ConsoleOptions multiple selections
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: ui: Console/ConsoleOptions multiple selections ...................................................................... ui: Console/ConsoleOptions multiple selections Console button should be enable for multiple VMs. Console Options (from the context menu) need only to be enabled for a single VM. Change-Id: If9cca6aba93304cabd197353556d6729d2c07363 Bug-Url: https://bugzilla.redhat.com/1217446 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9cca6aba93304cabd197353556d6729d2c07363 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Disable management radio button for non-required n...
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disable management radio button for non-required networks. ...................................................................... webadmin: Disable management radio button for non-required networks. Change-Id: Ice0d0542940d951e5fe401d2bda9c9c73013217d Bug-Url: https://bugzilla.redhat.com/1252681 Signed-off-by: yingyun001 <zhangyingyun001(a)gmail.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0d0542940d951e5fe401d2bda9c9c73013217d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Remove @Path from storage connection extension impl...
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Remove @Path from storage connection extension implementation ...................................................................... restapi: Remove @Path from storage connection extension implementation Currently the implementation of the connection extension resource contains a @Path annotation. This annotation is incorrect, as this kind of annotation should go only in the interface, not in the implementation. In addition the annotation value is "/whatever" and that is incorrect as well because this isn't a top level resource. This incorrect annotation induces an error in the version of Resteasy included in JBoss EAP. This patch removes the annotation. Change-Id: Ia3e7b8876417e2437db8f1ddd55ea633d32ae918 Bug-Url: https://bugzilla.redhat.com/1258247 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionsResource.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3e7b8876417e2437db8f1ddd55ea633d32ae918 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix PUT on host pinning update
by juan.hernandez＠redhat.com 31 Aug '15

31 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix PUT on host pinning update ...................................................................... restapi: Fix PUT on host pinning update Only adding new hosts to the pinned to host list for a VM was possible. Removing hosts had no effect at all because the original list was always readded by the mapper. Bug-Url: https://bugzilla.redhat.com/1258389 Change-Id: I4fffc086f69f266623dec5091b28f5268cce4b52 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 2 files changed, 30 insertions(+), 11 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Roman Mohr: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fffc086f69f266623dec5091b28f5268cce4b52 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove @Path from storage connection extension impl...
by tnisan＠redhat.com 31 Aug '15

31 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Remove @Path from storage connection extension implementation ...................................................................... restapi: Remove @Path from storage connection extension implementation Currently the implementation of the connection extension resource contains a @Path annotation. This annotation is incorrect, as this kind of annotation should go only in the interface, not in the implementation. In addition the annotation value is "/whatever" and that is incorrect as well because this isn't a top level resource. This incorrect annotation induces an error in the version of Resteasy included in JBoss EAP. This patch removes the annotation. Change-Id: Ia3e7b8876417e2437db8f1ddd55ea633d32ae918 Bug-Url: https://bugzilla.redhat.com/1258247 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionsResource.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3e7b8876417e2437db8f1ddd55ea633d32ae918 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0