August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder
by tnisan＠redhat.com 17 Aug '15

17 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder ...................................................................... webadmin: Fix of NPE in DedicatedVmForVdsUnitToVmBaseBuilder UnitVmModel#defaultHost was (not completely) refactored to allow selection of multiple hosts to pin to. VmModelBehaviorBase#updateDefaultHost() still worked with ListModel#selectedItem instead of #selectedItems. This caused NPE in DedicatedVmForVdsUnitToVmBaseBuilder. Change-Id: I36d73f5b301e71b0baf09c4bcef1d20a7379fed8 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1247932 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/TakesConstrainedValueListEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 17 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d73f5b301e71b0baf09c4bcef1d20a7379fed8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: aaa, userportal : in case there is no password (nego) disabl...
by tnisan＠redhat.com 17 Aug '15

17 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: aaa, userportal : in case there is no password (nego) disable automatic login feature ...................................................................... aaa, userportal : in case there is no password (nego) disable automatic login feature If password is empty as is the case with external authentication, should not connect authomatically to VM console. Change-Id: If89f9085c8120734aa4dce6cd1277b06f357e685 Bug-Url: https://bugzilla.redhat.com/1211511 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 4 files changed, 45 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If89f9085c8120734aa4dce6cd1277b06f357e685 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: change the return value of getExternalVmFromOva
by ahadas＠redhat.com 17 Aug '15

17 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: core: change the return value of getExternalVmFromOva ...................................................................... core: change the return value of getExternalVmFromOva VDSM now returns a VM, instead of a list with one VM, from getExternalVmFromOva. This patch changes the engine accordingly. Change-Id: Ie0b9bd2bcdb65fc4a53dfa3d1069dd64690b010a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetOvaInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 4 files changed, 10 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0b9bd2bcdb65fc4a53dfa3d1069dd64690b010a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: rename ova related verbs
by ahadas＠redhat.com 17 Aug '15

17 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: core: rename ova related verbs ...................................................................... core: rename ova related verbs The verbs for list and convert virtual appliance were renamed in VDSM, therefore this patch updates them in the engine. Change-Id: If65fb591f5a98322c3643a5f0502e5d45e079f58 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConvertOvaVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetOvaInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 16 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65fb591f5a98322c3643a5f0502e5d45e079f58 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: services: add option to open jmx to world
by tnisan＠redhat.com 17 Aug '15

17 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: services: add option to open jmx to world ...................................................................... packaging: services: add option to open jmx to world Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254118 Change-Id: Ic4ddd7307289ef63aadd3d238e3ba3aedc571cb5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4ddd7307289ef63aadd3d238e3ba3aedc571cb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa, userportal : in case there is no password (nego) disabl...
by masayag＠redhat.com 17 Aug '15

17 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: aaa, userportal : in case there is no password (nego) disable automatic login feature ...................................................................... aaa, userportal : in case there is no password (nego) disable automatic login feature If password is empty as is the case with external authentication, should not connect authomatically to VM console. Change-Id: If89f9085c8120734aa4dce6cd1277b06f357e685 Bug-Url: https://bugzilla.redhat.com/1211511 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 4 files changed, 45 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If89f9085c8120734aa4dce6cd1277b06f357e685 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: scheduler: Formatter treatment for AffinityRulesEnforcementM...
by rgolan＠redhat.com 17 Aug '15

17 Aug '15

Roy Golan has submitted this change and it was merged. Change subject: scheduler: Formatter treatment for AffinityRulesEnforcementManager ...................................................................... scheduler: Formatter treatment for AffinityRulesEnforcementManager Change-Id: I9829971bdd387a83b526c5b7306fdba25d03a3e1 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java 3 files changed, 54 insertions(+), 58 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9829971bdd387a83b526c5b7306fdba25d03a3e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Setting gerrit server as a parameter
by dcaroest＠redhat.com 17 Aug '15

17 Aug '15

David Caro has submitted this change and it was merged. Change subject: Setting gerrit server as a parameter ...................................................................... Setting gerrit server as a parameter Added also the default. Using the gerrit template in all the gerrit-based scms, eases the maintenance and removes a lot of code duplication Side issues fixes: * Fixes a minor typo with the releng jobs * Fixes wrong branch on node jobs (it was not expanded) * Pin the triggers to the us gerrit server (so we might be able to add another server without having it trigger jobs) * As all the jobs use the gerrit template, all apply the same defaults when clonning the repo (in specific, cleaning the repo before checkout) Change-Id: I4488146c460f15b813e89c761abfa95ed85fb3aa Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/defaults.yaml M jobs/confs/projects/jenkins/jenkins_check_yaml.yaml M jobs/confs/projects/jenkins/jenkins_deploy_yamls.yaml M jobs/confs/yaml/scms/fabric-ovirt.yaml M jobs/confs/yaml/scms/gerrit.yaml M jobs/confs/yaml/scms/infra-docs.yaml M jobs/confs/yaml/scms/ioprocess.yaml M jobs/confs/yaml/scms/jenkins.yaml M jobs/confs/yaml/scms/mom.yaml M jobs/confs/yaml/scms/otopi.yaml M jobs/confs/yaml/scms/ovirt-dwh.yaml M jobs/confs/yaml/scms/ovirt-engine-extension-aaa-jdbc.yaml M jobs/confs/yaml/scms/ovirt-engine-extension-aaa-ldap.yaml M jobs/confs/yaml/scms/ovirt-engine-extension-aaa-misc.yaml M jobs/confs/yaml/scms/ovirt-engine-extension-logger-log4j.yaml M jobs/confs/yaml/scms/ovirt-engine-sdk-java.yaml M jobs/confs/yaml/scms/ovirt-engine-sdk.yaml M jobs/confs/yaml/scms/ovirt-engine.yaml M jobs/confs/yaml/scms/ovirt-guest-agent.yaml M jobs/confs/yaml/scms/ovirt-host-deploy.yaml M jobs/confs/yaml/scms/ovirt-hosted-engine-ha.yaml M jobs/confs/yaml/scms/ovirt-hosted-engine-setup.yaml M jobs/confs/yaml/scms/ovirt-image-uploader.yaml M jobs/confs/yaml/scms/ovirt-iso-uploader.yaml M jobs/confs/yaml/scms/ovirt-live.yaml M jobs/confs/yaml/scms/ovirt-log-collector.yaml M jobs/confs/yaml/scms/ovirt-node-scms.yaml M jobs/confs/yaml/scms/ovirt-register-scms.yaml M jobs/confs/yaml/scms/ovirt-reports.yaml M jobs/confs/yaml/scms/ovirt-setup-lib.yaml M jobs/confs/yaml/scms/ovirt-wgt-toolchain.yaml M jobs/confs/yaml/scms/pthreading.yaml M jobs/confs/yaml/scms/releng-tools.yaml M jobs/confs/yaml/scms/repoman.yaml M jobs/confs/yaml/scms/vdsm-jsonrpc-java.yaml M jobs/confs/yaml/scms/vdsm.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/templates/engine-upgrade-db.yaml M jobs/confs/yaml/templates/install-rpm-sanity.yaml M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml M jobs/confs/yaml/templates/standard-stage.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml M jobs/confs/yaml/triggers/gerrit.yaml M jobs/confs/yaml/triggers/ovirt-node.yaml M jobs/confs/yaml/triggers/standard.yaml 45 files changed, 207 insertions(+), 479 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/44643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4488146c460f15b813e89c761abfa95ed85fb3aa Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: services: add option to open jmx to world
by sbonazzo＠redhat.com 17 Aug '15

17 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: services: add option to open jmx to world ...................................................................... packaging: services: add option to open jmx to world Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254118 Change-Id: Ic4ddd7307289ef63aadd3d238e3ba3aedc571cb5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4ddd7307289ef63aadd3d238e3ba3aedc571cb5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: 'Specific' radiobutton controlled by its label
by tjelinek＠redhat.com 17 Aug '15

17 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: 'Specific' radiobutton controlled by its label ...................................................................... webadmin: 'Specific' radiobutton controlled by its label 'Specific' radio button in New VM dialog > Host tab is controlled by its label. Change-Id: I3f129331a763d441e573029e002fb39d3e8d1317 Bug-Url: https://bugzilla.redhat.com/1253440 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f129331a763d441e573029e002fb39d3e8d1317 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0