August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid disks lock check on create snapshot while LSM
by derez＠redhat.com 11 Aug '15

11 Aug '15

Daniel Erez has submitted this change and it was merged. Change subject: core: avoid disks lock check on create snapshot while LSM ...................................................................... core: avoid disks lock check on create snapshot while LSM Restored the logic [*] that ignores locked disks while performing LSM (on CreateAllSnapshotsFromVmCommand). [*] logic removed on: - I9f42f387781425d16f53a0e8a34d859365808ec0 - I085d49dc90053e375f829900c75d2fe72c263161 Change-Id: I8eaf480f9ac855f48cc93066e9c849052865cef5 Bug-Url: https://bugzilla.redhat.com/1251956 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java 2 files changed, 29 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Vered Volansky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eaf480f9ac855f48cc93066e9c849052865cef5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Allow VM disks editing after enabling quota on data ce...
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow VM disks editing after enabling quota on data center ...................................................................... core: Allow VM disks editing after enabling quota on data center Diagnostics: ------------ After enabling quota on data center. The recent quota id for a disk (in the database) is null. And the current quota id from GUI has value (current quota id = the selected quota in the list box). CanDoAction in UpdateVmDiskCommand prevent change to quota id while vm is running (rightfully). Therefore detects quota id change: for existing disks after quota is enabled in data center. Short term solution: ------------------- If recent quota id on disk is null always assume there is no change to quota id. Long term solution: ------------------- Define a policy for disks with un-initilized quota. Change-Id: Iff9c01b853f8d2a8897866cfe36f734eef179310 Bug-Url: https://bugzilla.redhat.com/1193643 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff9c01b853f8d2a8897866cfe36f734eef179310 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: disallow redeploy on dirty storage
by sbonazzo＠redhat.com 11 Aug '15

11 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: disallow redeploy on dirty storage ...................................................................... packaging: setup: disallow redeploy on dirty storage In the past we had the capability to re-deploy hosted-engine over a previously partially deployed system; the trick was simply to let the user boot the VM from CD and than exit without touching the engine VM disk and than continue frm there. With the appliance it doesn't make sense cause it will always overwrite the previously deployed one destroying it. Explicitly disable it to prevent confusion. Change-Id: I3a2a1ab7b74450ad9341bd6d3e7694d99c97f5da Bug-Url: https://bugzilla.redhat.com/1238709 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/44675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a2a1ab7b74450ad9341bd6d3e7694d99c97f5da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: assertStorageServerConnectionExtensionEquality
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: assertStorageServerConnectionExtensionEquality ...................................................................... core: assertStorageServerConnectionExtensionEquality Removed this useless method that just delegated to assertEquals. Bug-Url: https://bugzilla.redhat.com/1239266 Change-Id: Ia6a34a22d80e0a66cdadc98e8ab3b172d1870b05 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionExtensionDaoTest.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6a34a22d80e0a66cdadc98e8ab3b172d1870b05 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: avoid assumption on answerfile
by sbonazzo＠redhat.com 11 Aug '15

11 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid assumption on answerfile ...................................................................... packaging: setup: avoid assumption on answerfile Avoid assuming that the CLI added answerfile was by sure correctly and completely generated on the first host. Node is always appending a partial answerfile. Change-Id: Icf4a31fbc658fcb5fe1036be0c67aac9685905ae Bug-Url: https://bugzilla.redhat.com/1249514 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py 1 file changed, 37 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/44240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf4a31fbc658fcb5fe1036be0c67aac9685905ae Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: StorageServerConnectionExtensionDaoTest#testUpdate()
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: StorageServerConnectionExtensionDaoTest#testUpdate() ...................................................................... core: StorageServerConnectionExtensionDaoTest#testUpdate() Added an assertion to make this test actually test something. Change-Id: Ie378379298c2391664cb56efa85232527b4d8119 Bug-Url: https://bugzilla.redhat.com/1239266 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionExtensionDaoTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie378379298c2391664cb56efa85232527b4d8119 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: ConnectionExtensions resource tests+rsdl metadata
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: ConnectionExtensions resource tests+rsdl metadata ...................................................................... restapi: ConnectionExtensions resource tests+rsdl metadata Adding tests and updating rsdl file to support connection extensions. Change-Id: I4c63f1d4beb6a0d6530dce1231ec6068f67650f1 Bug-Url: https://bugzilla.redhat.com/1239266 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/StorageConnectionExtensionResourceTestHelper.java 4 files changed, 258 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c63f1d4beb6a0d6530dce1231ec6068f67650f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Add support for storage connection extension
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add support for storage connection extension ...................................................................... restapi: Add support for storage connection extension Bug-Url: https://bugzilla.redhat.com/1239266 Change-Id: I27293ed69d00e485f947653df542437089bf9219 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionExtensionResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionExtensionsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionExtensionsResource.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageServerConnectionExtensionMapper.java 10 files changed, 261 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27293ed69d00e485f947653df542437089bf9219 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Determine target connection host specific
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Determine target connection host specific ...................................................................... core: Determine target connection host specific Since we now have a mechnism to set up host specific target connection credentials they will be used when connecting a host to a target, if a host specific credentials exist for the target to connect to, those credentials will be sent, if not then the regular credentials will be sent. Change-Id: Id899afb94468356fbc760e6c4ad6f3ceed06bfde Bug-Url: https://bugzilla.redhat.com/1239266 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelperTest.java 4 files changed, 175 insertions(+), 36 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/44591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id899afb94468356fbc760e6c4ad6f3ceed06bfde Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add backend support for storage connection extension
by tnisan＠redhat.com 11 Aug '15

11 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add backend support for storage connection extension ...................................................................... core: Add backend support for storage connection extension Bug-Url: https://bugzilla.redhat.com/1239266 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I4edd54932886cbf8898210b1e3dad86d80798108 --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionExtensionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionExtensionByIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageServerConnectionExtensionsByHostIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionExtensionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionExtensionCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionExtensionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageServerConnectionExtensionValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageServerConnectionExtensionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 18 files changed, 337 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/44590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4edd54932886cbf8898210b1e3dad86d80798108 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0