August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core:refactor: Refactor code to be reused in future patch
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core:refactor: Refactor code to be reused in future patch ...................................................................... core:refactor: Refactor code to be reused in future patch Move addMessageToAuditLog method from CINDERStorageHelper to StorageHelperBase so it can be used in future patches. Change-Id: I7a02b2cfe66abe7feb7bf275458a635aee714361 Signed-off-by: Ala Hino <ahino(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1183318 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/45486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a02b2cfe66abe7feb7bf275458a635aee714361 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: translations update (de-DE only)
by ecohen＠redhat.com 30 Aug '15

30 Aug '15

Einav Cohen has submitted this change and it was merged. Change subject: webadmin, userportal: translations update (de-DE only) ...................................................................... webadmin, userportal: translations update (de-DE only) pulled translation from Zanata oVirt project, master version. [ovirt-3.6, translation cycle 3 "leftovers", de-DE only] de-DE translations are updated here, separately from the other locales, to allow backport to ovirt-3.5, required by BZ#1218706. Change-Id: I6af1c01d422d2606b797a139d7e272c24e03c7b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128426 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_de_DE.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_de_DE.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_de_DE.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_de_DE.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_de_DE.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_de_DE.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_de_DE.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_de_DE.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_de_DE.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_de_DE.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_de_DE.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_de_DE.properties M packaging/branding/ovirt.brand/messages_de_DE.properties 13 files changed, 1,090 insertions(+), 306 deletions(-) Approvals: Jenkins CI: Passed CI tests Einav Cohen: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af1c01d422d2606b797a139d7e272c24e03c7b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin, userportal: translations update (excluding de-DE)
by ecohen＠redhat.com 30 Aug '15

30 Aug '15

Einav Cohen has submitted this change and it was merged. Change subject: webadmin, userportal: translations update (excluding de-DE) ...................................................................... webadmin, userportal: translations update (excluding de-DE) pulled translation from Zanata oVirt project, master version. [ovirt-3.6, translation cycle 3 "leftovers", excluding de-DE] de-DE translations will be updated in a separate patch, to allow backport to ovirt-3.5, required by BZ#1218706. Change-Id: I6f38ded2dd095e5dfaa69ee4f0901484ea5037fd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251723 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ko_KR.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_zh_CN.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ko_KR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_pt_BR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ko_KR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_ko_KR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/ConsoleErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ja_JP.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ko_KR.properties 12 files changed, 658 insertions(+), 381 deletions(-) Approvals: Jenkins CI: Passed CI tests Einav Cohen: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f38ded2dd095e5dfaa69ee4f0901484ea5037fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: etl: removed fk that cause deadlock occasionally
by ydary＠redhat.com 30 Aug '15

30 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: etl: removed fk that cause deadlock occasionally ...................................................................... etl: removed fk that cause deadlock occasionally Deadlock in user sync causes failures in collections and aggregation. The users details sync is done every minute locking the row for update, once a hour the hourly aggregation tries to sync VM data containing users foreign key which causes deadlock due to wait on the users table update. To pervent for now we will drop fk. Change-Id: I895df0b263291e1b3d63284e671d9fcc092badc5 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1254003 --- A packaging/dbscripts/upgrade/03_05_0080_remove_fk_to_users_table.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I895df0b263291e1b3d63284e671d9fcc092badc5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: etl: removed fk that cause deadlock occasionally
by ydary＠redhat.com 30 Aug '15

30 Aug '15

Yaniv Dary has submitted this change and it was merged. Change subject: etl: removed fk that cause deadlock occasionally ...................................................................... etl: removed fk that cause deadlock occasionally Deadlock in user sync causes failures in collections and aggregation. The users details sync is done every minute locking the row for update, once a hour the hourly aggregation tries to sync VM data containing users foreign key which causes deadlock due to wait on the users table update. To pervent for now we will drop fk. Change-Id: I00b2eeb15f5a2b983a5072a837409735667b9e42 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1254003 --- A packaging/dbscripts/upgrade/03_06_0060_remove_fk_to_users_table.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Yaniv Dary: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00b2eeb15f5a2b983a5072a837409735667b9e42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: retrieve and store glusterfs-cli package version
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: retrieve and store glusterfs-cli package version ...................................................................... core: retrieve and store glusterfs-cli package version Retrieving 'glusterfs-cli' package version from vdsm (getCapabilities), and stores its value in VdsDynamic. Change-Id: I373a0de2feea9a384f2abf8400de29c530984d46 Bug-Url: https://bugzilla.redhat.com/1183318 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_1790_add_glusterfs_cli_version_to_vds_dynamic.sql M packaging/dbscripts/vds_sp.sql 9 files changed, 36 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/45485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373a0de2feea9a384f2abf8400de29c530984d46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Compensation of active snapshot ID change
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Compensation of active snapshot ID change ...................................................................... core: Compensation of active snapshot ID change If exception is thrown inside CreateAllSnapshotsFromVmCommand, we need to compensate the change of active snapshot ID that is performed during snapshot creation. Otherwise, link between disk images and the active snapshot is lost. Change-Id: I432859105d31f74f10711f6a63b188d325a43e30 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1236061 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I432859105d31f74f10711f6a63b188d325a43e30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Disable management radio button for non-required n...
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disable management radio button for non-required networks. ...................................................................... webadmin: Disable management radio button for non-required networks. Change-Id: Ice0d0542940d951e5fe401d2bda9c9c73013217d Bug-Url: https://bugzilla.redhat.com/1252681 Signed-off-by: yingyun001 <zhangyingyun001(a)gmail.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, but someone else must approve Eliraz Levi: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0d0542940d951e5fe401d2bda9c9c73013217d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: zhangyingyun001(a)gmail.com Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: invoke RemoveAllVmCinderDisks only when relevant
by derez＠redhat.com 30 Aug '15

30 Aug '15

Daniel Erez has submitted this change and it was merged. Change subject: core: invoke RemoveAllVmCinderDisks only when relevant ...................................................................... core: invoke RemoveAllVmCinderDisks only when relevant Invoking RemoveAllVmCinderDisks only when Cinder disks exist. Change-Id: I82e387416c0b9d0e04c6c372424a69bca22c7968 Bug-Url: https://bugzilla.redhat.com/1258195 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82e387416c0b9d0e04c6c372424a69bca22c7968 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: missing db tests
by alkaplan＠redhat.com 30 Aug '15

30 Aug '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: missing db tests ...................................................................... core: missing db tests test for: • NetworkAttachmentDao.getAllForNetwork • NetworkAttachmentDao.getNetworkAttachmentByNicIdAndNetworkId Change-Id: Ib2bac081c2db5de39aa978215db77f6b0e9120b2 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoTest.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2bac081c2db5de39aa978215db77f6b0e9120b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0