Change in ovirt-engine[master]: core: Standardize canDoAction() assertions
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Standardize canDoAction() assertions
......................................................................
core: Standardize canDoAction() assertions
Used the standard CanDoActionTestUtils assertions for better debug
printing and to reduce redundant code.
Change-Id: I8ad3febedb1acb4a84149a986521e3701c1a13a9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
1 file changed, 17 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ad3febedb1acb4a84149a986521e3701c1a13a9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: ExportRepoImage - persistAsyncTask
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: ExportRepoImage - persistAsyncTask
......................................................................
core: ExportRepoImage - persistAsyncTask
ExportRepoImage: use 'persistAsyncTaskPlaceHolder' instead of
'getAsyncTaskId' to ensure proper clearance of tasks (see BZ for
details).
Change-Id: I05b03d0659fb07d4041173cf95d07a3509f4e306
Bug-Url: https://bugzilla.redhat.com/1216019
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05b03d0659fb07d4041173cf95d07a3509f4e306
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin, userportal: translations update (excluding de-DE)
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin, userportal: translations update (excluding de-DE)
......................................................................
webadmin, userportal: translations update (excluding de-DE)
pulled translation from Zanata oVirt project, master version.
[ovirt-3.6, translation cycle 3 "leftovers", excluding de-DE]
[at this point, there is still no 'ovirt-3.6' version in
Zanata; translations pulled here are of source strings pushed
before ovirt-engine-3.6 was forked out of master, so strings
here should be valid for both master and ovirt-engine-3.6]
de-DE translations will be updated in a separate patch, to
allow backport to ovirt-3.5, required by BZ#1218706.
Change-Id: I6f38ded2dd095e5dfaa69ee4f0901484ea5037fd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251723
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_zh_CN.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ko_KR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_pt_BR.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ko_KR.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_ko_KR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/ConsoleErrors_zh_CN.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_zh_CN.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ja_JP.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ko_KR.properties
12 files changed, 658 insertions(+), 381 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f38ded2dd095e5dfaa69ee4f0901484ea5037fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: core: check glusterfs-cli package availability on vds activa...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: check glusterfs-cli package availability on vds activation
......................................................................
core: check glusterfs-cli package availability on vds activation
Validate glusterfs-cli package availability on
ConnectHostToStoragePoolServersCommand.
Change-Id: I4a21d61f877423cf212bab4e90ce3da3d08cdc37
Bug-Url: https://bugzilla.redhat.com/1183318
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GLUSTERFSStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
7 files changed, 60 insertions(+), 24 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a21d61f877423cf212bab4e90ce3da3d08cdc37
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: core:refactor: Move cinder logic to CINDERStorageHelper
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core:refactor: Move cinder logic to CINDERStorageHelper
......................................................................
core:refactor: Move cinder logic to CINDERStorageHelper
Move cinder specific logic performed when connecting host
to storage pool to CINDERStorageHelper instead of having it
in ConnectHostToStoragePoolServersCommand.
Change-Id: I67cf676681ffc29727b3318a33f476d4ca90a9ec
Signed-off-by: Ala Hino <ahino(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1183318
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
5 files changed, 98 insertions(+), 84 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45492
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67cf676681ffc29727b3318a33f476d4ca90a9ec
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: core:refactor: Add IStorageHelper.disconnectHostFromStorageP...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core:refactor: Add IStorageHelper.disconnectHostFromStoragePoolServersCommandCompleted
......................................................................
core:refactor: Add IStorageHelper.disconnectHostFromStoragePoolServersCommandCompleted
New IStorageHelper.disconnectHostFromStoragePoolServersCommandCompleted added.
This is a more generic way to perform logic after command execution completed.
Change-Id: Id66a258e25cc000588bdbf7b416529a9eb4bbd8a
Signed-off-by: Ala Hino <ahino(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1183318
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
5 files changed, 33 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id66a258e25cc000588bdbf7b416529a9eb4bbd8a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: core:refactor: Add IStorageHelper.prepareDisconnectHostFromS...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core:refactor: Add IStorageHelper.prepareDisconnectHostFromStoragePoolServers
......................................................................
core:refactor: Add IStorageHelper.prepareDisconnectHostFromStoragePoolServers
New IStorageHelper.prepareDisconnectHostFromStoragePoolServers added.
This methos is called when disconnecting storage server.
Change-Id: I0b9bc5f368060b4014c697d6a44d96e656b0dbd4
Signed-off-by: Ala Hino <ahino(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1183318
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
4 files changed, 20 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b9bc5f368060b4014c697d6a44d96e656b0dbd4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: core:refactor: Add IStorageHelper.prepareConnectHostToStorag...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core:refactor: Add IStorageHelper.prepareConnectHostToStoragePoolServers
......................................................................
core:refactor: Add IStorageHelper.prepareConnectHostToStoragePoolServers
New prepareConnectHostToStoragePoolServers added to IStorageHelper.
This method will be invoked when connecting storage servers.
Change-Id: I0eac1d74d409657bda7d84519b6ade7aa76187b3
Signed-off-by: Ala Hino <ahino(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1183318
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java
4 files changed, 18 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0eac1d74d409657bda7d84519b6ade7aa76187b3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: core:refactor: Split logic to new method
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core:refactor: Split logic to new method
......................................................................
core:refactor: Split logic to new method
Split isActiveCinderDomainAvailable to new method so it can
be used in future patch.
Change-Id: Ifc9010ec53a6cd4faa94eb8d71e3cbceb8e3293e
Signed-off-by: Ala Hino <ahino(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1183318
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc9010ec53a6cd4faa94eb8d71e3cbceb8e3293e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: gluster: Add validation when connecting gluster SD
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: gluster: Add validation when connecting gluster SD
......................................................................
gluster: Add validation when connecting gluster SD
When connecting gluster SD, we added a check to verify that glusterfs-cli
package is installed on host.
This validation is required because in 3.6, we use glusterVolumeInfo
API which is defined in glusterfs-cli package.
Change-Id: Iab95cd5e5190fa9614f97df23accdb7d958fffca
Bug-Url: https://bugzilla.redhat.com/1183318
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GLUSTERFSStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageConnectionValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
13 files changed, 96 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/45487
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab95cd5e5190fa9614f97df23accdb7d958fffca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months