September 2015 - Engine-commits - oVirt List Archives

Change in jenkins[master]: mock_runner: add fedora 23 support
by dcaroest＠redhat.com 25 Sep '15

25 Sep '15

David Caro has submitted this change and it was merged. Change subject: mock_runner: add fedora 23 support ...................................................................... mock_runner: add fedora 23 support Change-Id: Ia4ec6b969a1483328330f7dea86b06be52c86183 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A mock_configs/fedora-23-x86_64.cfg A mock_configs/fedora-23-x86_64_proxied.cfg M mock_configs/mock_runner.sh 3 files changed, 138 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge Max Kovgan: Looks good to me -- To view, visit https://gerrit.ovirt.org/46353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4ec6b969a1483328330f7dea86b06be52c86183 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use "Integer.toString" in "HSMGetStorageDomainsListVDS...
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.toString" in "HSMGetStorageDomainsListVDSCommand" ...................................................................... core: Use "Integer.toString" in "HSMGetStorageDomainsListVDSCommand" This is needed in order to avoid the following findbugs error: Method allocates a boxed primitive just to call toString A boxed primitive is allocated just to call toString(). It is more effective to just use the static form of toString which takes the primitive value. So, Replace... With this... new Integer(1).toString() Integer.toString(1) new Long(1).toString() Long.toString(1) new Float(1.0).toString() Float.toString(1.0) new Double(1.0).toString() Double.toString(1.0) new Byte(1).toString() Byte.toString(1) new Short(1).toString() Short.toString(1) new Boolean(true).toString() Boolean.toString(true) Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_TOSTRING Change-Id: I2612b3ed9f06f4a54e738e70ab133ce1bdda916c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainsListVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2612b3ed9f06f4a54e738e70ab133ce1bdda916c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseXXX" in "VdsBrokerObjectsBuilder"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseXXX" in "VdsBrokerObjectsBuilder" ...................................................................... core: Use "parseXXX" in "VdsBrokerObjectsBuilder" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: If551b1372c6cfba899fc3aecc03ed87313eb53db Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If551b1372c6cfba899fc3aecc03ed87313eb53db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseXXX" in "GlusterVolumeTaskReturnForXmlRpc"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseXXX" in "GlusterVolumeTaskReturnForXmlRpc" ...................................................................... core: Use "parseXXX" in "GlusterVolumeTaskReturnForXmlRpc" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ie340965808981fa5f27225f9bd8b957cebafff01 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie340965808981fa5f27225f9bd8b957cebafff01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseXXX" in "GlusterVolumeStatusReturnForXmlRpc"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseXXX" in "GlusterVolumeStatusReturnForXmlRpc" ...................................................................... core: Use "parseXXX" in "GlusterVolumeStatusReturnForXmlRpc" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Icdf19dfa81769ae752967590171e55d457ba93c2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java 1 file changed, 26 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdf19dfa81769ae752967590171e55d457ba93c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "parseInt" and "parseLong" in "GlusterVolumeProfil...
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "parseInt" and "parseLong" in "GlusterVolumeProfileInfoReturnForXmlRpc" ...................................................................... core: Use "parseInt" and "parseLong" in "GlusterVolumeProfileInfoReturnForXmlRpc" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ia924318483fe1315fc4794c768d1fa7a9a995ffd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46599 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia924318483fe1315fc4794c768d1fa7a9a995ffd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "OvfReader"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "OvfReader" ...................................................................... core: Use "Integer.parseInt" in "OvfReader" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ic40a4a6769a5c532977c3ca75e30ed4a4c7b87d3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic40a4a6769a5c532977c3ca75e30ed4a4c7b87d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "VmDeviceType"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "VmDeviceType" ...................................................................... core: Use "Integer.parseInt" in "VmDeviceType" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: I214defcc26e08353e1aa4d414302cca214fce688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I214defcc26e08353e1aa4d414302cca214fce688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Long.valueOf" in "StorageHandlingCommandBase"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Long.valueOf" in "StorageHandlingCommandBase" ...................................................................... core: Use "Long.valueOf" in "StorageHandlingCommandBase" This is needed in order to avoid the following findbugs warning: Method invokes inefficient Number constructor; use static valueOf instead Using new Integer(int) is guaranteed to always result in a new object whereas Integer.valueOf(int) allows caching of values to be done by the compiler, class library, or JVM. Using of cached values avoids object allocation and the code will be faster. Values between -128 and 127 are guaranteed to have corresponding cached instances and using valueOf is approximately 3.5 times faster than using constructor. For values outside the constant range the performance of both styles is the same. Unless the class must be compatible with JVMs predating Java 1.5, use either autoboxing or the valueOf() method when creating instances of Long, Integer, Short, Character, and Byte. Bug kind and pattern: Bx - DM_NUMBER_CTOR Change-Id: I59e2c93b6e9ad26e3ca345483e9cc0b863a0ecbf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e2c93b6e9ad26e3ca345483e9cc0b863a0ecbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "VmHandler"
by juan.hernandez＠redhat.com 25 Sep '15

25 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use "Integer.parseInt" in "VmHandler" ...................................................................... core: Use "Integer.parseInt" in "VmHandler" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ibccaea79c32522aa1c08398565b552b4aa69974e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibccaea79c32522aa1c08398565b552b4aa69974e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0